Marmelator/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't mention ES6 classes, since they should *not* be used everywhere in the code base until https://bugzilla.mozilla.org/show_bug.cgi?id=1167472 is fixed; and use shorthand notation for methods as well as objects (https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Operators/Object_initializer#New_notations_in_ECMAScript_2015).

Jonas Jenwald 2017-04-17 19:04:34 +02:00
parent 43da181579
commit 3e17668b4e
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Style-Guide.md

@ -45,7 +45,7 @@ if (someVar === conditionA) {
Variables must be defined only once within a function scope, preferably at the top of the function. Variables must be defined only once within a function scope, preferably at the top of the function.
## Classes ## Classes
The transition towards ES6 classes has started, but until that is completed, the standard way of creating classes in PDF.js, when adding *new* code, is the following. Please note that by class we mean an object that is class-like. The standard way of creating classes in PDF.js, when adding *new* code, is the following. Please note that by class we mean an object that is class-like.
```javascript ```javascript
var ClassName = (function ClassNameClosure() { var ClassName = (function ClassNameClosure() {
@ -54,13 +54,13 @@ var ClassName = (function ClassNameClosure() {
} }
ClassName.prototype = { ClassName.prototype = {
functionName: function(arg1, arg2, ...) { functionName(arg1, arg2, ...) {
... ...
}, },
aVeryVeryVeryLongFunctionName: function (arg1, aVeryVeryVeryLongFunctionName(arg1,
arg2, arg2,
...) { ...) {
... ...
}, },
}; };