From fec123b0e994758d87d06753e3534818ba49b517 Mon Sep 17 00:00:00 2001 From: Brendan Dahl Date: Fri, 28 Feb 2020 09:13:45 -0800 Subject: [PATCH] Updated Contributing (markdown) --- Contributing.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Contributing.md b/Contributing.md index 469c165..72a609f 100644 --- a/Contributing.md +++ b/Contributing.md @@ -133,7 +133,7 @@ Create a pull request on GitHub for your feature branch. The code will then be r Note that the translations for PDF.js in the `l10n` folder are synchronized with the Aurora branch of Mozilla Firefox. This means that we will only accept pull requests that add strings currently missing in the Aurora branch (as it will take at least six weeks before the most recent translations are in the Aurora branch), but keep in mind that the changes will be overwritten when we synchronize again. ### 7. Code review and automated testing -In addition to the GitHub pull request workflow, it is highly recommended that you communicate with the PDF.js team, for example via the `#pdfjs` IRC channel at `irc.mozilla.org`. That will help to find a reviewer for your patch and speed up the review process. The reviewer will kick off further testing and do a code review. +In addition to the GitHub pull request workflow, it is highly recommended that you communicate with the PDF.js team, for example via the [Matrix room](https://chat.mozilla.org/#/room/#pdfjs:mozilla.org). That will help to find a reviewer for your patch and speed up the review process. The reviewer will kick off further testing and do a code review. You can speed up fetching a remote GitHub branch (possibly belonging to another user) using `git try {username} {branch_name}`. Add the following to the `.git/config` file to be able to do that: ```