From 46f3b74cb560e34bf6ec08d1ed430b193125e0ad Mon Sep 17 00:00:00 2001 From: Thomas Beyer Date: Tue, 21 Mar 2023 14:18:14 +0100 Subject: [PATCH] RED-4875 - close pdfdoc in finally and add UtilityClass annotation for class PdfTextExtraction --- .../pdftronlogic/commons/InvisibleElementRemovalService.java | 3 ++- .../com/iqser/red/pdftronlogic/commons/PdfTextExtraction.java | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/iqser/red/pdftronlogic/commons/InvisibleElementRemovalService.java b/src/main/java/com/iqser/red/pdftronlogic/commons/InvisibleElementRemovalService.java index e62040e..872b387 100644 --- a/src/main/java/com/iqser/red/pdftronlogic/commons/InvisibleElementRemovalService.java +++ b/src/main/java/com/iqser/red/pdftronlogic/commons/InvisibleElementRemovalService.java @@ -69,9 +69,10 @@ public class InvisibleElementRemovalService { } catch (Exception e) { log.error("File could not be saved after invisible element removal"); throw new RuntimeException(e); + } finally { + pdfDoc.close(); } - pdfDoc.close(); } diff --git a/src/main/java/com/iqser/red/pdftronlogic/commons/PdfTextExtraction.java b/src/main/java/com/iqser/red/pdftronlogic/commons/PdfTextExtraction.java index 06d0ea4..bb6a762 100644 --- a/src/main/java/com/iqser/red/pdftronlogic/commons/PdfTextExtraction.java +++ b/src/main/java/com/iqser/red/pdftronlogic/commons/PdfTextExtraction.java @@ -11,7 +11,9 @@ import com.pdftron.pdf.Page; import com.pdftron.pdf.PageIterator; import com.pdftron.pdf.TextExtractor; +import lombok.experimental.UtilityClass; +@UtilityClass public class PdfTextExtraction { private static String execute(PDFDoc pdfDoc) throws IOException, PDFNetException{