From 1873fc9ed41f52ee8c241cd27d0d591041385703 Mon Sep 17 00:00:00 2001 From: devplant Date: Wed, 13 Apr 2022 12:41:40 +0300 Subject: [PATCH] RED-3834 - On saving attribute values, blank strings should be normalized to null - fix PMD failure --- .../service/persistence/DossierAttributePersistenceService.java | 2 +- .../service/persistence/FileStatusPersistenceService.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/persistence/DossierAttributePersistenceService.java b/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/persistence/DossierAttributePersistenceService.java index 5908b759c..716711607 100644 --- a/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/persistence/DossierAttributePersistenceService.java +++ b/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/persistence/DossierAttributePersistenceService.java @@ -33,7 +33,7 @@ public class DossierAttributePersistenceService { public void updateDossierAttribute(String dossierId, String dossierAttributeId, String dossierAttributeValue) { dossierAttributeRepository.updateDossierAttribute(new DossierAttributeEntity.DossierAttributeEntityId(dossierId, dossierAttributeId), - (dossierAttributeValue != null && dossierAttributeValue.trim().isEmpty()) ? null: dossierAttributeValue); + dossierAttributeValue != null && dossierAttributeValue.trim().isEmpty() ? null: dossierAttributeValue); } diff --git a/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/persistence/FileStatusPersistenceService.java b/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/persistence/FileStatusPersistenceService.java index f29956d96..5ea123933 100644 --- a/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/persistence/FileStatusPersistenceService.java +++ b/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/persistence/FileStatusPersistenceService.java @@ -328,7 +328,7 @@ public class FileStatusPersistenceService { .findAny().map(FileAttributeConfigEntity::getId) .orElseThrow(() -> new BadRequestException("Invalid File Attribute Id"))); fa.setFileAttributeId(id); - fa.setValue((entry.getValue()!= null && entry.getValue().trim().isEmpty())? null : entry.getValue()); + fa.setValue(entry.getValue()!= null && entry.getValue().trim().isEmpty()? null : entry.getValue()); return fa; }).collect(Collectors.toList()); }