null checks

This commit is contained in:
Kilian Schuettler 2024-07-26 14:56:12 +02:00
parent 7538ecef16
commit 1dda29be34
3 changed files with 7 additions and 3 deletions

View File

@ -160,7 +160,9 @@ public class DossierTemplateImportService {
} catch (Exception e) { } catch (Exception e) {
log.error("Error with message: {} occurred during import, undo import", e.getMessage(), e); log.error("Error with message: {} occurred during import, undo import", e.getMessage(), e);
dossierTemplateManagementService.deleteDossierTemplateCompletely(templateImportInfo.getDossierTemplateId()); if (templateImportInfo != null && templateImportInfo.getDossierTemplateId() != null) {
dossierTemplateManagementService.deleteDossierTemplateCompletely(templateImportInfo.getDossierTemplateId());
}
throw e; throw e;
} }

View File

@ -76,7 +76,10 @@ public class FileExchangeImportService {
} }
return templateImportInfo.getDossierTemplateId(); return templateImportInfo.getDossierTemplateId();
} catch (Exception e) { } catch (Exception e) {
dossierTemplateManagementService.deleteDossierTemplateCompletely(templateImportInfo.getDossierTemplateId()); log.error("Error with message {} ocurred, deleting imported dossier template again.", e.getMessage());
if (templateImportInfo.getDossierTemplateId() != null) {
dossierTemplateManagementService.deleteDossierTemplateCompletely(templateImportInfo.getDossierTemplateId());
}
throw e; throw e;
} }
} }

View File

@ -43,7 +43,6 @@ public class DossierTemplatePersistenceService {
final DossierTemplateRepository dossierTemplateRepository; final DossierTemplateRepository dossierTemplateRepository;
final LegalBasisMappingPersistenceService legalBasisMappingPersistenceService; final LegalBasisMappingPersistenceService legalBasisMappingPersistenceService;
final RulesPersistenceService rulesPersistenceService; final RulesPersistenceService rulesPersistenceService;
final DictionaryPersistenceService dictionaryPersistenceService;
final TypeRepository typeRepository; final TypeRepository typeRepository;
static int MAX_NAME_LENGTH = 255; static int MAX_NAME_LENGTH = 255;