Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-9472

Browse Source 
fixing 500 bug when calling upload endpoint
This commit is contained in:
yhampe 2024-12-13 13:16:48 +01:00
parent dbf85761bd
commit 3c2326e3f5
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
persistence-service-v1/persistence-service-external-api-impl-v1/src/main/java/com/iqser/red/persistence/service/v1/external/api/impl/controller/RulesController.java vendored
View File

@ -93,6 +93,7 @@ public class RulesController implements RulesResource {
} catch (FeignException e) { } catch (FeignException e) {
if (e.status() == HttpStatus.BAD_REQUEST.value()) { if (e.status() == HttpStatus.BAD_REQUEST.value()) {
log.info("exception: " + e);
throw new BadRequestException("The provided rule file is not a valid drools rule file!"); throw new BadRequestException("The provided rule file is not a valid drools rule file!");
} }
throw new BadRequestException("Failed to merge rules: " + e.getMessage()); throw new BadRequestException("Failed to merge rules: " + e.getMessage());
@ -171,9 +172,7 @@ public class RulesController implements RulesResource {
if (ruleEntityOptional.isEmpty()) { if (ruleEntityOptional.isEmpty()) {
throw new NotFoundException(String.format("No rule file of type %s found for dossierTemplateId %s", ruleFileType, dossierTemplateId)); throw new NotFoundException(String.format("No rule file of type %s found for dossierTemplateId %s", ruleFileType, dossierTemplateId));
} }
log.info("calling rules management to remove system rules of file");
SystemRulesSeperationRequest systemRulesSeperationRequest = new SystemRulesSeperationRequest(ruleEntityOptional.get().getValue()); SystemRulesSeperationRequest systemRulesSeperationRequest = new SystemRulesSeperationRequest(ruleEntityOptional.get().getValue());
log.info(systemRulesSeperationRequest.getRules());
String cleanedRules = ruleBuilderClient.getRuleFileWithoutSystemRules(systemRulesSeperationRequest).getRules(); String cleanedRules = ruleBuilderClient.getRuleFileWithoutSystemRules(systemRulesSeperationRequest).getRules();
ruleEntityOptional.get().setValue(cleanedRules); ruleEntityOptional.get().setValue(cleanedRules);
return new RulesResponse(ruleEntityOptional.get().getValue(), dossierTemplateId, ruleEntityOptional.get().isTimeoutDetected()); return new RulesResponse(ruleEntityOptional.get().getValue(), dossierTemplateId, ruleEntityOptional.get().isTimeoutDetected());