From 498cd236c07fd57a8deaa5fdea3d2eb57570b081 Mon Sep 17 00:00:00 2001
From: Ali Oezyetimoglu <ali.oezyetimoglu@knecon.com>
Date: Tue, 16 Apr 2024 18:10:42 +0200
Subject: [PATCH] RED-8480: differenciate between recategorize and legal basis
 change

---
 .../v1/processor/service/EntityLogMergeService.java       | 2 --
 .../v1/server/integration/tests/ManualRedactionTest.java  | 8 ++++----
 .../annotations/entitymapped/ManualLegalBasisChange.java  | 1 -
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/EntityLogMergeService.java b/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/EntityLogMergeService.java
index 8605daa86..931b33569 100644
--- a/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/EntityLogMergeService.java
+++ b/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/EntityLogMergeService.java
@@ -357,7 +357,6 @@ public class EntityLogMergeService {
     }
 
 
-    @Deprecated(forRemoval = true)
     private void mergeLegalBasisChange(ManualLegalBasisChange manualLegalBasisChange,
                                        EntityLogEntry entityLogEntry,
                                        int analysisNumber) {
@@ -379,7 +378,6 @@ public class EntityLogMergeService {
     }
 
 
-    @Deprecated(forRemoval = true)
     private Map<String, String> getPropertyChanges(ManualLegalBasisChange manualLegalBasisChange) {
 
         Map<String, String> propertyChanges = new HashMap<>();
diff --git a/persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/ManualRedactionTest.java b/persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/ManualRedactionTest.java
index 623549100..0e72469fe 100644
--- a/persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/ManualRedactionTest.java
+++ b/persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/ManualRedactionTest.java
@@ -2102,14 +2102,14 @@ public class ManualRedactionTest extends AbstractPersistenceServerServiceTest {
         manualRedactionClient.recategorizeBulk(dossier.getId(), file.getId(), Set.of(recatModel), false);
 
         var allManualRedactions = manualRedactionClient.getManualRedactions(dossier.getId(), file.getId(), false, true);
-        assertEquals(1, allManualRedactions.getRecategorizations().size());
-        assertTrue(allManualRedactions.getRecategorizations()
+        assertEquals(1, allManualRedactions.getLegalBasisChanges().size());
+        assertTrue(allManualRedactions.getLegalBasisChanges()
                            .stream()
                            .anyMatch(entry -> entry.getAnnotationId().equals("annotationId")));
-        assertTrue(allManualRedactions.getRecategorizations()
+        assertTrue(allManualRedactions.getLegalBasisChanges()
                            .stream()
                            .anyMatch(entry -> entry.getLegalBasis().equals("lb2")));
-        assertTrue(allManualRedactions.getRecategorizations()
+        assertTrue(allManualRedactions.getLegalBasisChanges()
                            .stream()
                            .anyMatch(entry -> entry.getSection().equals("section")));
     }
diff --git a/persistence-service-v1/persistence-service-shared-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/shared/model/annotations/entitymapped/ManualLegalBasisChange.java b/persistence-service-v1/persistence-service-shared-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/shared/model/annotations/entitymapped/ManualLegalBasisChange.java
index c06399fef..c04f12e80 100644
--- a/persistence-service-v1/persistence-service-shared-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/shared/model/annotations/entitymapped/ManualLegalBasisChange.java
+++ b/persistence-service-v1/persistence-service-shared-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/shared/model/annotations/entitymapped/ManualLegalBasisChange.java
@@ -6,7 +6,6 @@ import lombok.EqualsAndHashCode;
 import lombok.NoArgsConstructor;
 import lombok.experimental.SuperBuilder;
 
-@Deprecated(forRemoval = true)
 @Data
 @SuperBuilder
 @NoArgsConstructor