From 75d65b0972902483c9fa7d71a4adc8a1ea0cbb74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominique=20Eifl=C3=A4nder?= Date: Thu, 9 Jan 2025 10:52:12 +0100 Subject: [PATCH] RED-10697: Revert check technical name for legal basis on approval --- .../v1/processor/service/ApprovalVerificationService.java | 4 ++-- .../peristence/v1/server/integration/tests/ApprovalTest.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/ApprovalVerificationService.java b/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/ApprovalVerificationService.java index d1d2265ec..fa8af5be1 100644 --- a/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/ApprovalVerificationService.java +++ b/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/ApprovalVerificationService.java @@ -51,9 +51,9 @@ public class ApprovalVerificationService { addWarning(entry, WarningType.LEGAL_BASIS_MISSING, approveResponse); } else { var legalBasisEntity = legalBasisMappings.stream() - .filter(mapping -> mapping.getTechnicalName().equals(entry.getLegalBasis())) + .filter(mapping -> mapping.getReason().equals(entry.getLegalBasis())) .findFirst(); - if (legalBasisEntity.isEmpty() || StringUtils.isEmpty(legalBasisEntity.get().getTechnicalName())) { + if (legalBasisEntity.isEmpty() || StringUtils.isEmpty(legalBasisEntity.get().getReason())) { addWarning(entry, WarningType.UNMAPPED_JUSTIFICATION, approveResponse); } } diff --git a/persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/ApprovalTest.java b/persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/ApprovalTest.java index 044a66552..6b5d5edca 100644 --- a/persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/ApprovalTest.java +++ b/persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/ApprovalTest.java @@ -71,7 +71,7 @@ public class ApprovalTest extends AbstractPersistenceServerServiceTest { .id("id1") .positions(List.of(new Position(1, 1, 1, 1, 1))) .state(EntryState.APPLIED) - .legalBasis("legal_basis") + .legalBasis("legalBasis") .entryType(EntryType.ENTITY) .value("value") .build()));