From 9b9c79fc9923b4ba2c5183a02a388be01c01da4f Mon Sep 17 00:00:00 2001 From: Viktor Seifert Date: Fri, 5 May 2023 15:55:31 +0200 Subject: [PATCH] RED-6270: Added try-with-resources to correctly close file stream --- .../service/export/DossierTemplateExportService.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/export/DossierTemplateExportService.java b/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/export/DossierTemplateExportService.java index c5f57e614..6a9c23372 100644 --- a/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/export/DossierTemplateExportService.java +++ b/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/export/DossierTemplateExportService.java @@ -5,6 +5,7 @@ import static com.iqser.red.service.persistence.management.v1.processor.utils.Ma import java.io.ByteArrayOutputStream; import java.io.DataOutputStream; import java.io.IOException; +import java.io.InputStream; import java.util.List; import java.util.stream.Collectors; @@ -264,7 +265,11 @@ public class DossierTemplateExportService { private void storeZipFile(String storageId, FileSystemBackedArchiver fileSystemBackedArchiver) { long start = System.currentTimeMillis(); - fileManagementStorageService.storeObject(storageId, fileSystemBackedArchiver.toInputStream()); + try (InputStream data = fileSystemBackedArchiver.toInputStream()) { + fileManagementStorageService.storeObject(storageId, data); + } catch (IOException ex) { + log.warn("IO error when sending file to storage", ex); + } log.info("Successfully stored zip for downloadId {}, took {}", storageId, System.currentTimeMillis() - start); }