From bd344d2c07cf05fdc8c68f6df44f4d8830f05b5d Mon Sep 17 00:00:00 2001 From: Ali Oezyetimoglu Date: Fri, 17 Feb 2023 11:39:39 +0100 Subject: [PATCH] RED-5256: added consumes to getDossierInformation-endpoint and changed it from GET to POST && dossiers were not filtered before getting dossier information, if filteredDossierId was empty --- .../persistence/service/v1/api/resources/DossierResource.java | 4 ++-- .../peristence/v1/server/controller/DossierController.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/persistence-service-v1/persistence-service-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/resources/DossierResource.java b/persistence-service-v1/persistence-service-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/resources/DossierResource.java index 8eaa94c3c..b6bad26c3 100644 --- a/persistence-service-v1/persistence-service-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/resources/DossierResource.java +++ b/persistence-service-v1/persistence-service-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/resources/DossierResource.java @@ -26,7 +26,7 @@ public interface DossierResource { String REST_PATH = "/dossier"; String DOSSIER_TEMPLATE_PATH = "/dossier-template"; - String INFO_PATH = "/info"; + String INFO_PATH = "/dossier-info"; String DELETED_DOSSIERS_PATH = "/deletedDossiers"; String HARD_DELETE_PATH = "/hardDelete"; String UNDELETE_PATH = "/undelete"; @@ -75,7 +75,7 @@ public interface DossierResource { @RequestParam(name = INCLUDE_DELETED_PARAM, defaultValue = "false", required = false) boolean includeDeleted); - @GetMapping(value = REST_PATH + INFO_PATH, produces = MediaType.APPLICATION_JSON_VALUE) + @PostMapping(value = INFO_PATH, consumes = MediaType.APPLICATION_JSON_VALUE, produces = MediaType.APPLICATION_JSON_VALUE) DossierInformation getDossierInformation(@RequestBody List filteredDossierIds); diff --git a/persistence-service-v1/persistence-service-server-v1/src/main/java/com/iqser/red/service/peristence/v1/server/controller/DossierController.java b/persistence-service-v1/persistence-service-server-v1/src/main/java/com/iqser/red/service/peristence/v1/server/controller/DossierController.java index 227b45f03..3b4956594 100644 --- a/persistence-service-v1/persistence-service-server-v1/src/main/java/com/iqser/red/service/peristence/v1/server/controller/DossierController.java +++ b/persistence-service-v1/persistence-service-server-v1/src/main/java/com/iqser/red/service/peristence/v1/server/controller/DossierController.java @@ -144,7 +144,7 @@ public class DossierController implements DossierResource { DossierInformation dossierInformation = new DossierInformation(); var dossiers = dossierService.getAllDossiers(); - if (filteredDossierIds != null && !filteredDossierIds.isEmpty()) { + if (filteredDossierIds != null) { dossiers = dossiers.stream().filter(d -> filteredDossierIds.contains(d.getId())).collect(Collectors.toList()); } dossiers.forEach(d -> {