Merge branch 'RED-8589' into 'master'
RED-8589 - Add "MANUAL" engine to all annotations that has entries in manualChanges Closes RED-8589 See merge request redactmanager/persistence-service!361
This commit is contained in:
commit
ea3d47f435
@ -11,6 +11,7 @@ import java.util.HashSet;
|
|||||||
import java.util.List;
|
import java.util.List;
|
||||||
import java.util.Map;
|
import java.util.Map;
|
||||||
import java.util.Optional;
|
import java.util.Optional;
|
||||||
|
import java.util.Set;
|
||||||
import java.util.stream.Collectors;
|
import java.util.stream.Collectors;
|
||||||
import java.util.stream.Stream;
|
import java.util.stream.Stream;
|
||||||
|
|
||||||
@ -29,6 +30,7 @@ import com.iqser.red.service.persistence.service.v1.api.shared.model.AnalyzeRequ
|
|||||||
import com.iqser.red.service.persistence.service.v1.api.shared.model.MessageType;
|
import com.iqser.red.service.persistence.service.v1.api.shared.model.MessageType;
|
||||||
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.Change;
|
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.Change;
|
||||||
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.ChangeType;
|
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.ChangeType;
|
||||||
|
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.Engine;
|
||||||
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.EntityLog;
|
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.EntityLog;
|
||||||
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.EntityLogEntry;
|
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.EntityLogEntry;
|
||||||
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.EntryState;
|
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.EntryState;
|
||||||
@ -149,7 +151,7 @@ public class EntityLogMergeService {
|
|||||||
.excluded(false)
|
.excluded(false)
|
||||||
.changes(changes)
|
.changes(changes)
|
||||||
.manualChanges(manualChanges)
|
.manualChanges(manualChanges)
|
||||||
.engines(new HashSet<>())
|
.engines(Set.of(Engine.MANUAL))
|
||||||
.reference(new HashSet<>())
|
.reference(new HashSet<>())
|
||||||
.importedRedactionIntersections(new HashSet<>())
|
.importedRedactionIntersections(new HashSet<>())
|
||||||
.build();
|
.build();
|
||||||
@ -183,6 +185,7 @@ public class EntityLogMergeService {
|
|||||||
var entity = entityLogEntries.stream().filter(entityLogEntry -> entityLogEntry.getId().equals(idRemoval.getAnnotationId())).findAny();
|
var entity = entityLogEntries.stream().filter(entityLogEntry -> entityLogEntry.getId().equals(idRemoval.getAnnotationId())).findAny();
|
||||||
entity.ifPresent(entityLogEntry -> {
|
entity.ifPresent(entityLogEntry -> {
|
||||||
entityLogEntry.setState(EntryState.IGNORED);
|
entityLogEntry.setState(EntryState.IGNORED);
|
||||||
|
entityLogEntry.getEngines().add(Engine.MANUAL);
|
||||||
addChanges(entityLogEntry.getChanges(), ChangeType.REMOVED, analysisNumber, idRemoval.getRequestDate());
|
addChanges(entityLogEntry.getChanges(), ChangeType.REMOVED, analysisNumber, idRemoval.getRequestDate());
|
||||||
entityLogEntry.getManualChanges()
|
entityLogEntry.getManualChanges()
|
||||||
.add(ManualChange.builder()
|
.add(ManualChange.builder()
|
||||||
@ -203,6 +206,7 @@ public class EntityLogMergeService {
|
|||||||
entityLogEntry.setTextBefore(manualResizeRedaction.getTextBefore());
|
entityLogEntry.setTextBefore(manualResizeRedaction.getTextBefore());
|
||||||
entityLogEntry.setPositions(convertPositions(manualResizeRedaction.getPositions()));
|
entityLogEntry.setPositions(convertPositions(manualResizeRedaction.getPositions()));
|
||||||
entityLogEntry.setValue(manualResizeRedaction.getValue());
|
entityLogEntry.setValue(manualResizeRedaction.getValue());
|
||||||
|
entityLogEntry.getEngines().add(Engine.MANUAL);
|
||||||
addChanges(entityLogEntry.getChanges(), ChangeType.CHANGED, analysisNumber, manualResizeRedaction.getRequestDate());
|
addChanges(entityLogEntry.getChanges(), ChangeType.CHANGED, analysisNumber, manualResizeRedaction.getRequestDate());
|
||||||
ManualChange.ManualChangeBuilder manualChange = ManualChange.builder()
|
ManualChange.ManualChangeBuilder manualChange = ManualChange.builder()
|
||||||
.manualRedactionType(manualResizeRedaction.getUpdateDictionary() ? ManualRedactionType.RESIZE_IN_DICTIONARY : ManualRedactionType.RESIZE)
|
.manualRedactionType(manualResizeRedaction.getUpdateDictionary() ? ManualRedactionType.RESIZE_IN_DICTIONARY : ManualRedactionType.RESIZE)
|
||||||
@ -224,6 +228,7 @@ public class EntityLogMergeService {
|
|||||||
entityLogEntry.setLegalBasis(manualLegalBasisChange.getLegalBasis());
|
entityLogEntry.setLegalBasis(manualLegalBasisChange.getLegalBasis());
|
||||||
entityLogEntry.setSection(manualLegalBasisChange.getSection());
|
entityLogEntry.setSection(manualLegalBasisChange.getSection());
|
||||||
entityLogEntry.setValue(manualLegalBasisChange.getValue());
|
entityLogEntry.setValue(manualLegalBasisChange.getValue());
|
||||||
|
entityLogEntry.getEngines().add(Engine.MANUAL);
|
||||||
addChanges(entityLogEntry.getChanges(), ChangeType.CHANGED, analysisNumber, manualLegalBasisChange.getRequestDate());
|
addChanges(entityLogEntry.getChanges(), ChangeType.CHANGED, analysisNumber, manualLegalBasisChange.getRequestDate());
|
||||||
Map<String, String> propertyChanges = getPropertyChanges(manualLegalBasisChange);
|
Map<String, String> propertyChanges = getPropertyChanges(manualLegalBasisChange);
|
||||||
entityLogEntry.getManualChanges()
|
entityLogEntry.getManualChanges()
|
||||||
@ -263,6 +268,7 @@ public class EntityLogMergeService {
|
|||||||
entityLogEntry.setType(recategorization.getType());
|
entityLogEntry.setType(recategorization.getType());
|
||||||
entityLogEntry.setEntryType(getEntryType(isHint, recategorization.getType()));
|
entityLogEntry.setEntryType(getEntryType(isHint, recategorization.getType()));
|
||||||
entityLogEntry.setState(isHint ? EntryState.SKIPPED : EntryState.APPLIED);
|
entityLogEntry.setState(isHint ? EntryState.SKIPPED : EntryState.APPLIED);
|
||||||
|
entityLogEntry.getEngines().add(Engine.MANUAL);
|
||||||
addChanges(entityLogEntry.getChanges(), ChangeType.CHANGED, analysisNumber, recategorization.getRequestDate());
|
addChanges(entityLogEntry.getChanges(), ChangeType.CHANGED, analysisNumber, recategorization.getRequestDate());
|
||||||
entityLogEntry.getManualChanges()
|
entityLogEntry.getManualChanges()
|
||||||
.add(ManualChange.builder()
|
.add(ManualChange.builder()
|
||||||
@ -282,6 +288,7 @@ public class EntityLogMergeService {
|
|||||||
entity.ifPresent(entityLogEntry -> {
|
entity.ifPresent(entityLogEntry -> {
|
||||||
entityLogEntry.setLegalBasis(forceRedaction.getLegalBasis());
|
entityLogEntry.setLegalBasis(forceRedaction.getLegalBasis());
|
||||||
entityLogEntry.setState(entityLogEntry.getEntryType().equals(EntryType.HINT) ? EntryState.SKIPPED : EntryState.APPLIED);
|
entityLogEntry.setState(entityLogEntry.getEntryType().equals(EntryType.HINT) ? EntryState.SKIPPED : EntryState.APPLIED);
|
||||||
|
entityLogEntry.getEngines().add(Engine.MANUAL);
|
||||||
addChanges(entityLogEntry.getChanges(), ChangeType.CHANGED, analysisNumber, forceRedaction.getRequestDate());
|
addChanges(entityLogEntry.getChanges(), ChangeType.CHANGED, analysisNumber, forceRedaction.getRequestDate());
|
||||||
var forceRedactManualChange = ManualChange.builder()
|
var forceRedactManualChange = ManualChange.builder()
|
||||||
.manualRedactionType(entityLogEntry.getEntryType().equals(EntryType.HINT) ? ManualRedactionType.FORCE_HINT : ManualRedactionType.FORCE_REDACT)
|
.manualRedactionType(entityLogEntry.getEntryType().equals(EntryType.HINT) ? ManualRedactionType.FORCE_HINT : ManualRedactionType.FORCE_REDACT)
|
||||||
|
|||||||
@ -40,6 +40,7 @@ import com.iqser.red.service.persistence.management.v1.processor.service.persist
|
|||||||
import com.iqser.red.service.persistence.management.v1.processor.service.persistence.FileStatusPersistenceService;
|
import com.iqser.red.service.persistence.management.v1.processor.service.persistence.FileStatusPersistenceService;
|
||||||
import com.iqser.red.service.persistence.service.v1.api.shared.model.AnalyzeRequest;
|
import com.iqser.red.service.persistence.service.v1.api.shared.model.AnalyzeRequest;
|
||||||
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.ChangeType;
|
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.ChangeType;
|
||||||
|
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.Engine;
|
||||||
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.EntityLog;
|
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.EntityLog;
|
||||||
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.EntityLogEntry;
|
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.EntityLogEntry;
|
||||||
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.EntryState;
|
import com.iqser.red.service.persistence.service.v1.api.shared.model.analysislog.entitylog.EntryState;
|
||||||
@ -145,6 +146,7 @@ public class EntityLogMergeTest {
|
|||||||
assertEquals(entityLogEntry.getState(), EntryState.APPLIED);
|
assertEquals(entityLogEntry.getState(), EntryState.APPLIED);
|
||||||
assertEquals(entityLogEntry.getValue(), "Test");
|
assertEquals(entityLogEntry.getValue(), "Test");
|
||||||
assertEquals(entityLogEntry.getReason(), "Reason");
|
assertEquals(entityLogEntry.getReason(), "Reason");
|
||||||
|
assertTrue(entityLogEntry.getEngines().contains(Engine.MANUAL));
|
||||||
assertEquals(entityLogEntry.getManualChanges().get(0).getManualRedactionType(), ManualRedactionType.ADD_LOCALLY);
|
assertEquals(entityLogEntry.getManualChanges().get(0).getManualRedactionType(), ManualRedactionType.ADD_LOCALLY);
|
||||||
|
|
||||||
var optionalRemoveEntryLogEntry = response.getEntityLogEntry().stream().filter(entityLogEntry1 -> entityLogEntry1.getId().equals(entryToRemoveId)).findFirst();
|
var optionalRemoveEntryLogEntry = response.getEntityLogEntry().stream().filter(entityLogEntry1 -> entityLogEntry1.getId().equals(entryToRemoveId)).findFirst();
|
||||||
@ -154,6 +156,7 @@ public class EntityLogMergeTest {
|
|||||||
assertEquals(removeEntryLogEntry.getState(), EntryState.IGNORED);
|
assertEquals(removeEntryLogEntry.getState(), EntryState.IGNORED);
|
||||||
assertEquals(removeEntryLogEntry.getManualChanges().get(0).getManualRedactionType(), ManualRedactionType.REMOVE_LOCALLY);
|
assertEquals(removeEntryLogEntry.getManualChanges().get(0).getManualRedactionType(), ManualRedactionType.REMOVE_LOCALLY);
|
||||||
assertEquals(removeEntryLogEntry.getChanges().get(0).getType(), ChangeType.REMOVED);
|
assertEquals(removeEntryLogEntry.getChanges().get(0).getType(), ChangeType.REMOVED);
|
||||||
|
assertTrue(removeEntryLogEntry.getEngines().contains(Engine.MANUAL));
|
||||||
|
|
||||||
var optionalResizeEntryLogEntry = response.getEntityLogEntry().stream().filter(entityLogEntry1 -> entityLogEntry1.getId().equals(entryToResizeId)).findFirst();
|
var optionalResizeEntryLogEntry = response.getEntityLogEntry().stream().filter(entityLogEntry1 -> entityLogEntry1.getId().equals(entryToResizeId)).findFirst();
|
||||||
assertTrue(optionalResizeEntryLogEntry.isPresent());
|
assertTrue(optionalResizeEntryLogEntry.isPresent());
|
||||||
@ -167,6 +170,7 @@ public class EntityLogMergeTest {
|
|||||||
assertEquals(resizeEntryLogEntry.getState(), EntryState.APPLIED);
|
assertEquals(resizeEntryLogEntry.getState(), EntryState.APPLIED);
|
||||||
assertEquals(resizeEntryLogEntry.getManualChanges().get(0).getManualRedactionType(), ManualRedactionType.RESIZE);
|
assertEquals(resizeEntryLogEntry.getManualChanges().get(0).getManualRedactionType(), ManualRedactionType.RESIZE);
|
||||||
assertEquals(resizeEntryLogEntry.getChanges().get(0).getType(), ChangeType.CHANGED);
|
assertEquals(resizeEntryLogEntry.getChanges().get(0).getType(), ChangeType.CHANGED);
|
||||||
|
assertTrue(resizeEntryLogEntry.getEngines().contains(Engine.MANUAL));
|
||||||
|
|
||||||
var optionalLegalBasisEntryLogEntry = response.getEntityLogEntry().stream().filter(entityLogEntry1 -> entityLogEntry1.getId().equals(entryLegalBasisId)).findFirst();
|
var optionalLegalBasisEntryLogEntry = response.getEntityLogEntry().stream().filter(entityLogEntry1 -> entityLogEntry1.getId().equals(entryLegalBasisId)).findFirst();
|
||||||
assertTrue(optionalLegalBasisEntryLogEntry.isPresent());
|
assertTrue(optionalLegalBasisEntryLogEntry.isPresent());
|
||||||
@ -176,6 +180,7 @@ public class EntityLogMergeTest {
|
|||||||
assertEquals(legalBasisEntryLogEntry.getState(), EntryState.APPLIED);
|
assertEquals(legalBasisEntryLogEntry.getState(), EntryState.APPLIED);
|
||||||
assertEquals(legalBasisEntryLogEntry.getManualChanges().get(0).getManualRedactionType(), ManualRedactionType.LEGAL_BASIS_CHANGE);
|
assertEquals(legalBasisEntryLogEntry.getManualChanges().get(0).getManualRedactionType(), ManualRedactionType.LEGAL_BASIS_CHANGE);
|
||||||
assertEquals(legalBasisEntryLogEntry.getChanges().get(0).getType(), ChangeType.CHANGED);
|
assertEquals(legalBasisEntryLogEntry.getChanges().get(0).getType(), ChangeType.CHANGED);
|
||||||
|
assertTrue(legalBasisEntryLogEntry.getEngines().contains(Engine.MANUAL));
|
||||||
|
|
||||||
var optionalForceRedactionEntryLogEntry = response.getEntityLogEntry().stream().filter(entityLogEntry1 -> entityLogEntry1.getId().equals(forceRedactionId)).findFirst();
|
var optionalForceRedactionEntryLogEntry = response.getEntityLogEntry().stream().filter(entityLogEntry1 -> entityLogEntry1.getId().equals(forceRedactionId)).findFirst();
|
||||||
assertTrue(optionalForceRedactionEntryLogEntry.isPresent());
|
assertTrue(optionalForceRedactionEntryLogEntry.isPresent());
|
||||||
@ -185,6 +190,7 @@ public class EntityLogMergeTest {
|
|||||||
assertEquals(forceRedactionEntryLogEntry.getState(), EntryState.APPLIED);
|
assertEquals(forceRedactionEntryLogEntry.getState(), EntryState.APPLIED);
|
||||||
assertEquals(forceRedactionEntryLogEntry.getManualChanges().get(0).getManualRedactionType(), ManualRedactionType.FORCE_REDACT);
|
assertEquals(forceRedactionEntryLogEntry.getManualChanges().get(0).getManualRedactionType(), ManualRedactionType.FORCE_REDACT);
|
||||||
assertEquals(forceRedactionEntryLogEntry.getChanges().get(0).getType(), ChangeType.CHANGED);
|
assertEquals(forceRedactionEntryLogEntry.getChanges().get(0).getType(), ChangeType.CHANGED);
|
||||||
|
assertTrue(forceRedactionEntryLogEntry.getEngines().contains(Engine.MANUAL));
|
||||||
|
|
||||||
var optionalRectangleEntryLogEntry = response.getEntityLogEntry().stream().filter(entityLogEntry1 -> entityLogEntry1.getId().equals(rectangleToAddId)).findFirst();
|
var optionalRectangleEntryLogEntry = response.getEntityLogEntry().stream().filter(entityLogEntry1 -> entityLogEntry1.getId().equals(rectangleToAddId)).findFirst();
|
||||||
assertTrue(optionalRectangleEntryLogEntry.isPresent());
|
assertTrue(optionalRectangleEntryLogEntry.isPresent());
|
||||||
@ -195,6 +201,7 @@ public class EntityLogMergeTest {
|
|||||||
assertEquals(rectangleEntryLogEntry.getValue(), "Test2");
|
assertEquals(rectangleEntryLogEntry.getValue(), "Test2");
|
||||||
assertEquals(rectangleEntryLogEntry.getReason(), "Rectangle");
|
assertEquals(rectangleEntryLogEntry.getReason(), "Rectangle");
|
||||||
assertEquals(rectangleEntryLogEntry.getManualChanges().get(0).getManualRedactionType(), ManualRedactionType.ADD_LOCALLY);
|
assertEquals(rectangleEntryLogEntry.getManualChanges().get(0).getManualRedactionType(), ManualRedactionType.ADD_LOCALLY);
|
||||||
|
assertTrue(rectangleEntryLogEntry.getEngines().contains(Engine.MANUAL));
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user