Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-4515: Removed workarounds that set default tenant if no tenant is available

Browse Source
This commit is contained in:
deiflaender 2023-03-16 12:07:09 +01:00
parent 33dafca80e
commit ef859f527d
8 changed files with 6 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/multitenancy/MultiTenancyMessagingConfiguration.java
View File

@ -1,6 +1,5 @@
package com.iqser.red.service.persistence.management.v1.processor.multitenancy;
import static com.iqser.red.service.persistence.management.v1.processor.multitenancy.TenantInterceptor.DEFAULT_TENANT;
import static com.iqser.red.service.persistence.management.v1.processor.multitenancy.TenantInterceptor.TENANT_HEADER_NAME;
import org.springframework.amqp.rabbit.config.AbstractRabbitListenerContainerFactory;
@ -38,8 +37,7 @@ public class MultiTenancyMessagingConfiguration {
if (tenant != null) {
TenantContext.setTenantId(tenant);
} else {
// TODO Remove if multitenancy is fully integrated.
TenantContext.setTenantId(DEFAULT_TENANT);
throw new RuntimeException("No Tenant is set queue message");
}
return m;
});

6
persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/multitenancy/TenantInterceptor.java
View File

@ -17,11 +17,7 @@ public class TenantInterceptor implements WebRequestInterceptor {
@Override
public void preHandle(WebRequest request) {
if (request.getHeader(TENANT_HEADER_NAME) != null) {
TenantContext.setTenantId(request.getHeader(TENANT_HEADER_NAME));
} else {
TenantContext.setTenantId(DEFAULT_TENANT);
}
TenantContext.setTenantId(request.getHeader(TENANT_HEADER_NAME));
}

3
persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/service/DossierTesterAndProvider.java
View File

@ -11,7 +11,7 @@ import org.springframework.stereotype.Service;
import com.google.common.collect.Sets;
import com.iqser.red.service.peristence.v1.server.integration.client.DossierClient;
import com.iqser.red.service.persistence.management.v1.processor.service.UserService;
import com.iqser.red.service.persistence.management.v1.processor.utils.multitenancy.TenantContext;
import com.iqser.red.service.persistence.service.v1.api.shared.model.DossierRequest;
import com.iqser.red.service.persistence.service.v1.api.shared.model.DossierTemplateModel;
import com.iqser.red.service.persistence.service.v1.api.shared.model.dossiertemplate.DownloadFileType;
@ -42,6 +42,7 @@ public class DossierTesterAndProvider {
public Dossier provideTestDossier(DossierTemplateModel testTemplate, String dossierName) {
TenantContext.setTenantId("redaction");
return provideTestDossier(testTemplate, dossierName, null);
}

3
persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/service/FileTesterAndProvider.java
View File

@ -16,7 +16,6 @@ import com.iqser.red.service.peristence.v1.server.integration.client.FileClient;
import com.iqser.red.service.peristence.v1.server.integration.client.UploadClient;
import com.iqser.red.service.persistence.management.v1.processor.service.FileManagementStorageService;
import com.iqser.red.service.persistence.management.v1.processor.service.FileStatusService;
import com.iqser.red.service.persistence.management.v1.processor.utils.multitenancy.TenantContext;
import com.iqser.red.service.persistence.service.v1.api.shared.model.AnalyzeResult;
import com.iqser.red.service.persistence.service.v1.api.shared.model.FileStatus;
import com.iqser.red.service.persistence.service.v1.api.shared.model.dossiertemplate.dossier.Dossier;
@ -92,7 +91,6 @@ public class FileTesterAndProvider {
public void markFileAsProcessed(String fileId) {
TenantContext.setTenantId("redaction");
AnalyzeResult result = new AnalyzeResult();
result.setFileId(fileId);
result.setNumberOfPages(100);
@ -105,7 +103,6 @@ public class FileTesterAndProvider {
result.setAnalysisVersion(1);
fileStatusService.setStatusSuccessful(fileId, result);
fileStatusService.setStatusProcessed(fileId);
TenantContext.clear();
}
}

7
persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/AuditTest.java
View File

@ -12,8 +12,6 @@ import com.iqser.red.service.peristence.v1.server.integration.service.UserProvid
import com.iqser.red.service.peristence.v1.server.integration.utils.AbstractPersistenceServerServiceTest;
import com.iqser.red.service.persistence.management.v1.processor.service.persistence.AuditPersistenceService;
import com.iqser.red.service.persistence.management.v1.processor.service.persistence.repository.AuditRepository;
import com.iqser.red.service.persistence.management.v1.processor.utils.multitenancy.TenantContext;
import com.iqser.red.service.persistence.service.v1.api.shared.model.AuditCategory;
import com.iqser.red.service.persistence.service.v1.api.shared.model.audit.AuditRequest;
import com.iqser.red.service.persistence.service.v1.api.shared.model.audit.AuditSearchRequest;
import com.iqser.red.service.persistence.service.v1.api.shared.model.audit.CategoryModel;
@ -36,8 +34,6 @@ public class AuditTest extends AbstractPersistenceServerServiceTest {
@Test
public void testAudit() {
TenantContext.setTenantId("redaction");
var userId = userProvider.getUserId();
auditPersistenceService.audit(AuditRequest.builder().category("c1").message("test").userId(userId).objectId("1").details(Map.of("key", "value")).build());
@ -54,9 +50,6 @@ public class AuditTest extends AbstractPersistenceServerServiceTest {
result = auditClient.searchAuditLog(AuditSearchRequest.builder().build());
assertThat(result.getTotalHits()).isGreaterThanOrEqualTo(3);
assertThat(auditClient.getAuditCategories()).isNotEmpty();
TenantContext.clear();
}
}

3
persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/DossierTest.java
View File

@ -23,7 +23,6 @@ import com.iqser.red.service.peristence.v1.server.integration.service.DossierTes
import com.iqser.red.service.peristence.v1.server.integration.service.TypeProvider;
import com.iqser.red.service.peristence.v1.server.integration.utils.AbstractPersistenceServerServiceTest;
import com.iqser.red.service.persistence.management.v1.processor.service.DossierManagementService;
import com.iqser.red.service.persistence.management.v1.processor.utils.multitenancy.TenantContext;
import com.iqser.red.service.persistence.service.v1.api.shared.model.DossierRequest;
import com.iqser.red.service.persistence.service.v1.api.shared.model.DossierStatusRequest;
import com.iqser.red.service.persistence.service.v1.api.shared.model.WatermarkModel;
@ -216,7 +215,6 @@ public class DossierTest extends AbstractPersistenceServerServiceTest {
@Test
public void testArchiveDossier() {
TenantContext.setTenantId("redaction");
var template = dossierTemplateTesterAndProvider.provideTestTemplate();
@ -321,7 +319,6 @@ public class DossierTest extends AbstractPersistenceServerServiceTest {
// assertThat(dossierInformation.getNumberOfHardDeletedDossiers()).isEqualTo(0);
// assertThat(dossierInformation.getNumberOfArchivedDossiers()).isEqualTo(1);
TenantContext.clear();
}

2
persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/DownloadTest.java
View File

@ -84,13 +84,11 @@ public class DownloadTest extends AbstractPersistenceServerServiceTest {
.fileIds(List.of(file2.getId()))
.build());
TenantContext.setTenantId("redaction");
downloadMessageReceiver.receive(new DownloadJob(userProvider.getUserId(), downloads.getStorageId()));
var reportInfoId = downloads.getStorageId().substring(0, downloads.getStorageId().length() - 3) + "/REPORT_INFO.json";
storageService.storeJSONObject(TenantContext.getTenantId(), reportInfoId, new ArrayList<>());
downloadPreparationService.createDownload(RedactionResultMessage.builder().downloadId(downloads.getStorageId()).build());
TenantContext.clear();
var statuses = downloadClient.getDownloadStatus();
assertThat(statuses.getDownloadStatus()).isNotEmpty();

5
persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/performance/EntityPerformanceTest.java
View File

@ -1,5 +1,7 @@
package com.iqser.red.service.peristence.v1.server.integration.tests.performance;
import static org.assertj.core.api.Assertions.assertThat;
import java.util.ArrayList;
import java.util.List;
import java.util.stream.Collectors;
@ -20,7 +22,6 @@ import com.iqser.red.service.persistence.service.v1.api.shared.model.dossiertemp
import com.iqser.red.service.persistence.service.v1.api.shared.model.dossiertemplate.type.DictionaryEntryType;
import lombok.extern.slf4j.Slf4j;
import static org.assertj.core.api.Assertions.assertThat;
@Slf4j
public class EntityPerformanceTest extends AbstractPersistenceServerServiceTest {
@ -98,7 +99,6 @@ public class EntityPerformanceTest extends AbstractPersistenceServerServiceTest
@Test
public void testWritePerformance() {
TenantContext.setTenantId("redaction");
var tenKEntries = generateEntries(10_000);
@ -127,7 +127,6 @@ public class EntityPerformanceTest extends AbstractPersistenceServerServiceTest
System.out.println("JPA Time: " + jpaTime + "ms for 10k entries");
System.out.println("JDBC Time: " + jdbcTime + "ms for 10k entries");
TenantContext.clear();
}
}