From e393d701865daebfa4a42ae406bbd75629ac0dec Mon Sep 17 00:00:00 2001 From: maverickstuder Date: Thu, 21 Nov 2024 13:51:21 +0100 Subject: [PATCH 1/2] RED-10511: False warnings when approving file appears after justification refactoring --- .../v1/processor/service/ApprovalVerificationService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/ApprovalVerificationService.java b/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/ApprovalVerificationService.java index ac6c63d8c..d1d2265ec 100644 --- a/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/ApprovalVerificationService.java +++ b/persistence-service-v1/persistence-service-processor-v1/src/main/java/com/iqser/red/service/persistence/management/v1/processor/service/ApprovalVerificationService.java @@ -51,7 +51,7 @@ public class ApprovalVerificationService { addWarning(entry, WarningType.LEGAL_BASIS_MISSING, approveResponse); } else { var legalBasisEntity = legalBasisMappings.stream() - .filter(mapping -> mapping.getReason().equals(entry.getLegalBasis())) + .filter(mapping -> mapping.getTechnicalName().equals(entry.getLegalBasis())) .findFirst(); if (legalBasisEntity.isEmpty() || StringUtils.isEmpty(legalBasisEntity.get().getTechnicalName())) { addWarning(entry, WarningType.UNMAPPED_JUSTIFICATION, approveResponse); From 21b184d97a32b19d687abc512da8c28117125825 Mon Sep 17 00:00:00 2001 From: maverickstuder Date: Thu, 21 Nov 2024 14:30:08 +0100 Subject: [PATCH 2/2] RED-10511: False warnings when approving file appears after justification refactoring --- .../peristence/v1/server/integration/tests/ApprovalTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/ApprovalTest.java b/persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/ApprovalTest.java index 6b5d5edca..044a66552 100644 --- a/persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/ApprovalTest.java +++ b/persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/ApprovalTest.java @@ -71,7 +71,7 @@ public class ApprovalTest extends AbstractPersistenceServerServiceTest { .id("id1") .positions(List.of(new Position(1, 1, 1, 1, 1))) .state(EntryState.APPLIED) - .legalBasis("legalBasis") + .legalBasis("legal_basis") .entryType(EntryType.ENTITY) .value("value") .build()));