Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-7782 - Merge unprocessed redactions into entity log without re-analysis. #200

Merged
andrei.isvoran.ext merged 5 commits from RED-7784-unprocessed-redactions into master 2023-10-27 12:03:11 +02:00
Conversation 38 Commits 5 Files Changed 9 +538 -13
andrei.isvoran.ext commented 2023-10-26 14:38:08 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Closes RED-7784

Closes RED-7784
andrei.isvoran.ext commented 2023-10-26 14:38:08 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @andrei.isvoran.ext

assigned to @andrei.isvoran.ext
ali.oezyetimoglu1 (Migrated from gitlab.knecon.com) approved these changes 2023-10-26 14:38:08 +02:00
corina.olariu.ext1 (Migrated from gitlab.knecon.com) approved these changes 2023-10-26 14:38:08 +02:00
andrei.isvoran.ext commented 2023-10-26 16:07:49 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>729881fc - RED-7782 - Fix tests</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/200/diffs?diff_id=23024&start_sha=75847a43d5e6d1482a19894e3a62dd5957606daf)
andrei.isvoran.ext commented 2023-10-26 16:18:22 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

requested review from @ali.oezyetimoglu1, @timo.bejan.ext, @kilian.schuettler1, @dominique.eiflaender1, @corina.olariu.ext1, and @yannik.hampe

requested review from @ali.oezyetimoglu1, @timo.bejan.ext, @kilian.schuettler1, @dominique.eiflaender1, @corina.olariu.ext1, and @yannik.hampe
kilian.schuettler1 commented 2023-10-26 16:47:24 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

please rename unprocessed to includeUnprocessed in the annotation

please rename unprocessed to includeUnprocessed in the annotation
kilian.schuettler1 commented 2023-10-26 16:47:38 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Also here, rename unprocessed to includeUnprocessed

Also here, rename unprocessed to includeUnprocessed
kilian.schuettler1 commented 2023-10-26 16:47:55 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Here as well

Here as well
kilian.schuettler1 commented 2023-10-26 16:48:08 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

And here

And here
kilian.schuettler1 commented 2023-10-26 16:51:11 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

When removing something via ManualRedaction, the state should be set to IGNORED

See Examples here: https://knecon.atlassian.net/wiki/spaces/RED/pages/102072322/EntityLog+-+Enum+combinations

When removing something via ManualRedaction, the state should be set to IGNORED See Examples here: https://knecon.atlassian.net/wiki/spaces/RED/pages/102072322/EntityLog+-+Enum+combinations
kilian.schuettler1 commented 2023-10-26 16:51:51 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Should be null anyway, or?

Should be null anyway, or?
kilian.schuettler1 commented 2023-10-26 16:52:10 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Should be null anyways

Should be null anyways
kilian.schuettler1 commented 2023-10-26 16:58:31 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Also set value and section, due to an unfortunate name it is not clear that this ManualChange is used to alter all three fields

Also set value and section, due to an unfortunate name it is not clear that this ManualChange is used to alter all three fields
kilian.schuettler1 commented 2023-10-26 16:59:02 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Also put all changed values here

Also put all changed values here
kilian.schuettler1 commented 2023-10-26 16:59:17 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

legalBasis, value and section

legalBasis, value and section
kilian.schuettler1 commented 2023-10-26 16:59:51 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Should be null anyways

Should be null anyways
kilian.schuettler1 commented 2023-10-26 17:01:08 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

I would use the analysisNumber from the entity log incremented by one

I would use the analysisNumber from the entity log incremented by one
kilian.schuettler1 commented 2023-10-26 17:01:23 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Same here

Same here
kilian.schuettler1 commented 2023-10-26 17:06:26 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Currently all manual redaction entries are created with type "manual". This does not mean everything else is a hint. In order to safely detect what is a Hint and what isn't you need to look in the Dicionary. TypeEntity has a field called isHint

Currently all manual redaction entries are created with type "manual". This does not mean everything else is a hint. In order to safely detect what is a Hint and what isn't you need to look in the Dicionary. TypeEntity has a field called isHint
andrei.isvoran.ext commented 2023-10-27 11:09:27 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/redactmanager/persistence-service/-/merge_requests/200/diffs?diff_id=23131&start_sha=729881fcd45ff7e7130a088f14041e0463536bcb#91327f72d62cddf8f845c2f9a80ab7b2830f2c30_41_41)
andrei.isvoran.ext commented 2023-10-27 11:09:27 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/redactmanager/persistence-service/-/merge_requests/200/diffs?diff_id=23131&start_sha=729881fcd45ff7e7130a088f14041e0463536bcb#b6c5aaf0effef84c12711c3094c814d3720918e2_31_31)
andrei.isvoran.ext commented 2023-10-27 11:09:27 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/redactmanager/persistence-service/-/merge_requests/200/diffs?diff_id=23131&start_sha=729881fcd45ff7e7130a088f14041e0463536bcb#fd98812217ad298e83c0886bbe1c368d3fafe2d7_25_25)
andrei.isvoran.ext commented 2023-10-27 11:09:27 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/redactmanager/persistence-service/-/merge_requests/200/diffs?diff_id=23131&start_sha=729881fcd45ff7e7130a088f14041e0463536bcb#74340a6e3e967b0e95999ffbf3d540784df56138_38_38)
andrei.isvoran.ext commented 2023-10-27 11:09:27 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/redactmanager/persistence-service/-/merge_requests/200/diffs?diff_id=23131&start_sha=729881fcd45ff7e7130a088f14041e0463536bcb#809db0eea5204d683182cc37711a773ca88795f2_202_207)
andrei.isvoran.ext commented 2023-10-27 11:09:28 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/redactmanager/persistence-service/-/merge_requests/200/diffs?diff_id=23131&start_sha=729881fcd45ff7e7130a088f14041e0463536bcb#809db0eea5204d683182cc37711a773ca88795f2_229_234)
andrei.isvoran.ext commented 2023-10-27 11:09:28 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/redactmanager/persistence-service/-/merge_requests/200/diffs?diff_id=23131&start_sha=729881fcd45ff7e7130a088f14041e0463536bcb#809db0eea5204d683182cc37711a773ca88795f2_207_212)
andrei.isvoran.ext commented 2023-10-27 11:09:28 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/redactmanager/persistence-service/-/merge_requests/200/diffs?diff_id=23131&start_sha=729881fcd45ff7e7130a088f14041e0463536bcb#809db0eea5204d683182cc37711a773ca88795f2_246_252)
andrei.isvoran.ext commented 2023-10-27 11:09:28 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/redactmanager/persistence-service/-/merge_requests/200/diffs?diff_id=23131&start_sha=729881fcd45ff7e7130a088f14041e0463536bcb#809db0eea5204d683182cc37711a773ca88795f2_245_252)
andrei.isvoran.ext commented 2023-10-27 11:09:28 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/redactmanager/persistence-service/-/merge_requests/200/diffs?diff_id=23131&start_sha=729881fcd45ff7e7130a088f14041e0463536bcb#809db0eea5204d683182cc37711a773ca88795f2_293_301)
andrei.isvoran.ext commented 2023-10-27 11:09:28 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/redactmanager/persistence-service/-/merge_requests/200/diffs?diff_id=23131&start_sha=729881fcd45ff7e7130a088f14041e0463536bcb#809db0eea5204d683182cc37711a773ca88795f2_298_306)
andrei.isvoran.ext commented 2023-10-27 11:09:28 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/redactmanager/persistence-service/-/merge_requests/200/diffs?diff_id=23131&start_sha=729881fcd45ff7e7130a088f14041e0463536bcb#809db0eea5204d683182cc37711a773ca88795f2_304_312)
andrei.isvoran.ext commented 2023-10-27 11:09:29 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • da43634b - RED-7782 - Address PR comments

Compare with previous version

added 1 commit <ul><li>da43634b - RED-7782 - Address PR comments</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/200/diffs?diff_id=23131&start_sha=729881fcd45ff7e7130a088f14041e0463536bcb)
andrei.isvoran.ext commented 2023-10-27 11:14:27 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 7a0de45a - RED-7782 - Address PR comments

Compare with previous version

added 1 commit <ul><li>7a0de45a - RED-7782 - Address PR comments</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/200/diffs?diff_id=23133&start_sha=da43634b1923ae702d4c484ede15d0ae88c4778c)
andrei.isvoran.ext commented 2023-10-27 11:16:08 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 3bdfd4c9 - RED-7782 - Add property changes

Compare with previous version

added 1 commit <ul><li>3bdfd4c9 - RED-7782 - Add property changes</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/200/diffs?diff_id=23135&start_sha=7a0de45add27aa94a08862334114bebdb644c37e)
andrei.isvoran.ext commented 2023-10-27 11:16:51 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

resolved all threads

resolved all threads
ali.oezyetimoglu1 commented 2023-10-27 11:47:41 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
corina.olariu.ext1 commented 2023-10-27 11:56:34 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
andrei.isvoran.ext (Migrated from gitlab.knecon.com) merged commit 407e1be1a4 into master 2023-10-27 12:03:11 +02:00
andrei.isvoran.ext commented 2023-10-27 12:03:12 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit 407e1be1a4

mentioned in commit 407e1be1a4ecb0cdb87e69fa63226684822c999c
Sign in to join this conversation.
Reviewers
No Reviewers
corina.olariu.ext1
ali.oezyetimoglu1
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#200
No description provided.
Delete Branch "RED-7784-unprocessed-redactions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?