RED-7404 - Add publishing for all modules #254

Merged
andrei.isvoran.ext merged 7 commits from RED-7404 into master 2023-12-08 11:27:47 +01:00
andrei.isvoran.ext commented 2023-12-06 15:34:04 +01:00 (Migrated from gitlab.knecon.com)

Closes RED-7404

Closes RED-7404
corina.olariu.ext1 (Migrated from gitlab.knecon.com) approved these changes 2023-12-06 15:34:04 +01:00
andrei.isvoran.ext commented 2023-12-06 15:34:05 +01:00 (Migrated from gitlab.knecon.com)

assigned to @andrei.isvoran.ext

assigned to @andrei.isvoran.ext
andrei.isvoran.ext commented 2023-12-06 15:39:50 +01:00 (Migrated from gitlab.knecon.com)

requested review from @ali.oezyetimoglu1, @timo.bejan.ext, @kilian.schuettler1, @dominique.eiflaender1, @corina.olariu.ext1, and @yannik.hampe

requested review from @ali.oezyetimoglu1, @timo.bejan.ext, @kilian.schuettler1, @dominique.eiflaender1, @corina.olariu.ext1, and @yannik.hampe
andrei.isvoran.ext commented 2023-12-06 15:41:54 +01:00 (Migrated from gitlab.knecon.com)

requested review from @christoph.schabert

requested review from @christoph.schabert
andrei.isvoran.ext commented 2023-12-06 16:58:47 +01:00 (Migrated from gitlab.knecon.com)

added 1 commit

Compare with previous version

added 1 commit <ul><li>d10b2f7d - RED-7404 - Exclude bootjar</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/254/diffs?diff_id=26152&start_sha=83eb670ffb9a35fdf59e0895db28e2c6d960f25f)
kilian.schuettler1 commented 2023-12-07 16:54:32 +01:00 (Migrated from gitlab.knecon.com)

Can you please explain to me why we need this?

Can you please explain to me why we need this?
andrei.isvoran.ext commented 2023-12-08 08:42:03 +01:00 (Migrated from gitlab.knecon.com)

added 1 commit

  • 94aa013c - RED-7404 - change bootbuildimage to publishing

Compare with previous version

added 1 commit <ul><li>94aa013c - RED-7404 - change bootbuildimage to publishing</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/254/diffs?diff_id=26487&start_sha=d10b2f7df2d49821472ec30866caf6e7a975e64d)
andrei.isvoran.ext commented 2023-12-08 08:49:32 +01:00 (Migrated from gitlab.knecon.com)

added 1 commit

  • f00076ef - RED-7404 - remove not needed plugin

Compare with previous version

added 1 commit <ul><li>f00076ef - RED-7404 - remove not needed plugin</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/254/diffs?diff_id=26491&start_sha=94aa013c7b025eff40af553f29b63410199c0f89)
andrei.isvoran.ext commented 2023-12-08 09:02:02 +01:00 (Migrated from gitlab.knecon.com)

changed title from RED-7404 - Add {-BootBuildImage task for other gradle-} modules to RED-7404 - Add {+publishing for all+} modules

changed title from **RED-7404 - Add {-BootBuildImage task for other gradle-} modules** to **RED-7404 - Add {+publishing for all+} modules**
andrei.isvoran.ext commented 2023-12-08 09:03:26 +01:00 (Migrated from gitlab.knecon.com)

This was wrong 😞

We needed the publishing part not the bootBuildImage part because right now the other modules which are not persistence-service-server-v1 are not being published but we need them as dependencies in other projects.

Updated the PR.

This was wrong :disappointed: We needed the publishing part not the bootBuildImage part because right now the other modules which are not persistence-service-server-v1 are not being published but we need them as dependencies in other projects. Updated the PR.
andrei.isvoran.ext commented 2023-12-08 09:04:28 +01:00 (Migrated from gitlab.knecon.com)

added 3 commits

  • f00076ef...f8157e44 - 2 commits from branch master
  • 3cf0f76b - Merge remote-tracking branch 'origin/master' into RED-7404

Compare with previous version

added 3 commits <ul><li>f00076ef...f8157e44 - 2 commits from branch <code>master</code></li><li>3cf0f76b - Merge remote-tracking branch &#39;origin/master&#39; into RED-7404</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/254/diffs?diff_id=26494&start_sha=f00076eff4f5e754f3f841ade7698a4d46ce46ca)
andrei.isvoran.ext commented 2023-12-08 09:05:43 +01:00 (Migrated from gitlab.knecon.com)

added 1 commit

  • 96f7b4cd - RED-7404 - change external-api-v1

Compare with previous version

added 1 commit <ul><li>96f7b4cd - RED-7404 - change external-api-v1</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/254/diffs?diff_id=26496&start_sha=3cf0f76ba5253e37de4f68d339e585d44bc8a255)
kilian.schuettler1 commented 2023-12-08 09:58:42 +01:00 (Migrated from gitlab.knecon.com)

instead of putting it in every submodule, you can also do it inn the buildSrc and import it in all others. Like this in the buildSrc. That's the way it is donne in layoutparser

allprojects **{
** publishing **{
** publications **{
** create<MavenPublication>(name) **{
** from(components["java"])
**}
}
** repositories **{
** maven **{
** url = uri("https://nexus.knecon.com/repository/red-platform-releases/")
credentials **{
** username = providers.gradleProperty("mavenUser").getOrNull();
password = providers.gradleProperty("mavenPassword").getOrNull();
}
}
}
}
}

instead of putting it in every submodule, you can also do it inn the buildSrc and import it in all others. Like this in the buildSrc. That's the way it is donne in layoutparser > allprojects **{\ > ** publishing **{\ > ** publications **{\ > ** create\<MavenPublication\>(name) **{\ > ** from(components\["java"\])\ > **}\ > }\ > ** repositories **{\ > ** maven **{\ > ** url = uri("https://nexus.knecon.com/repository/red-platform-releases/")\ > credentials **{\ > ** username = providers.gradleProperty("mavenUser").getOrNull();\ > password = providers.gradleProperty("mavenPassword").getOrNull();\ > **}\ > }\ > }\ > }\ > }**
andrei.isvoran.ext commented 2023-12-08 10:17:53 +01:00 (Migrated from gitlab.knecon.com)

added 1 commit

  • 51403615 - RED-7404 - Move publishing to buildSrc file

Compare with previous version

added 1 commit <ul><li>51403615 - RED-7404 - Move publishing to buildSrc file</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/254/diffs?diff_id=26501&start_sha=96f7b4cd2706865ee9a0dab26288bc991714f14e)
andrei.isvoran.ext commented 2023-12-08 10:18:27 +01:00 (Migrated from gitlab.knecon.com)

Yep you're right, fixed it 😄

Yep you're right, fixed it :smile:
andrei.isvoran.ext commented 2023-12-08 10:18:30 +01:00 (Migrated from gitlab.knecon.com)

resolved all threads

resolved all threads
corina.olariu.ext1 commented 2023-12-08 11:03:49 +01:00 (Migrated from gitlab.knecon.com)

approved this merge request

approved this merge request
andrei.isvoran.ext (Migrated from gitlab.knecon.com) merged commit 430f118206 into master 2023-12-08 11:27:47 +01:00
andrei.isvoran.ext commented 2023-12-08 11:27:48 +01:00 (Migrated from gitlab.knecon.com)

mentioned in commit 430f118206

mentioned in commit 430f118206af3ab054bb6888fdf442087d514175
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#254
No description provided.