Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-8361 - Returned error status codes should be checked #344

Merged
corina.olariu.ext1 merged 4 commits from RED-8361-update into master 2024-02-09 18:27:02 +01:00
Conversation 15 Commits 4 Files Changed 23 +87 -74
corina.olariu.ext1 commented 2024-02-09 09:10:23 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
  • add some view/access permissions for some endpoints
  • modify messages so in case dossier is not found to not include the id

Signed-off-by: Corina Olariu corina.olariu.ext@knecon.com

Closes RED-8361

- add some view/access permissions for some endpoints - modify messages so in case dossier is not found to not include the id Signed-off-by: Corina Olariu <corina.olariu.ext@knecon.com> Closes RED-8361
corina.olariu.ext1 commented 2024-02-09 09:10:23 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

requested review from @ali.oezyetimoglu1, @andrei.isvoran.ext, @dominique.eiflaender1, @kilian.schuettler1, @maverick.studer, @yannik.hampe, and @timo.bejan.ext

requested review from @ali.oezyetimoglu1, @andrei.isvoran.ext, @dominique.eiflaender1, @kilian.schuettler1, @maverick.studer, @yannik.hampe, and @timo.bejan.ext
corina.olariu.ext1 commented 2024-02-09 09:10:23 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @corina.olariu.ext1

assigned to @corina.olariu.ext1
andrei.isvoran.ext (Migrated from gitlab.knecon.com) approved these changes 2024-02-09 09:10:23 +01:00
corina.olariu.ext1 commented 2024-02-09 11:13:58 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 3e67dd80 - RED-8361 - Returned error status codes should be checked

Compare with previous version

added 1 commit <ul><li>3e67dd80 - RED-8361 - Returned error status codes should be checked</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/344/diffs?diff_id=31994&start_sha=a7c4bf866c0f247f938caf76c1f4660e35e2939d)
andrei.isvoran.ext commented 2024-02-09 15:55:53 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
ali.oezyetimoglu1 commented 2024-02-09 16:36:22 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

A 404 can also be thrown, if the file is not found, so maybe it would be better to change the description of 404 to Dossier or File not found

A 404 can also be thrown, if the file is not found, so maybe it would be better to change the description of 404 to Dossier or File not found
ali.oezyetimoglu1 commented 2024-02-09 16:36:22 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

Same as above

Same as above
corina.olariu.ext1 commented 2024-02-09 16:49:36 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/redactmanager/persistence-service/-/merge_requests/344/diffs?diff_id=32037&start_sha=3e67dd8055719959f3b90adb14dbc7ffed471200#a7da8505271d8882829fb9716e728329a4390097_93_93)
corina.olariu.ext1 commented 2024-02-09 16:49:36 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/redactmanager/persistence-service/-/merge_requests/344/diffs?diff_id=32037&start_sha=3e67dd8055719959f3b90adb14dbc7ffed471200#a7da8505271d8882829fb9716e728329a4390097_103_103)
corina.olariu.ext1 commented 2024-02-09 16:49:36 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • a4f3edd1 - RED-8361 - Returned error status codes should be checked

Compare with previous version

added 1 commit <ul><li>a4f3edd1 - RED-8361 - Returned error status codes should be checked</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/344/diffs?diff_id=32037&start_sha=3e67dd8055719959f3b90adb14dbc7ffed471200)
corina.olariu.ext1 commented 2024-02-09 17:23:20 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 8db9bd1b - RED-8361 - Returned error status codes should be checked

Compare with previous version

added 1 commit <ul><li>8db9bd1b - RED-8361 - Returned error status codes should be checked</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/344/diffs?diff_id=32039&start_sha=a4f3edd1447b0143bcd235104589e9786ebde712)
corina.olariu.ext1 commented 2024-02-09 17:23:35 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

changed

changed
corina.olariu.ext1 commented 2024-02-09 17:23:43 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

changed

changed
corina.olariu.ext1 commented 2024-02-09 17:23:45 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

resolved all threads

resolved all threads
corina.olariu.ext1 commented 2024-02-09 18:27:02 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit 99944c9fef

mentioned in commit 99944c9fef4c174006782f5ee12093a14d4b6061
corina.olariu.ext1 (Migrated from gitlab.knecon.com) merged commit 99944c9fef into master 2024-02-09 18:27:02 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
andrei.isvoran.ext
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#344
No description provided.
Delete Branch "RED-8361-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?