Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

Resolve RED-8480 "2" #354

Merged
ali.oezyetimoglu1 merged 4 commits from RED-8480-2 into master 2024-02-16 12:57:58 +01:00
Conversation 23 Commits 4 Files Changed 15 +1012 -686
ali.oezyetimoglu1 commented 2024-02-15 22:06:20 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

Closes RED-8480

Closes RED-8480
ali.oezyetimoglu1 commented 2024-02-15 22:06:20 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @ali.oezyetimoglu1

assigned to @ali.oezyetimoglu1
kilian.schuettler1 (Migrated from gitlab.knecon.com) approved these changes 2024-02-15 22:06:20 +01:00
ali.oezyetimoglu1 commented 2024-02-15 22:18:42 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 75d8d932 - RED-8480: added some checks and tests

Compare with previous version

added 1 commit <ul><li>75d8d932 - RED-8480: added some checks and tests</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/354/diffs?diff_id=32635&start_sha=64b9310252afc4229f7c2fc8afa4f3d4bc26a889)
ali.oezyetimoglu1 commented 2024-02-15 22:20:00 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • e6816514 - RED-8480: added some checks and tests

Compare with previous version

added 1 commit <ul><li>e6816514 - RED-8480: added some checks and tests</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/354/diffs?diff_id=32637&start_sha=75d8d932f66dcacf777620a43fb862f2ab799bec)
kilian.schuettler1 commented 2024-02-16 10:20:48 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

You could also put a @NonNull annotation on the legalBasis field in the RecategorizationRequestModel and achieve the same thing :)

You could also put a @NonNull annotation on the legalBasis field in the RecategorizationRequestModel and achieve the same thing :)
ali.oezyetimoglu1 commented 2024-02-16 10:22:00 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

resolved all threads

resolved all threads
kilian.schuettler1 commented 2024-02-16 10:22:19 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

I think we should remove build from the builder method list again, i really don't like the way this is affecting the formatting.

I think we should remove build from the builder method list again, i really don't like the way this is affecting the formatting.
kilian.schuettler1 commented 2024-02-16 10:22:33 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

unrelated to this pr tho

unrelated to this pr tho
ali.oezyetimoglu1 commented 2024-02-16 10:23:53 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/redactmanager/persistence-service/-/merge_requests/354/diffs?diff_id=32709&start_sha=e6816514209055196953e31d98463a073690aa24#82b76052eb35ae7bc3d31f394a52ae22b32da93d_146_146)
ali.oezyetimoglu1 commented 2024-02-16 10:23:54 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 179d66a7 - RED-8480: small validation change

Compare with previous version

added 1 commit <ul><li>179d66a7 - RED-8480: small validation change</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/354/diffs?diff_id=32709&start_sha=e6816514209055196953e31d98463a073690aa24)
kilian.schuettler1 commented 2024-02-16 10:27:36 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

Unnecessary to make it into 2 changes. do it in a single one instead:


- addColumn:
    tableName: manual_recategorization
    columns:
      - column:
         name: legal_basis
         type: VARCHAR(4000)
         defaultValue: ''
         constraints:
            nullable: false
Unnecessary to make it into 2 changes. do it in a single one instead: ```suggestion:-0+0 - addColumn: tableName: manual_recategorization columns: - column: name: legal_basis type: VARCHAR(4000) defaultValue: '' constraints: nullable: false ```
kilian.schuettler1 commented 2024-02-16 10:33:31 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

Kinda unnecessary, use this instead

RandomStringUtils.randomAlphanumeric(4000);

Kinda unnecessary, use this instead RandomStringUtils.randomAlphanumeric(4000);
kilian.schuettler1 commented 2024-02-16 10:34:24 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

I guess your solution is more performant though 😁

I guess your solution is more performant though :grin:
ali.oezyetimoglu1 commented 2024-02-16 11:46:05 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

changed it to RandomStringUtils.randomAlphanumeric(4001) :D

changed it to RandomStringUtils.randomAlphanumeric(4001) :D
ali.oezyetimoglu1 commented 2024-02-16 11:47:18 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

Okay, I can remove it from the list.

Okay, I can remove it from the list.
ali.oezyetimoglu1 commented 2024-02-16 11:47:21 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

resolved all threads

resolved all threads
ali.oezyetimoglu1 commented 2024-02-16 11:48:19 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/redactmanager/persistence-service/-/merge_requests/354/diffs?diff_id=32715&start_sha=179d66a7969c5803699850969f3671043e8dd158#66552b79696f5438f3e47b497c385892ce8da1a6_12_12)
ali.oezyetimoglu1 commented 2024-02-16 11:48:19 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/redactmanager/persistence-service/-/merge_requests/354/diffs?diff_id=32715&start_sha=179d66a7969c5803699850969f3671043e8dd158#952907203566eee9483db988a0b1be1dbc97e910_1873_1874)
ali.oezyetimoglu1 commented 2024-02-16 11:48:19 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • dd101cd2 - RED-8480: small fixes

Compare with previous version

added 1 commit <ul><li>dd101cd2 - RED-8480: small fixes</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/354/diffs?diff_id=32715&start_sha=179d66a7969c5803699850969f3671043e8dd158)
ali.oezyetimoglu1 commented 2024-02-16 11:49:17 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>e8c3d3dc - RED-8480: small fixes</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/354/diffs?diff_id=32717&start_sha=dd101cd28925b63ae20e13a159d6a0390b39c9bc)
ali.oezyetimoglu1 commented 2024-02-16 11:50:24 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

resolved all threads

resolved all threads
kilian.schuettler1 commented 2024-02-16 12:33:10 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
ali.oezyetimoglu1 commented 2024-02-16 12:57:58 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit caba58ec19

mentioned in commit caba58ec194e2ae3598af3a6c93d962602012116
ali.oezyetimoglu1 (Migrated from gitlab.knecon.com) merged commit caba58ec19 into master 2024-02-16 12:57:58 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
kilian.schuettler1
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#354
No description provided.
Delete Branch "RED-8480-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?