Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-7886 - Endpoint for rule validation #360

Merged
corina.olariu.ext1 merged 3 commits from RED-7886-dryrun into master 2024-02-23 10:21:54 +01:00
Conversation 15 Commits 3 Files Changed 5 +162 -27
corina.olariu.ext1 commented 2024-02-21 14:42:47 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
  • add dry-run parameter, based on this save the rules or not and include warnings in the responses.
  • added junit tests

Signed-off-by: Corina Olariu corina.olariu.ext@knecon.com

Closes RED-7886

- add dry-run parameter, based on this save the rules or not and include warnings in the responses. - added junit tests Signed-off-by: Corina Olariu <corina.olariu.ext@knecon.com> Closes RED-7886
corina.olariu.ext1 commented 2024-02-21 14:42:47 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @corina.olariu.ext1

assigned to @corina.olariu.ext1
ali.oezyetimoglu1 (Migrated from gitlab.knecon.com) approved these changes 2024-02-21 14:42:47 +01:00
corina.olariu.ext1 commented 2024-02-21 16:16:04 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

requested review from @ali.oezyetimoglu1, @andrei.isvoran.ext, @dominique.eiflaender1, @kilian.schuettler1, @maverick.studer, @yannik.hampe, and @timo.bejan.ext

requested review from @ali.oezyetimoglu1, @andrei.isvoran.ext, @dominique.eiflaender1, @kilian.schuettler1, @maverick.studer, @yannik.hampe, and @timo.bejan.ext
kilian.schuettler1 commented 2024-02-22 10:13:43 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

Although the ticket states to add the dry run parameter, i would just call it "dryRun"

Although the ticket states to add the dry run parameter, i would just call it "dryRun"
corina.olariu.ext1 commented 2024-02-22 10:19:35 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/redactmanager/persistence-service/-/merge_requests/360/diffs?diff_id=33340&start_sha=4091f2107655647182c5e2325d81d9fe1ef510db#82ae1cbe62f27e31cec18a198e35d2bb743e5955_133_133)
corina.olariu.ext1 commented 2024-02-22 10:19:35 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 80c7c867 - RED-7886 - Endpoint for rule validation

Compare with previous version

added 1 commit <ul><li>80c7c867 - RED-7886 - Endpoint for rule validation</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/360/diffs?diff_id=33340&start_sha=4091f2107655647182c5e2325d81d9fe1ef510db)
corina.olariu.ext1 commented 2024-02-22 10:24:40 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

done

done
corina.olariu.ext1 commented 2024-02-22 10:24:41 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

resolved all threads

resolved all threads
kilian.schuettler1 commented 2024-02-22 10:25:06 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

Call this the DRY_RUN_PARAMETER and the actual value dryRun

Call this the DRY_RUN_PARAMETER and the actual value dryRun
kilian.schuettler1 commented 2024-02-22 10:26:25 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

you've called this runDry everywhere, please call it dryRun

you've called this runDry everywhere, please call it dryRun
corina.olariu.ext1 commented 2024-02-22 10:31:04 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/redactmanager/persistence-service/-/merge_requests/360/diffs?diff_id=33342&start_sha=80c7c867ae7f99e1499077b2970eb1d347ce758c#e83a8d59a1b40d76a3a2d64d35cebf21d6e696ee_29_29)
corina.olariu.ext1 commented 2024-02-22 10:31:05 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • e8a942d7 - RED-7886 - Endpoint for rule validation

Compare with previous version

added 1 commit <ul><li>e8a942d7 - RED-7886 - Endpoint for rule validation</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/360/diffs?diff_id=33342&start_sha=80c7c867ae7f99e1499077b2970eb1d347ce758c)
corina.olariu.ext1 commented 2024-02-22 10:52:27 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

resolved all threads

resolved all threads
ali.oezyetimoglu1 commented 2024-02-23 09:41:53 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
corina.olariu.ext1 (Migrated from gitlab.knecon.com) merged commit 6375cedaee into master 2024-02-23 10:21:54 +01:00
corina.olariu.ext1 commented 2024-02-23 10:21:55 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit 6375cedaee

mentioned in commit 6375cedaeed7b5fe192f54250bfa0a53a1627787
Sign in to join this conversation.
Reviewers
No Reviewers
ali.oezyetimoglu1
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#360
No description provided.
Delete Branch "RED-7886-dryrun"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?