Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-7034 - Check for dossierDictionaryOnly flag when add to template dict is requested #45

Merged
corina.olariu.ext1 merged 3 commits from RED-7034 into master 2023-07-10 08:50:53 +02:00
Conversation 9 Commits 3 Files Changed 6 +181 -66
corina.olariu.ext1 commented 2023-07-07 12:50:16 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
  • before adding / deleting entries to a dossier template dictionary check if the flag dossierDictionaryOnly is set true
  • the same check is needed in case of manual redactions ; adding, removing
  • add junit tests

Closes RED-7034

- before adding / deleting entries to a dossier template dictionary check if the flag dossierDictionaryOnly is set true - the same check is needed in case of manual redactions ; adding, removing - add junit tests Closes RED-7034
corina.olariu.ext1 commented 2023-07-07 12:50:16 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

requested review from @dominique.eiflaender1, @ali.oezyetimoglu1, @kilian.schuettler1, and @timo.bejan.ext

requested review from @dominique.eiflaender1, @ali.oezyetimoglu1, @kilian.schuettler1, and @timo.bejan.ext
corina.olariu.ext1 commented 2023-07-07 12:50:16 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @corina.olariu.ext1

assigned to @corina.olariu.ext1
ali.oezyetimoglu1 (Migrated from gitlab.knecon.com) approved these changes 2023-07-07 12:50:16 +02:00
ali.oezyetimoglu1 commented 2023-07-07 17:12:43 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Maybe you can integrate this method to the lines 317, 718 and 771

Maybe you can integrate this method to the lines 317, 718 and 771
ali.oezyetimoglu1 commented 2023-07-07 17:12:43 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

This is not part of your fix, but can you please change this variable to "dictionaryManagementService" instead of "dictionaryService"? I had a look in the DictionaryService and was confused, that there is no method "validateAddRemoveToDossierTemplateDictionary(...)"

This is not part of your fix, but can you please change this variable to "dictionaryManagementService" instead of "dictionaryService"? I had a look in the DictionaryService and was confused, that there is no method "validateAddRemoveToDossierTemplateDictionary(...)"
corina.olariu.ext1 commented 2023-07-07 17:58:35 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/redactmanager/persistence-service/-/merge_requests/45/diffs?diff_id=11895&start_sha=8860e9d040711e37fe534cef95245479e8b1b268#985b1c558683b282b7ef3817df59f4bd42ef6c17_91_91)
corina.olariu.ext1 commented 2023-07-07 17:58:35 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 9b2ea9df - RED-7034 - Check for dossierDictionaryOnly flag when add to template dict is requested

Compare with previous version

added 1 commit <ul><li>9b2ea9df - RED-7034 - Check for dossierDictionaryOnly flag when add to template dict is requested</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/45/diffs?diff_id=11895&start_sha=8860e9d040711e37fe534cef95245479e8b1b268)
ali.oezyetimoglu1 commented 2023-07-10 08:48:38 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
corina.olariu.ext1 commented 2023-07-10 08:50:53 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit db16cc0ab3

mentioned in commit db16cc0ab32265bffe8a455a926f1b66b54c6a58
corina.olariu.ext1 (Migrated from gitlab.knecon.com) merged commit db16cc0ab3 into master 2023-07-10 08:50:53 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
ali.oezyetimoglu1
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#45
No description provided.
Delete Branch "RED-7034"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?