Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

Resolve RED-8339 "4" #511

Merged
ali.oezyetimoglu1 merged 8 commits from RED-8339-4 into master 2024-06-03 15:38:31 +02:00
Conversation 29 Commits 8 Files Changed 36 +2026 -850
ali.oezyetimoglu1 commented 2024-06-02 11:22:57 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Closes RED-8339

Closes RED-8339
kilian.schuettler1 (Migrated from gitlab.knecon.com) approved these changes 2024-06-02 11:22:57 +02:00
ali.oezyetimoglu1 commented 2024-06-02 11:23:02 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @ali.oezyetimoglu1

assigned to @ali.oezyetimoglu1
ali.oezyetimoglu1 commented 2024-06-03 09:35:22 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 3 commits

  • 782f48fa - RED-8339: Fixes
  • 69f97603 - RED-8339: Fixes
  • b4966033 - RED-8339: Fixes

Compare with previous version

added 3 commits <ul><li>782f48fa - RED-8339: Fixes</li><li>69f97603 - RED-8339: Fixes</li><li>b4966033 - RED-8339: Fixes</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/511/diffs?diff_id=43979&start_sha=23cf4cf5e9962fcc51496bec47d0d58bd0c45fab)
ali.oezyetimoglu1 commented 2024-06-03 09:35:51 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 80f45898 - RED-8339: Fixes

Compare with previous version

added 1 commit <ul><li>80f45898 - RED-8339: Fixes</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/511/diffs?diff_id=43981&start_sha=b49660333df1b0c18cd2f0a03d76e6fff72baea8)
ali.oezyetimoglu1 commented 2024-06-03 09:54:59 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 5cda10cd - RED-8339: Fixes

Compare with previous version

added 1 commit <ul><li>5cda10cd - RED-8339: Fixes</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/511/diffs?diff_id=43983&start_sha=80f458986ca50ea615a05c61d83e1ac8797d72f6)
ali.oezyetimoglu1 commented 2024-06-03 10:24:15 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>adb6332b - RED-8339: Fixes</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/511/diffs?diff_id=43989&start_sha=5cda10cda323eb2a0fa2d92d8827db5dc2c360fe)
kilian.schuettler1 commented 2024-06-03 10:32:00 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Are these necessary?

Are these necessary?
kilian.schuettler1 commented 2024-06-03 10:35:02 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

I think most descriptions are more like "Use this endpoint to..." We should try to be as consistent as possible here. But there isn't yet a clear formatting guide. So can't say which is more correct.

I think most descriptions are more like "Use this endpoint to..." We should try to be as consistent as possible here. But there isn't yet a clear formatting guide. So can't say which is more correct.
kilian.schuettler1 commented 2024-06-03 10:35:13 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Maybe that's something we should strive for

Maybe that's something we should strive for
kilian.schuettler1 commented 2024-06-03 10:36:28 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

The first sentence states there is one component, where the second states there are all of a file.

The first sentence states there is one component, where the second states there are all of a file.
kilian.schuettler1 commented 2024-06-03 10:36:47 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Is it possible to revert only the overrides of a single component? Then the descriptions should state that. This sounds like you can only revert all overrides at once

Is it possible to revert only the overrides of a single component? Then the descriptions should state that. This sounds like you can only revert all overrides at once
kilian.schuettler1 commented 2024-06-03 10:37:34 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Call this the ComponentOverrideList, it does not have to have the same name as the java object

Call this the ComponentOverrideList, it does not have to have the same name as the java object
kilian.schuettler1 commented 2024-06-03 10:38:10 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

also here, don't mention "Model" in client facing api spec. This field will have to be updated in the java model tho

also here, don't mention "Model" in client facing api spec. This field will have to be updated in the java model tho
kilian.schuettler1 commented 2024-06-03 10:41:15 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

rename this field to componentOverrideList to fit with openapi spec

rename this field to componentOverrideList to fit with openapi spec
ali.oezyetimoglu1 commented 2024-06-03 12:02:00 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

I'll remove them

I'll remove them
ali.oezyetimoglu1 commented 2024-06-03 12:44:32 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

this object is for the old endpoint, but renamed it to make it more consistent

this object is for the old endpoint, but renamed it to make it more consistent
ali.oezyetimoglu1 commented 2024-06-03 12:46:29 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Changed class to ComponentOverrideList and field to componentOverrides

Changed class to ComponentOverrideList and field to componentOverrides
ali.oezyetimoglu1 commented 2024-06-03 13:04:32 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/redactmanager/persistence-service/-/merge_requests/511/diffs?diff_id=44026&start_sha=adb6332bf5cc1676c9649941c176e100f40c6c66#008b27c1e5eb8b833ee7c0ea45d934a4cd171abc_37_37)
ali.oezyetimoglu1 commented 2024-06-03 13:04:32 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/redactmanager/persistence-service/-/merge_requests/511/diffs?diff_id=44026&start_sha=adb6332bf5cc1676c9649941c176e100f40c6c66#58b2036b793e7c98a1394963287dfef4c92211f8_963_963)
ali.oezyetimoglu1 commented 2024-06-03 13:04:32 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/redactmanager/persistence-service/-/merge_requests/511/diffs?diff_id=44026&start_sha=adb6332bf5cc1676c9649941c176e100f40c6c66#58b2036b793e7c98a1394963287dfef4c92211f8_1024_1026)
ali.oezyetimoglu1 commented 2024-06-03 13:04:32 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/redactmanager/persistence-service/-/merge_requests/511/diffs?diff_id=44026&start_sha=adb6332bf5cc1676c9649941c176e100f40c6c66#58b2036b793e7c98a1394963287dfef4c92211f8_1556_1560)
ali.oezyetimoglu1 commented 2024-06-03 13:04:33 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/redactmanager/persistence-service/-/merge_requests/511/diffs?diff_id=44026&start_sha=adb6332bf5cc1676c9649941c176e100f40c6c66#58b2036b793e7c98a1394963287dfef4c92211f8_1571_1575)
ali.oezyetimoglu1 commented 2024-06-03 13:04:33 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 265e5150 - RED-8339: some refactoring

Compare with previous version

added 1 commit <ul><li>265e5150 - RED-8339: some refactoring</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/511/diffs?diff_id=44026&start_sha=adb6332bf5cc1676c9649941c176e100f40c6c66)
ali.oezyetimoglu1 commented 2024-06-03 13:09:53 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>efd777ac - RED-8339: some refactoring</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/511/diffs?diff_id=44028&start_sha=265e5150e1aa6f15a54446fbbc949cad6eed094e)
ali.oezyetimoglu1 commented 2024-06-03 13:13:35 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/redactmanager/persistence-service/-/merge_requests/511/diffs?diff_id=44031&start_sha=efd777acd87b10cd9b355686c87c6c5edf89cdff#ef2793960b77a82c2aa7e9d198f3eb308d3f5568_19_0)
ali.oezyetimoglu1 commented 2024-06-03 13:13:36 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>a5866b36 - RED-8339: some refactoring</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/511/diffs?diff_id=44031&start_sha=efd777acd87b10cd9b355686c87c6c5edf89cdff)
ali.oezyetimoglu1 commented 2024-06-03 14:17:34 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

resolved all threads

resolved all threads
kilian.schuettler1 commented 2024-06-03 15:13:35 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
ali.oezyetimoglu1 (Migrated from gitlab.knecon.com) merged commit fe777da0f5 into master 2024-06-03 15:38:31 +02:00
ali.oezyetimoglu1 commented 2024-06-03 15:38:33 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit fe777da0f5

mentioned in commit fe777da0f54d321d84dc64b107a7fefb16c623b0
Sign in to join this conversation.
Reviewers
No Reviewers
kilian.schuettler1
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#511
No description provided.
Delete Branch "RED-8339-4"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?