Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-6725: integrate layoutparsing service #55

Merged
kilian.schuettler1 merged 11 commits from RED-6725 into master 2023-08-01 11:02:25 +02:00
Conversation 38 Commits 11 Files Changed 21 +362 -54
kilian.schuettler1 commented 2023-07-24 16:58:01 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
  • updated layout parser version
  • added layout parsing type

Closes RED-6725

* updated layout parser version * added layout parsing type Closes RED-6725
kilian.schuettler1 commented 2023-07-24 16:58:01 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

requested review from @dominique.eiflaender1, @timo.bejan.ext, @ali.oezyetimoglu1, @corina.olariu.ext1, and @andrei.isvoran.ext

requested review from @dominique.eiflaender1, @timo.bejan.ext, @ali.oezyetimoglu1, @corina.olariu.ext1, and @andrei.isvoran.ext
kilian.schuettler1 commented 2023-07-24 16:58:01 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @kilian.schuettler1

assigned to @kilian.schuettler1
corina.olariu.ext1 (Migrated from gitlab.knecon.com) approved these changes 2023-07-24 16:58:01 +02:00
timo.bejan.ext (Migrated from gitlab.knecon.com) approved these changes 2023-07-24 16:58:01 +02:00
ali.oezyetimoglu1 (Migrated from gitlab.knecon.com) approved these changes 2023-07-24 16:58:01 +02:00
kilian.schuettler1 commented 2023-07-24 17:01:56 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 7a5d6a5c - RED-6725: fix test mock

Compare with previous version

added 1 commit <ul><li>7a5d6a5c - RED-6725: fix test mock</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13218&start_sha=09d7bf0847c18a67272c796a314981f690280284)
kilian.schuettler1 commented 2023-07-24 17:02:55 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>06c52c7c - RED-6725: fix test mock</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13220&start_sha=7a5d6a5c81fc545fb96faf00cb685cbecbb94a84)
kilian.schuettler1 commented 2023-07-24 18:00:41 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 8d881a55 - RED-6725: deprecate FileType.TEXT, fix tests

Compare with previous version

added 1 commit <ul><li>8d881a55 - RED-6725: deprecate FileType.TEXT, fix tests</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13222&start_sha=06c52c7cfe3b14cd52f1d8c778074003e664f2ba)
corina.olariu.ext1 commented 2023-07-25 08:17:52 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
ali.oezyetimoglu1 commented 2023-07-25 08:52:46 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

You can extract this part into a new method, this seems to be the same in all cases

You can extract this part into a new method, this seems to be the same in all cases
ali.oezyetimoglu1 commented 2023-07-25 08:52:46 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

"Request " + "contains error." <- Here the plus is unnecessary, because no line break (same in other methods)

"Request " + "contains error." <- Here the plus is unnecessary, because no line break (same in other methods)
ali.oezyetimoglu1 commented 2023-07-25 08:52:46 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

description = "The section text is not found." <- document instead of section imo

description = "The section text is not found." <- document instead of section imo
ali.oezyetimoglu1 commented 2023-07-25 08:52:46 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

document positions instead of section text

document positions instead of section text
ali.oezyetimoglu1 commented 2023-07-25 08:52:46 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

document structure instead of section text

document structure instead of section text
ali.oezyetimoglu1 commented 2023-07-25 08:52:46 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

document pages instead of section text

document pages instead of section text
andrei.isvoran.ext commented 2023-07-25 09:33:05 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

http headers are usually provided by spring, you can use HttpHeaders.CONTENT_DISPOSITION

http headers are usually provided by spring, you can use HttpHeaders.CONTENT_DISPOSITION
andrei.isvoran.ext commented 2023-07-25 09:35:20 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

this does not seem to be used

this does not seem to be used
timo.bejan.ext commented 2023-07-26 10:09:49 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
kilian.schuettler1 commented 2023-07-31 14:04:47 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13752&start_sha=8d881a55970fea77b5b4a7c012d9261ccc14afcf#7dfc03a61513b2a2189f616abc3f95d19b552e4f_116_110)
kilian.schuettler1 commented 2023-07-31 14:04:47 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13752&start_sha=8d881a55970fea77b5b4a7c012d9261ccc14afcf#10cb92a098991f426a5472f38563a314661a5a33_61_61)
kilian.schuettler1 commented 2023-07-31 14:04:47 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13752&start_sha=8d881a55970fea77b5b4a7c012d9261ccc14afcf#10cb92a098991f426a5472f38563a314661a5a33_67_67)
kilian.schuettler1 commented 2023-07-31 14:04:47 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13752&start_sha=8d881a55970fea77b5b4a7c012d9261ccc14afcf#10cb92a098991f426a5472f38563a314661a5a33_73_73)
kilian.schuettler1 commented 2023-07-31 14:04:47 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13752&start_sha=8d881a55970fea77b5b4a7c012d9261ccc14afcf#10cb92a098991f426a5472f38563a314661a5a33_85_85)
kilian.schuettler1 commented 2023-07-31 14:04:48 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13752&start_sha=8d881a55970fea77b5b4a7c012d9261ccc14afcf#7dfc03a61513b2a2189f616abc3f95d19b552e4f_115_110)
kilian.schuettler1 commented 2023-07-31 14:04:48 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13752&start_sha=8d881a55970fea77b5b4a7c012d9261ccc14afcf#5c49f2af841b82a8a1c8c8d7a237b091ebcbb865_21_20)
kilian.schuettler1 commented 2023-07-31 14:04:48 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • dedaa4fd - RED-6725: integrate layout parser

Compare with previous version

added 1 commit <ul><li>dedaa4fd - RED-6725: integrate layout parser</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13752&start_sha=8d881a55970fea77b5b4a7c012d9261ccc14afcf)
ali.oezyetimoglu1 commented 2023-07-31 14:17:50 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Should change the version

Should change the version
kilian.schuettler1 commented 2023-07-31 14:21:45 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13756&start_sha=dedaa4fd299ec8246bb4c29dfac046fd47005794#4a7cb58e6e62e0e68ae218cf1cb3d2240aaaafc4_94_94)
kilian.schuettler1 commented 2023-07-31 14:21:45 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>4289fb01 - use final version</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13756&start_sha=dedaa4fd299ec8246bb4c29dfac046fd47005794)
kilian.schuettler1 commented 2023-07-31 14:33:51 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3433aba2 - add application type</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13760&start_sha=4289fb0156f4ea0acb7b4c24f236d0e31a0204b6)
ali.oezyetimoglu1 commented 2023-07-31 14:57:03 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
kilian.schuettler1 commented 2023-07-31 15:36:48 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • b75f592a - add simplifiedText

Compare with previous version

added 1 commit <ul><li>b75f592a - add simplifiedText</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13786&start_sha=3433aba2693a02765574f2085e036c1645cf8a67)
kilian.schuettler1 commented 2023-07-31 15:45:15 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>21e759ea - add simplifiedText</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13788&start_sha=b75f592a51fb4f5414a897107535a784755649a3)
kilian.schuettler1 commented 2023-08-01 00:07:34 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>4fe01b9d - fix some log messages</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13862&start_sha=21e759ead1f0aea643f9d39f4d0810cfcad8b0e0)
kilian.schuettler1 commented 2023-08-01 00:45:50 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>77970e68 - add sectio grid id</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13868&start_sha=4fe01b9d28778886fe45b348efe432de17d89180)
kilian.schuettler1 commented 2023-08-01 10:45:03 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • ceb4e184 - update layoutparser version

Compare with previous version

added 1 commit <ul><li>ceb4e184 - update layoutparser version</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13945&start_sha=77970e684ccf3aae6334c56de5d172e389193288)
kilian.schuettler1 commented 2023-08-01 10:45:55 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 22 commits

  • ceb4e184...e7b29fb6 - 11 commits from branch master
  • 12703c6e - 1 earlier commit
  • 49770900 - RED-6725: integrate layoutparsing service
  • c9254532 - RED-6725: fix test mock
  • 41055630 - RED-6725: deprecate FileType.TEXT, fix tests
  • 0e2200f3 - RED-6725: integrate layout parser
  • 93d2f417 - use final version
  • e794a8ef - add application type
  • b7d51a07 - add simplifiedText
  • a6cf632d - fix some log messages
  • 7e4a0347 - add sectio grid id
  • 3fae3c06 - update layoutparser version

Compare with previous version

added 22 commits <ul><li>ceb4e184...e7b29fb6 - 11 commits from branch <code>master</code></li><li>12703c6e - 1 earlier commit</li><li>49770900 - RED-6725: integrate layoutparsing service</li><li>c9254532 - RED-6725: fix test mock</li><li>41055630 - RED-6725: deprecate FileType.TEXT, fix tests</li><li>0e2200f3 - RED-6725: integrate layout parser</li><li>93d2f417 - use final version</li><li>e794a8ef - add application type</li><li>b7d51a07 - add simplifiedText</li><li>a6cf632d - fix some log messages</li><li>7e4a0347 - add sectio grid id</li><li>3fae3c06 - update layoutparser version</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/55/diffs?diff_id=13946&start_sha=ceb4e184326fdabdd0138ac41c77267719bb8864)
kilian.schuettler1 (Migrated from gitlab.knecon.com) scheduled this pull request to auto merge when all checks succeed 2023-08-01 10:46:14 +02:00
kilian.schuettler1 commented 2023-08-01 11:02:25 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit 0cb92b8581

mentioned in commit 0cb92b858169229a4fc730f81c8dcbf782081a1a
kilian.schuettler1 (Migrated from gitlab.knecon.com) merged commit 0cb92b8581 into master 2023-08-01 11:02:25 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
corina.olariu.ext1
timo.bejan.ext
ali.oezyetimoglu1
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#55
No description provided.
Delete Branch "RED-6725"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?