Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-9393: user stats endpoint #570

Closed
yannik.hampe wants to merge 13 commits from RED-9393 into master
pull from: RED-9393
merge into: Marmelator:master
Conversation 24 Commits 13 Files Changed 9 +175 -17
yannik.hampe commented 2024-07-04 15:07:17 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added endpoint

Closes RED-9393

added endpoint Closes RED-9393
yannik.hampe commented 2024-07-04 15:07:17 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @yannik.hampe

assigned to @yannik.hampe
corina.olariu.ext1 (Migrated from gitlab.knecon.com) approved these changes 2024-07-04 15:07:17 +02:00
andrei.isvoran.ext (Migrated from gitlab.knecon.com) approved these changes 2024-07-04 15:07:17 +02:00
dominique.eiflaender1 commented 2024-07-09 13:09:43 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit 31c2d48371

mentioned in commit 31c2d48371e75d90f657b1704132865fa6cd6fdc
yannik.hampe commented 2024-07-10 08:27:43 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 21ed61bc - RED-9393: user stats endpoint

Compare with previous version

added 1 commit <ul><li>21ed61bc - RED-9393: user stats endpoint</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/570/diffs?diff_id=47484&start_sha=05a1a7de547c52db93eb2f40d773bc69f6c62ce4)
yannik.hampe commented 2024-07-10 09:18:03 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • f231a757 - RED-9393: user stats endpoint

Compare with previous version

added 1 commit <ul><li>f231a757 - RED-9393: user stats endpoint</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/570/diffs?diff_id=47487&start_sha=21ed61bc61f99f0184fb6c07f4d3f189c6cdc2cd)
yannik.hampe commented 2024-07-10 09:19:09 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 13 commits

  • f231a757...539da8d8 - 9 commits from branch master
  • 98c2aed8 - RED-9393: user stats endpoint
  • ecddef18 - RED-9393: user stats endpoint
  • 8f3cec42 - RED-9393: user stats endpoint
  • 7354d15a - Merge remote-tracking branch 'origin/RED-9393' into RED-9393

Compare with previous version

added 13 commits <ul><li>f231a757...539da8d8 - 9 commits from branch <code>master</code></li><li>98c2aed8 - RED-9393: user stats endpoint</li><li>ecddef18 - RED-9393: user stats endpoint</li><li>8f3cec42 - RED-9393: user stats endpoint</li><li>7354d15a - Merge remote-tracking branch &#39;origin/RED-9393&#39; into RED-9393</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/570/diffs?diff_id=47489&start_sha=f231a757226a7b40c746ba2a6ee53899e52a0673)
yannik.hampe commented 2024-07-10 09:56:43 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • b5819178 - RED-9393: user stats endpoint

Compare with previous version

added 1 commit <ul><li>b5819178 - RED-9393: user stats endpoint</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/570/diffs?diff_id=47493&start_sha=7354d15aa361a5b3d636d6d153a674daa578f23f)
yannik.hampe commented 2024-07-10 10:05:07 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • a6b275a9 - RED-9393: user stats endpoint

Compare with previous version

added 1 commit <ul><li>a6b275a9 - RED-9393: user stats endpoint</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/570/diffs?diff_id=47495&start_sha=b5819178b3a2044c15b45b3c8d55034c14a93203)
yannik.hampe commented 2024-07-10 13:05:28 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 019bec44 - RED-9393: user stats endpoint

Compare with previous version

added 1 commit <ul><li>019bec44 - RED-9393: user stats endpoint</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/570/diffs?diff_id=47514&start_sha=a6b275a928ae97eb3771d8fc31a1bfd675724914)
yannik.hampe commented 2024-07-10 13:10:59 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • e114291f - RED-9393: user stats endpoint

Compare with previous version

added 1 commit <ul><li>e114291f - RED-9393: user stats endpoint</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/570/diffs?diff_id=47516&start_sha=019bec4496cc17cdb1d6150d7318c67646bfd3b0)
yannik.hampe commented 2024-07-10 13:20:01 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

requested review from @kilian.schuettler1, @dominique.eiflaender1, @ali.oezyetimoglu1, @andrei.isvoran.ext, @corina.olariu.ext1, and @maverick.studer

requested review from @kilian.schuettler1, @dominique.eiflaender1, @ali.oezyetimoglu1, @andrei.isvoran.ext, @corina.olariu.ext1, and @maverick.studer
andrei.isvoran.ext commented 2024-07-10 13:23:16 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

I think all of these can be done via Hibernate or Queries to avoid loading everything from DB into memory and then filtering them.

I think all of these can be done via Hibernate or Queries to avoid loading everything from DB into memory and then filtering them.
corina.olariu.ext1 commented 2024-07-10 13:25:59 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

are you sure that the condition is !user.isEmpty() ?

are you sure that the condition is !user.isEmpty() ?
yannik.hampe commented 2024-07-10 13:26:51 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

oops. i added this by mistake while refactoring the sonarqube results.

oops. i added this by mistake while refactoring the sonarqube results.
yannik.hampe commented 2024-07-10 13:34:56 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

agreed and changed.

agreed and changed.
yannik.hampe commented 2024-07-10 13:34:56 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

resolved all threads

resolved all threads
yannik.hampe commented 2024-07-10 13:35:25 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/redactmanager/persistence-service/-/merge_requests/570/diffs?diff_id=47524&start_sha=e114291f566ece5eab6679f9b2da5584a002d97b#91904eedeb08e754fc7766163ce4c5f313cc94e1_39_34)
yannik.hampe commented 2024-07-10 13:35:25 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/redactmanager/persistence-service/-/merge_requests/570/diffs?diff_id=47524&start_sha=e114291f566ece5eab6679f9b2da5584a002d97b#91904eedeb08e754fc7766163ce4c5f313cc94e1_35_31)
yannik.hampe commented 2024-07-10 13:35:26 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • d8c16291 - RED-9393: user stats endpoint

Compare with previous version

added 1 commit <ul><li>d8c16291 - RED-9393: user stats endpoint</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/570/diffs?diff_id=47524&start_sha=e114291f566ece5eab6679f9b2da5584a002d97b)
corina.olariu.ext1 commented 2024-07-10 13:45:13 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
andrei.isvoran.ext commented 2024-07-10 13:47:31 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
yannik.hampe commented 2024-07-12 14:54:09 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 1afc3623 - RED-9393: user stats endpoint

Compare with previous version

added 1 commit <ul><li>1afc3623 - RED-9393: user stats endpoint</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/570/diffs?diff_id=47923&start_sha=d8c162918e2f970a303b63e54a5637efeee5761e)
christoph.schabert commented 2024-07-12 14:56:21 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

SonarQube Code Analysis

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

## SonarQube Code Analysis ## Quality Gate failed Failed conditions [![](https://sonarqube.knecon.com/static/developer-server/common/failed-16px.png '')](https://sonarqube.knecon.com/component_measures?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=570&metric=new_coverage&view=list) [0.0% Coverage on New Code](https://sonarqube.knecon.com/component_measures?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=570&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarQube](https://sonarqube.knecon.com/dashboard?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=570) ##
yannik.hampe (Migrated from gitlab.knecon.com) closed this pull request 2024-10-23 09:31:19 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
andrei.isvoran.ext
corina.olariu.ext1
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#570
No description provided.
Delete Branch "RED-9393"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?