Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-9608 - Comments not removed after uploading multiple files via ZIP-Archive... #597

Merged
corina.olariu.ext1 merged 2 commits from RED-9608-bp into release/2.465.x 2024-07-16 09:53:59 +02:00
Conversation 6 Commits 2 Files Changed 3 +126 -4
corina.olariu.ext1 commented 2024-07-15 15:30:00 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

RED-9608 - Comments not removed after uploading multiple files via ZIP-Archive with "Overwrite and start over" selected

  • remove (soft-delete) all comments, not just the ones related to the manual redactions at overwrite
  • restore back all comments (not just the ones related to the manual redactions) when file is restored
  • unit tests added

Closes RED-9608

RED-9608 - Comments not removed after uploading multiple files via ZIP-Archive with "Overwrite and start over" selected - remove (soft-delete) all comments, not just the ones related to the manual redactions at overwrite - restore back all comments (not just the ones related to the manual redactions) when file is restored - unit tests added Closes RED-9608
corina.olariu.ext1 commented 2024-07-15 15:30:00 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @corina.olariu.ext1

assigned to @corina.olariu.ext1
andrei.isvoran.ext (Migrated from gitlab.knecon.com) approved these changes 2024-07-15 15:30:00 +02:00
andrei.isvoran.ext commented 2024-07-15 15:35:11 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
corina.olariu.ext1 commented 2024-07-15 15:44:05 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • d1ad080e - RED-9608 - Comments not removed after uploading multiple files via ZIP-Archive...

Compare with previous version

added 1 commit <ul><li>d1ad080e - RED-9608 - Comments not removed after uploading multiple files via ZIP-Archive...</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/597/diffs?diff_id=48274&start_sha=27ac2ddcb80994b0fb41ad78e5a17c5c763eec2a)
christoph.schabert commented 2024-07-15 15:47:34 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

SonarQube Code Analysis

Quality Gate failed

Failed conditions
14 New issues

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

## SonarQube Code Analysis ## Quality Gate failed Failed conditions [![](https://sonarqube.knecon.com/static/developer-server/common/failed-16px.png '')](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-server-v1&pullRequest=597&resolved=false) [14 New issues](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-server-v1&pullRequest=597&resolved=false) [See analysis details on SonarQube](https://sonarqube.knecon.com/dashboard?id=persistence-service%3Apersistence-service-server-v1&pullRequest=597) ## ![](https://sonarqube.knecon.com/static/developer-server/common/bulb-16px.png '') Catch issues before they fail your Quality Gate with our IDE extension [![SonarLint](https://sonarqube.knecon.com/static/developer-server/common/sonarlint-16px.png 'SonarLint')](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
corina.olariu.ext1 commented 2024-07-16 09:53:59 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit e36872947b

mentioned in commit e36872947b7c5bc02a98c0a0c789eb39ef74d4b3
corina.olariu.ext1 (Migrated from gitlab.knecon.com) merged commit e36872947b into release/2.465.x 2024-07-16 09:53:59 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
andrei.isvoran.ext
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#597
No description provided.
Delete Branch "RED-9608-bp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?