Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-9608 - Comments not removed after uploading multiple files via ZIP-Archive... #601

Merged
corina.olariu.ext1 merged 2 commits from RED-9608 into master 2024-07-16 16:49:25 +02:00
Conversation 5 Commits 2 Files Changed 3 +142 -16
corina.olariu.ext1 commented 2024-07-16 14:20:12 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

RED-9608 - Comments not removed after uploading multiple files via ZIP-Archive with "Overwrite and start over" selected

  • remove (soft-delete) all comments, not just the ones related to the manual redactions at overwrite
  • restore back all comments (not just the ones related to the manual redactions) when file is restored
  • unit tests added

Closes RED-9608

RED-9608 - Comments not removed after uploading multiple files via ZIP-Archive with "Overwrite and start over" selected - remove (soft-delete) all comments, not just the ones related to the manual redactions at overwrite - restore back all comments (not just the ones related to the manual redactions) when file is restored - unit tests added Closes RED-9608
corina.olariu.ext1 commented 2024-07-16 14:20:12 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @corina.olariu.ext1

assigned to @corina.olariu.ext1
andrei.isvoran.ext (Migrated from gitlab.knecon.com) approved these changes 2024-07-16 14:20:12 +02:00
christoph.schabert commented 2024-07-16 14:22:21 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

SonarQube Code Analysis

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

## SonarQube Code Analysis ## Quality Gate passed Issues [![](https://sonarqube.knecon.com/static/developer-server/common/passed-16px.png '')](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=601&resolved=false) [0 New issues](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=601&resolved=false) [![](https://sonarqube.knecon.com/static/developer-server/common/fixed-16px.png '')](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&fixedInPullRequest=601) [0 Fixed issues](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&fixedInPullRequest=601) [![](https://sonarqube.knecon.com/static/developer-server/common/accepted-16px.png '')](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=601&issueStatuses=ACCEPTED) [0 Accepted issues](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=601&issueStatuses=ACCEPTED) Measures [![](https://sonarqube.knecon.com/static/developer-server/common/passed-16px.png '')](https://sonarqube.knecon.com/security_hotspots?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=601) [0 Security Hotspots](https://sonarqube.knecon.com/security_hotspots?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=601) ![](https://sonarqube.knecon.com/static/developer-server/common/no-data-16px.png '') No data about Coverage ![](https://sonarqube.knecon.com/static/developer-server/common/no-data-16px.png '') No data about Duplication [See analysis details on SonarQube](https://sonarqube.knecon.com/dashboard?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=601) ##
andrei.isvoran.ext commented 2024-07-16 16:44:13 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
corina.olariu.ext1 commented 2024-07-16 16:49:25 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit f266582f48

mentioned in commit f266582f4819b80782e956434d0e0759dd651d1e
corina.olariu.ext1 (Migrated from gitlab.knecon.com) merged commit f266582f48 into master 2024-07-16 16:49:25 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
andrei.isvoran.ext
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#601
No description provided.
Delete Branch "RED-9608"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?