Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-9255: attempt deletion of imported dossier template, when file import fails on any step #626

Closed
kilian.schuettler1 wants to merge 13 commits from RED-9255 into master
pull from: RED-9255
merge into: Marmelator:master
Conversation 14 Commits 13 Files Changed 232 +1340 -974
kilian.schuettler1 commented 2024-07-26 13:32:18 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

also includes a full reformat, look at changes from commit 1 -> commit 2

also includes a full reformat, look at changes from commit 1 -\> commit 2
kilian.schuettler1 commented 2024-07-26 13:32:19 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @kilian.schuettler1

assigned to @kilian.schuettler1
kilian.schuettler1 commented 2024-07-26 13:36:59 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed title from R{-esolve RED-9255-} to R{+ED-9255: attempt deletion of imported dossier template, when file import fails on any step+}

changed title from **R{-esolve RED-9255-}** to **R{+ED-9255: attempt deletion of imported dossier template, when file import fails on any step+}**
kilian.schuettler1 commented 2024-07-26 13:37:00 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed the description

changed the description
kilian.schuettler1 commented 2024-07-26 13:39:57 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 85a3f739 - re-add authorization

Compare with previous version

added 1 commit <ul><li>85a3f739 - re-add authorization</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/626/diffs?diff_id=49255&start_sha=1e3843a8540aec1ed600f458a6ec0e6a1f34f4cd)
kilian.schuettler1 commented 2024-07-26 13:43:54 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 8f2b3148 - fix tests

Compare with previous version

added 1 commit <ul><li>8f2b3148 - fix tests</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/626/diffs?diff_id=49257&start_sha=85a3f73956f136677e04845757f80df4397c8b48)
kilian.schuettler1 commented 2024-07-26 13:57:34 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 4197fbb2 - fix checkstyle

Compare with previous version

added 1 commit <ul><li>4197fbb2 - fix checkstyle</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/626/diffs?diff_id=49265&start_sha=8f2b3148bb88a0c0001c3b7332984efe61e6ab85)
kilian.schuettler1 commented 2024-07-26 14:01:14 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • bd1bf348 - fix startup

Compare with previous version

added 1 commit <ul><li>bd1bf348 - fix startup</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/626/diffs?diff_id=49268&start_sha=4197fbb2bc9ec5a0b538cbf1bf2f3023ad9b3f94)
kilian.schuettler1 commented 2024-07-26 14:18:44 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 9b3111eb - break cyclic service injection

Compare with previous version

added 1 commit <ul><li>9b3111eb - break cyclic service injection</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/626/diffs?diff_id=49271&start_sha=bd1bf348ef834315bc28ae388d057474dae503d0)
kilian.schuettler1 commented 2024-07-26 14:50:30 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 5ce7851c - break cyclic service injection

Compare with previous version

added 1 commit <ul><li>5ce7851c - break cyclic service injection</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/626/diffs?diff_id=49279&start_sha=9b3111eb432130ba6c48ee7153955b1f542e9522)
kilian.schuettler1 commented 2024-07-26 14:56:32 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 047d0da6 - null checks

Compare with previous version

added 1 commit <ul><li>047d0da6 - null checks</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/626/diffs?diff_id=49286&start_sha=5ce7851c58e07a172453c20e9920e1be02207069)
kilian.schuettler1 commented 2024-07-26 15:14:37 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 49ad8613 - hard delete dicts

Compare with previous version

added 1 commit <ul><li>49ad8613 - hard delete dicts</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/626/diffs?diff_id=49289&start_sha=047d0da6e70b97bf3078e7c885d72f2245006084)
kilian.schuettler1 commented 2024-08-09 18:40:55 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 59 commits

  • 49ad8613...9be0fad4 - 47 commits from branch master
  • 9be0fad4...ab6ae052 - 2 earlier commits
  • c756596f - re-add authorization
  • 8751e401 - fix tests
  • f26d858f - fix checkstyle
  • d0b15e04 - fix startup
  • e7ae4e3e - break cyclic service injection
  • 7538ecef - break cyclic service injection
  • 1dda29be - null checks
  • 64a6b07b - hard delete dicts
  • 8d70c557 - deletion of dossier template on failed import
  • 6342b1b4 - deletion of dossier template on failed import

Compare with previous version

added 59 commits <ul><li>49ad8613...9be0fad4 - 47 commits from branch <code>master</code></li><li>9be0fad4...ab6ae052 - 2 earlier commits</li><li>c756596f - re-add authorization</li><li>8751e401 - fix tests</li><li>f26d858f - fix checkstyle</li><li>d0b15e04 - fix startup</li><li>e7ae4e3e - break cyclic service injection</li><li>7538ecef - break cyclic service injection</li><li>1dda29be - null checks</li><li>64a6b07b - hard delete dicts</li><li>8d70c557 - deletion of dossier template on failed import</li><li>6342b1b4 - deletion of dossier template on failed import</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/626/diffs?diff_id=50031&start_sha=49ad861305eadef06e7b658f460717fe29d9ec17)
kilian.schuettler1 commented 2024-08-16 10:26:23 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 189f2f00 - deletion of dossier template on failed import

Compare with previous version

added 1 commit <ul><li>189f2f00 - deletion of dossier template on failed import</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/626/diffs?diff_id=50306&start_sha=6342b1b4f6202c61bf0418e21fa2ad54ea060563)
christoph.schabert commented 2024-08-16 10:30:13 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

SonarQube Code Analysis

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

## SonarQube Code Analysis ## Quality Gate passed Issues [![](https://sonarqube.knecon.com/static/developer-server/common/passed-16px.png '')](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=626&resolved=false) [0 New issues](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=626&resolved=false) [![](https://sonarqube.knecon.com/static/developer-server/common/fixed-16px.png '')](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&fixedInPullRequest=626) [0 Fixed issues](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&fixedInPullRequest=626) [![](https://sonarqube.knecon.com/static/developer-server/common/accepted-16px.png '')](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=626&issueStatuses=ACCEPTED) [0 Accepted issues](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=626&issueStatuses=ACCEPTED) Measures [![](https://sonarqube.knecon.com/static/developer-server/common/passed-16px.png '')](https://sonarqube.knecon.com/security_hotspots?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=626) [0 Security Hotspots](https://sonarqube.knecon.com/security_hotspots?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=626) [![](https://sonarqube.knecon.com/static/developer-server/common/passed-16px.png '')](https://sonarqube.knecon.com/component_measures?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=626&metric=new_coverage&view=list) [0.0% Coverage on New Code](https://sonarqube.knecon.com/component_measures?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=626&metric=new_coverage&view=list) [![](https://sonarqube.knecon.com/static/developer-server/common/passed-16px.png '')](https://sonarqube.knecon.com/component_measures?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=626&metric=new_duplicated_lines_density&view=list) [0.0% Duplication on New Code](https://sonarqube.knecon.com/component_measures?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=626&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube](https://sonarqube.knecon.com/dashboard?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=626) ##
kilian.schuettler1 (Migrated from gitlab.knecon.com) closed this pull request 2024-11-15 14:46:38 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#626
No description provided.
Delete Branch "RED-9255"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?