Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-9255: attempt to delete the entire imported dossier template, if any exception happens during import #627

Closed
kilian.schuettler1 wants to merge 10 commits from RED-9255-bp into release/2.465.x
pull from: RED-9255-bp
merge into: Marmelator:release/2.465.x
Conversation 13 Commits 10 Files Changed 180 +1111 -808
kilian.schuettler1 commented 2024-07-26 13:34:04 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

also includes a full reformat, look at changes from commit 1 -> commit 2

also includes a full reformat, look at changes from commit 1 -\> commit 2
kilian.schuettler1 commented 2024-07-26 13:34:04 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @kilian.schuettler1

assigned to @kilian.schuettler1
kilian.schuettler1 commented 2024-07-26 13:35:34 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 6 commits

  • f6ee20ef...ee8d8abd - 4 commits from branch release/2.465.x
  • 6ed97dcf - reformat
  • 3c440f21 - RED-9255: attempt to delete all imported stuff on Exceptions

Compare with previous version

added 6 commits <ul><li>f6ee20ef...ee8d8abd - 4 commits from branch <code>release/2.465.x</code></li><li>6ed97dcf - reformat</li><li>3c440f21 - RED-9255: attempt to delete all imported stuff on Exceptions</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/627/diffs?diff_id=49252&start_sha=f6ee20ef6b67b6861077a1e75781eca018a00f80)
kilian.schuettler1 commented 2024-07-26 13:37:39 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed title from R{-esolve RED-9255 "Bp"-} to R{+ED-9255: attempt to delete the entire imported dossier template, if any exception happens during import+}

changed title from **R{-esolve RED-9255 "Bp"-}** to **R{+ED-9255: attempt to delete the entire imported dossier template, if any exception happens during import+}**
kilian.schuettler1 commented 2024-07-26 13:37:39 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed the description

changed the description
kilian.schuettler1 commented 2024-07-26 13:39:38 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>8389c228 - re-add authorization</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/627/diffs?diff_id=49254&start_sha=3c440f2113e6d1c36c56a305629022251ab55fb5)
kilian.schuettler1 commented 2024-07-26 13:44:07 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>636ebd06 - fix tests</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/627/diffs?diff_id=49258&start_sha=8389c2284b7d05557045b0ce5c693e3c18de19f3)
kilian.schuettler1 commented 2024-07-26 13:57:58 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>b78db8be - fix checkstyle</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/627/diffs?diff_id=49266&start_sha=636ebd06f8cbdb1552327d27373004f434d223ff)
kilian.schuettler1 commented 2024-07-26 14:00:52 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>35495810 - fix startup</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/627/diffs?diff_id=49267&start_sha=b78db8be1cba5ec84bfb9d27ca4f2bd79b2742d0)
kilian.schuettler1 commented 2024-07-26 14:19:03 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • a01030ad - break cyclic service injection

Compare with previous version

added 1 commit <ul><li>a01030ad - break cyclic service injection</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/627/diffs?diff_id=49272&start_sha=354958103e5317c8635005667b30f6a224d6538d)
kilian.schuettler1 commented 2024-07-26 14:51:49 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 0cd97ca9 - break cyclic service injection

Compare with previous version

added 1 commit <ul><li>0cd97ca9 - break cyclic service injection</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/627/diffs?diff_id=49280&start_sha=a01030ad91090b6a5da602023eb3b297e64c84b8)
kilian.schuettler1 commented 2024-07-26 14:56:17 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>d851e94d - null checks</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/627/diffs?diff_id=49284&start_sha=0cd97ca9a443d8fc8dd5a113c403af516cbba6f1)
kilian.schuettler1 commented 2024-07-26 15:14:54 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>acb2d3b4 - hard delete dicts</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/627/diffs?diff_id=49290&start_sha=d851e94dd6a4ebf3fbc36d34156f91148d46ff50)
christoph.schabert commented 2024-07-26 15:24:08 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

SonarQube Code Analysis

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

## SonarQube Code Analysis ## Quality Gate failed Failed conditions [![](https://sonarqube.knecon.com/static/developer-server/common/failed-16px.png '')](https://sonarqube.knecon.com/component_measures?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=627&metric=new_coverage&view=list) [0.0% Coverage on New Code](https://sonarqube.knecon.com/component_measures?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=627&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarQube](https://sonarqube.knecon.com/dashboard?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=627) ##
kilian.schuettler1 (Migrated from gitlab.knecon.com) closed this pull request 2024-11-15 14:46:48 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#627
No description provided.
Delete Branch "RED-9255-bp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?