Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-3813: image similarity refactoring #690

Merged
yannik.hampe merged 1 commits from RED-3813-refactoring into master 2024-08-21 11:20:37 +02:00
Conversation 6 Commits 1 Files Changed 3 +69 -69
yannik.hampe commented 2024-08-21 11:06:09 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

seperated logic for image similarity search to service

changed some logic when filtering for scope

changed some logic for filtering bad request

Closes RED-3813

seperated logic for image similarity search to service changed some logic when filtering for scope changed some logic for filtering bad request Closes RED-3813
kilian.schuettler1 (Migrated from gitlab.knecon.com) approved these changes 2024-08-21 11:06:09 +02:00
yannik.hampe commented 2024-08-21 11:06:10 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @yannik.hampe

assigned to @yannik.hampe
yannik.hampe commented 2024-08-21 11:06:33 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

requested review from @corina.olariu.ext1, @andrei.isvoran.ext, @kilian.schuettler1, @ali.oezyetimoglu1, @dominique.eiflaender1, and @maverick.studer

requested review from @corina.olariu.ext1, @andrei.isvoran.ext, @kilian.schuettler1, @ali.oezyetimoglu1, @dominique.eiflaender1, and @maverick.studer
christoph.schabert commented 2024-08-21 11:09:40 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

SonarQube Code Analysis

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

## SonarQube Code Analysis ## Quality Gate passed Issues [![](https://sonarqube.knecon.com/static/developer-server/common/passed-16px.png '')](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=690&resolved=false) [0 New issues](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=690&resolved=false) [![](https://sonarqube.knecon.com/static/developer-server/common/fixed-16px.png '')](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&fixedInPullRequest=690) [0 Fixed issues](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&fixedInPullRequest=690) [![](https://sonarqube.knecon.com/static/developer-server/common/accepted-16px.png '')](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=690&issueStatuses=ACCEPTED) [0 Accepted issues](https://sonarqube.knecon.com/project/issues?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=690&issueStatuses=ACCEPTED) Measures [![](https://sonarqube.knecon.com/static/developer-server/common/passed-16px.png '')](https://sonarqube.knecon.com/security_hotspots?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=690) [0 Security Hotspots](https://sonarqube.knecon.com/security_hotspots?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=690) [![](https://sonarqube.knecon.com/static/developer-server/common/passed-16px.png '')](https://sonarqube.knecon.com/component_measures?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=690&metric=new_coverage&view=list) [0.0% Coverage on New Code](https://sonarqube.knecon.com/component_measures?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=690&metric=new_coverage&view=list) [![](https://sonarqube.knecon.com/static/developer-server/common/passed-16px.png '')](https://sonarqube.knecon.com/component_measures?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=690&metric=new_duplicated_lines_density&view=list) [0.0% Duplication on New Code](https://sonarqube.knecon.com/component_measures?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=690&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube](https://sonarqube.knecon.com/dashboard?id=persistence-service%3Apersistence-service-external-api-impl-v1&pullRequest=690) ##
kilian.schuettler1 commented 2024-08-21 11:16:17 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
yannik.hampe (Migrated from gitlab.knecon.com) merged commit fd910bf189 into master 2024-08-21 11:20:37 +02:00
yannik.hampe commented 2024-08-21 11:20:38 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit fd910bf189

mentioned in commit fd910bf1898cc338a7694fe02acbf53c5beae8f8
Sign in to join this conversation.
Reviewers
No Reviewers
kilian.schuettler1
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#690
No description provided.
Delete Branch "RED-3813-refactoring"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?