From 9cf2bbf7cacd8b51b74c1ff9c8c915058741ae2f Mon Sep 17 00:00:00 2001 From: Corina Olariu Date: Mon, 2 Oct 2023 10:01:34 +0300 Subject: [PATCH 1/2] RED-7185 - RM-46 - Error message when adjusting the Justification - permit only comments with length <= 4000 characters --- .../peristence/v1/server/service/ManualRedactionService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/persistence-service-v1/persistence-service-server-v1/src/main/java/com/iqser/red/service/peristence/v1/server/service/ManualRedactionService.java b/persistence-service-v1/persistence-service-server-v1/src/main/java/com/iqser/red/service/peristence/v1/server/service/ManualRedactionService.java index 2fd4735e6..74d4f0890 100644 --- a/persistence-service-v1/persistence-service-server-v1/src/main/java/com/iqser/red/service/peristence/v1/server/service/ManualRedactionService.java +++ b/persistence-service-v1/persistence-service-server-v1/src/main/java/com/iqser/red/service/peristence/v1/server/service/ManualRedactionService.java @@ -928,7 +928,7 @@ public class ManualRedactionService { private void checkComment(String text) { - if (!StringUtils.isEmpty(text) && text.length() >= COMMENT_MAX_LENGTH) { + if (!StringUtils.isEmpty(text) && text.length() > COMMENT_MAX_LENGTH) { throw new BadRequestException(String.format("The comment is too long (%s), max length %s", text.length(), COMMENT_MAX_LENGTH)); } } -- 2.47.2 From 807da0a44a29acada5d813e4ade06ee7e6a53c01 Mon Sep 17 00:00:00 2001 From: Corina Olariu Date: Tue, 3 Oct 2023 11:17:58 +0300 Subject: [PATCH 2/2] RED-7185 - RM-46 - Error message when adjusting the Justification - add transactional on manual changes so the rollback can take place if comment is too long --- .../v1/server/service/ManualRedactionService.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/persistence-service-v1/persistence-service-server-v1/src/main/java/com/iqser/red/service/peristence/v1/server/service/ManualRedactionService.java b/persistence-service-v1/persistence-service-server-v1/src/main/java/com/iqser/red/service/peristence/v1/server/service/ManualRedactionService.java index 74d4f0890..9f0b15eb6 100644 --- a/persistence-service-v1/persistence-service-server-v1/src/main/java/com/iqser/red/service/peristence/v1/server/service/ManualRedactionService.java +++ b/persistence-service-v1/persistence-service-server-v1/src/main/java/com/iqser/red/service/peristence/v1/server/service/ManualRedactionService.java @@ -103,6 +103,7 @@ public class ManualRedactionService { private final int COMMENT_MAX_LENGTH = 4000; + @Transactional public List addAddRedaction(String dossierId, String fileId, List addRedactionRequests) { var response = new ArrayList(); @@ -183,6 +184,7 @@ public class ManualRedactionService { } + @Transactional public List addRemoveRedaction(String dossierId, String fileId, List removeRedactionRequests) { RedactionLog redactionLog = null; @@ -251,6 +253,7 @@ public class ManualRedactionService { } + @Transactional public List addForceRedaction(String dossierId, String fileId, List forceRedactionRequests) { var response = new ArrayList(); @@ -279,6 +282,7 @@ public class ManualRedactionService { } + @Transactional public List addLegalBasisChange(String dossierId, String fileId, List legalBasisChangeRequests) { var response = new ArrayList(); @@ -301,6 +305,7 @@ public class ManualRedactionService { } + @Transactional public List addImageRecategorization(String dossierId, String fileId, List imageRecategorizationRequests) { var response = new ArrayList(); @@ -503,6 +508,7 @@ public class ManualRedactionService { } + @Transactional public List addResizeRedaction(String dossierId, String fileId, List resizeRedactionRequests) { var response = new ArrayList(); -- 2.47.2