From fb6b0e29f314e700f7a7b24cfcff7bb89e0dc6f1 Mon Sep 17 00:00:00 2001 From: Ali Oezyetimoglu Date: Thu, 11 Apr 2024 16:02:01 +0200 Subject: [PATCH 1/2] RED-8762: removed unnecessary consumes from new changeFlags endpoint --- .../service/v1/api/external/resource/DictionaryResource.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/persistence-service-v1/persistence-service-external-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/external/resource/DictionaryResource.java b/persistence-service-v1/persistence-service-external-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/external/resource/DictionaryResource.java index b77db241c..efb81b6bc 100644 --- a/persistence-service-v1/persistence-service-external-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/external/resource/DictionaryResource.java +++ b/persistence-service-v1/persistence-service-external-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/external/resource/DictionaryResource.java @@ -198,7 +198,7 @@ public interface DictionaryResource { @ResponseStatus(HttpStatus.NO_CONTENT) - @PostMapping(value = DICTIONARY_REST_PATH + UPDATE_FLAG + TYPE_PATH_VARIABLE + DOSSIER_TEMPLATE_PATH_VARIABLE, consumes = MediaType.APPLICATION_JSON_VALUE) + @PostMapping(value = DICTIONARY_REST_PATH + UPDATE_FLAG + TYPE_PATH_VARIABLE + DOSSIER_TEMPLATE_PATH_VARIABLE) @Operation(summary = "Updates flags regarding to selected type, dossier and dossier template.", description = "None") @ApiResponses(value = {@ApiResponse(responseCode = "204", description = "Successfully updated the flags of the type."), @ApiResponse(responseCode = "400", description = "Request contains error."), @ApiResponse(responseCode = "404", description = "The entry type is not found.")}) void changeFlags(@PathVariable(TYPE_PARAMETER_NAME) String type, -- 2.47.2 From 10be0bd8288d46fd2235c3edae0c8d947742a8d1 Mon Sep 17 00:00:00 2001 From: Ali Oezyetimoglu Date: Thu, 11 Apr 2024 16:02:01 +0200 Subject: [PATCH 2/2] RED-8762: removed unnecessary consumes from new changeFlags endpoint and added dossierId as path variable --- .../v1/api/external/resource/DictionaryResource.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/persistence-service-v1/persistence-service-external-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/external/resource/DictionaryResource.java b/persistence-service-v1/persistence-service-external-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/external/resource/DictionaryResource.java index efb81b6bc..b0a042965 100644 --- a/persistence-service-v1/persistence-service-external-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/external/resource/DictionaryResource.java +++ b/persistence-service-v1/persistence-service-external-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/external/resource/DictionaryResource.java @@ -44,7 +44,8 @@ public interface DictionaryResource { String ENTRY_PATH_VARIABLE = "/{" + ENTRY_PARAMETER_NAME + "}"; String DOSSIER_TEMPLATE_PARAMETER_NAME = "dossierTemplateId"; - String DOSSIER_TEMPLATE_PATH_VARIABLE = "/{dossierTemplateId}"; + String DOSSIER_TEMPLATE_PATH_VARIABLE = "/{"+ DOSSIER_TEMPLATE_PARAMETER_NAME + "}"; + String UPLOAD = "/upload"; String DOWNLOAD = "/download"; @@ -56,6 +57,7 @@ public interface DictionaryResource { String COLOR_REST_PATH = ExternalApi.BASE_PATH + "/color"; String DOSSIER_ID_PARAMETER_NAME = "dossierId"; + String DOSSIER_ID_PATH_VARIABLE = "/{"+ DOSSIER_ID_PARAMETER_NAME + "}"; String INCLUDE_DELETED_PARAMETER_NAME = "includeDeleted"; @@ -198,12 +200,12 @@ public interface DictionaryResource { @ResponseStatus(HttpStatus.NO_CONTENT) - @PostMapping(value = DICTIONARY_REST_PATH + UPDATE_FLAG + TYPE_PATH_VARIABLE + DOSSIER_TEMPLATE_PATH_VARIABLE) + @PostMapping(value = DICTIONARY_REST_PATH + UPDATE_FLAG + TYPE_PATH_VARIABLE + DOSSIER_TEMPLATE_PATH_VARIABLE + DOSSIER_ID_PATH_VARIABLE) @Operation(summary = "Updates flags regarding to selected type, dossier and dossier template.", description = "None") @ApiResponses(value = {@ApiResponse(responseCode = "204", description = "Successfully updated the flags of the type."), @ApiResponse(responseCode = "400", description = "Request contains error."), @ApiResponse(responseCode = "404", description = "The entry type is not found.")}) void changeFlags(@PathVariable(TYPE_PARAMETER_NAME) String type, @PathVariable(DOSSIER_TEMPLATE_PARAMETER_NAME) String dossierTemplateId, - @RequestParam(value = DOSSIER_ID_PARAMETER_NAME) String dossierId, + @PathVariable(DOSSIER_ID_PARAMETER_NAME) String dossierId, @RequestParam(value = "addToDictionary") boolean addToDictionary); } \ No newline at end of file -- 2.47.2