From f1b8e5a25f81d48a51595db2ba5a45098db934a7 Mon Sep 17 00:00:00 2001 From: Julius Unverfehrt Date: Tue, 30 Jan 2024 13:27:19 +0100 Subject: [PATCH] refac(arg parse): rename settings parsing fn for clarity --- README.md | 6 +++--- pyinfra/config/loader.py | 2 +- scripts/start_pyinfra.py | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index dec3e7c..189ad7d 100755 --- a/README.md +++ b/README.md @@ -102,17 +102,17 @@ The callback can be replaced with a custom one, for example if the data to proce and not on the storage. ```python -from pyinfra.config.loader import load_settings, parse_args +from pyinfra.config.loader import load_settings, parse_settings_path from pyinfra.examples import start_standard_queue_consumer from pyinfra.queue.callback import make_download_process_upload_callback, DataProcessor processing_function: DataProcessor -arguments = parse_args() +arguments = parse_settings_path() settings = load_settings(arguments.settings_path) callback = make_download_process_upload_callback(processing_function, settings) -start_standard_queue_consumer(callback, settings) # optionally also pass a fastAPI app object with preconfigured routes +start_standard_queue_consumer(callback, settings) # optionally also pass a fastAPI app object with preconfigured routes ``` diff --git a/pyinfra/config/loader.py b/pyinfra/config/loader.py index 5da779c..8937be9 100644 --- a/pyinfra/config/loader.py +++ b/pyinfra/config/loader.py @@ -129,7 +129,7 @@ def validate_settings(settings: Dynaconf, validators): logger.debug("Settings validated.") -def parse_args(): +def parse_settings_path(): parser = argparse.ArgumentParser() parser.add_argument( "settings_path", diff --git a/scripts/start_pyinfra.py b/scripts/start_pyinfra.py index 3494294..963b1c9 100644 --- a/scripts/start_pyinfra.py +++ b/scripts/start_pyinfra.py @@ -1,6 +1,6 @@ import time -from pyinfra.config.loader import load_settings, parse_args +from pyinfra.config.loader import load_settings, parse_settings_path from pyinfra.examples import start_standard_queue_consumer from pyinfra.queue.callback import make_download_process_upload_callback @@ -11,7 +11,7 @@ def processor_mock(_data: dict, _message: dict) -> dict: if __name__ == "__main__": - arguments = parse_args() + arguments = parse_settings_path() settings = load_settings(arguments.settings_path) callback = make_download_process_upload_callback(processor_mock, settings)