From 0328c9d02040485d7ef223988d148e763a7b67fc Mon Sep 17 00:00:00 2001
From: Dan Percic <dan@devplant.ro>
Date: Tue, 13 Dec 2022 11:46:09 +0200
Subject: [PATCH] RED-5330: fix report template no autoselect

---
 .../download-dialog/download-dialog.component.html |  3 ++-
 .../download-dialog/download-dialog.component.ts   | 14 ++++++--------
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/apps/red-ui/src/app/modules/shared/dialogs/download-dialog/download-dialog.component.html b/apps/red-ui/src/app/modules/shared/dialogs/download-dialog/download-dialog.component.html
index 827fe7105..ce6318b1a 100644
--- a/apps/red-ui/src/app/modules/shared/dialogs/download-dialog/download-dialog.component.html
+++ b/apps/red-ui/src/app/modules/shared/dialogs/download-dialog/download-dialog.component.html
@@ -8,9 +8,10 @@
 
         <div class="dialog-content">
             <redaction-select
+                *ngIf="availableReportTypes | async as reportTypes"
                 [label]="'report-type.label' | translate: { length: reportTypesLength }"
                 [optionTemplate]="reportTemplateOptionTemplate"
-                [options]="availableReportTypes"
+                [options]="reportTypes"
                 [valueMapper]="reportTemplateValueMapper"
                 class="mb-16"
                 formControlName="reportTemplateIds"
diff --git a/apps/red-ui/src/app/modules/shared/dialogs/download-dialog/download-dialog.component.ts b/apps/red-ui/src/app/modules/shared/dialogs/download-dialog/download-dialog.component.ts
index d8373d6a6..d702d3300 100644
--- a/apps/red-ui/src/app/modules/shared/dialogs/download-dialog/download-dialog.component.ts
+++ b/apps/red-ui/src/app/modules/shared/dialogs/download-dialog/download-dialog.component.ts
@@ -1,4 +1,4 @@
-import { Component, Inject, OnInit } from '@angular/core';
+import { Component, Inject } from '@angular/core';
 import { Dossier, DownloadFileType, IReportTemplate } from '@red/domain';
 import { downloadTypesForDownloadTranslations } from '@translations/download-types-translations';
 import { ReportTemplateService } from '@services/report-template.service';
@@ -23,16 +23,14 @@ export interface DownloadDialogResult {
     templateUrl: './download-dialog.component.html',
     styleUrls: ['./download-dialog.component.scss'],
 })
-export class DownloadDialogComponent implements OnInit {
+export class DownloadDialogComponent {
     readonly downloadTypes: { key: DownloadFileType; label: string }[] = ['ORIGINAL', 'PREVIEW', 'DELTA_PREVIEW', 'REDACTED'].map(
         (type: DownloadFileType) => ({
             key: type,
             label: downloadTypesForDownloadTranslations[type],
         }),
     );
-
-    availableReportTypes: IReportTemplate[] = [];
-
+    readonly availableReportTypes = this._availableReportTypes;
     readonly form = this._getForm();
 
     constructor(
@@ -51,10 +49,10 @@ export class DownloadDialogComponent implements OnInit {
         return this.form.controls.downloadFileTypes?.value?.length || 0;
     }
 
-    async ngOnInit() {
+    private get _availableReportTypes() {
         const dossierTemplateId = this.data.dossier.dossierTemplateId;
-
-        this.availableReportTypes = (await this._reportTemplateController.getAvailableReportTemplates(dossierTemplateId)) || [];
+        const result = this._reportTemplateController.getAvailableReportTemplates(dossierTemplateId);
+        return result.then(values => values ?? []);
     }
 
     reportTemplateValueMapper = (reportTemplate: IReportTemplate) => reportTemplate.templateId;