From 0e3f9856d8f3d7a90caab4c9415a5388efd81cb4 Mon Sep 17 00:00:00 2001 From: Dan Percic Date: Wed, 8 Mar 2023 14:02:34 +0200 Subject: [PATCH] RED-6347: fix null injector for dossiers dialog service --- .../license/license-select/license-select.component.ts | 1 - .../components/template-stats/template-stats.component.ts | 3 +-- .../shared-dossiers/services/dossiers-dialog.service.ts | 4 +++- .../src/app/modules/shared-dossiers/shared-dossiers.module.ts | 3 +-- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/apps/red-ui/src/app/modules/admin/screens/license/license-select/license-select.component.ts b/apps/red-ui/src/app/modules/admin/screens/license/license-select/license-select.component.ts index 403b552ea..ab46c24cf 100644 --- a/apps/red-ui/src/app/modules/admin/screens/license/license-select/license-select.component.ts +++ b/apps/red-ui/src/app/modules/admin/screens/license/license-select/license-select.component.ts @@ -4,7 +4,6 @@ import { ILicense } from '@red/domain'; import { marker as _ } from '@biesbjerg/ngx-translate-extract-marker'; import { map, tap } from 'rxjs/operators'; import { IqserPermissionsService } from '@iqser/common-ui'; -import { ROLES } from '@users/roles'; const translations = { active: _('license-info-screen.status.active'), diff --git a/apps/red-ui/src/app/modules/dashboard/components/template-stats/template-stats.component.ts b/apps/red-ui/src/app/modules/dashboard/components/template-stats/template-stats.component.ts index eb6a3924d..b111418ab 100644 --- a/apps/red-ui/src/app/modules/dashboard/components/template-stats/template-stats.component.ts +++ b/apps/red-ui/src/app/modules/dashboard/components/template-stats/template-stats.component.ts @@ -1,4 +1,4 @@ -import { ChangeDetectionStrategy, Component, Input } from '@angular/core'; +import { Component, Input } from '@angular/core'; import { DashboardStats } from '@red/domain'; import { IconButtonTypes } from '@iqser/common-ui'; import { TranslateChartService } from '@services/translate-chart.service'; @@ -10,7 +10,6 @@ import { PermissionsService } from '@services/permissions.service'; selector: 'redaction-template-stats [stats]', templateUrl: './template-stats.component.html', styleUrls: ['./template-stats.component.scss'], - changeDetection: ChangeDetectionStrategy.OnPush, }) export class TemplateStatsComponent { readonly iconButtonTypes = IconButtonTypes; diff --git a/apps/red-ui/src/app/modules/shared-dossiers/services/dossiers-dialog.service.ts b/apps/red-ui/src/app/modules/shared-dossiers/services/dossiers-dialog.service.ts index e5628187b..708bb9cfb 100644 --- a/apps/red-ui/src/app/modules/shared-dossiers/services/dossiers-dialog.service.ts +++ b/apps/red-ui/src/app/modules/shared-dossiers/services/dossiers-dialog.service.ts @@ -8,7 +8,9 @@ import { DictionaryDetailsDialogComponent } from '../dialogs/edit-dossier-dialog type DialogType = 'confirm' | 'editDossier' | 'assignFile' | 'importRedactions' | 'editDictionaryDetails'; -@Injectable() +@Injectable({ + providedIn: 'root', +}) export class DossiersDialogService extends DialogService { protected readonly _config: DialogConfig = { confirm: { diff --git a/apps/red-ui/src/app/modules/shared-dossiers/shared-dossiers.module.ts b/apps/red-ui/src/app/modules/shared-dossiers/shared-dossiers.module.ts index 130608f62..0659a7b1b 100644 --- a/apps/red-ui/src/app/modules/shared-dossiers/shared-dossiers.module.ts +++ b/apps/red-ui/src/app/modules/shared-dossiers/shared-dossiers.module.ts @@ -2,7 +2,6 @@ import { NgModule } from '@angular/core'; import { CommonModule } from '@angular/common'; import { FileActionsComponent } from './components/file-actions/file-actions.component'; import { SharedModule } from '@shared/shared.module'; -import { DossiersDialogService } from './services/dossiers-dialog.service'; import { EditDossierDialogComponent } from './dialogs/edit-dossier-dialog/edit-dossier-dialog.component'; import { AssignReviewerApproverDialogComponent } from './dialogs/assign-reviewer-approver-dialog/assign-reviewer-approver-dialog.component'; import { EditDossierGeneralInfoComponent } from './dialogs/edit-dossier-dialog/general-info/edit-dossier-general-info.component'; @@ -38,7 +37,7 @@ const components = [ DossiersListingActionsComponent, ]; const dialogs = [EditDossierDialogComponent, AssignReviewerApproverDialogComponent, DictionaryDetailsDialogComponent]; -const services = [DossiersDialogService, FileAssignService]; +const services = [FileAssignService]; @NgModule({ declarations: [...components, ...dialogs],