From 11d09cf090a09cffad31648d80342e9651efd749 Mon Sep 17 00:00:00 2001 From: Valentin Mihai Date: Thu, 17 Feb 2022 09:05:58 +0200 Subject: [PATCH] fix to display helpers only when the elements are visible --- .../dossiers-listing-actions.component.html | 2 ++ .../dossier/screens/dossiers-listing/config.service.ts | 1 - .../expandable-file-actions.component.html | 3 +++ .../expandable-file-actions.component.ts | 4 ++++ libs/common-ui | 2 +- 5 files changed, 10 insertions(+), 2 deletions(-) diff --git a/apps/red-ui/src/app/modules/dossier/screens/dossiers-listing/components/dossiers-listing-actions/dossiers-listing-actions.component.html b/apps/red-ui/src/app/modules/dossier/screens/dossiers-listing/components/dossiers-listing-actions/dossiers-listing-actions.component.html index ef389d4e0..c78fbb3ae 100644 --- a/apps/red-ui/src/app/modules/dossier/screens/dossiers-listing/components/dossiers-listing-actions/dossiers-listing-actions.component.html +++ b/apps/red-ui/src/app/modules/dossier/screens/dossiers-listing/components/dossiers-listing-actions/dossiers-listing-actions.component.html @@ -6,6 +6,7 @@ [type]="circleButtonTypes.dark" [icon]="currentUser.isManager ? 'iqser:edit' : 'red:info'" iqserHelpMode="edit_dossier" + [isVirtualScrollElement]="true" > diff --git a/apps/red-ui/src/app/modules/dossier/screens/dossiers-listing/config.service.ts b/apps/red-ui/src/app/modules/dossier/screens/dossiers-listing/config.service.ts index d46135b13..b83129f47 100644 --- a/apps/red-ui/src/app/modules/dossier/screens/dossiers-listing/config.service.ts +++ b/apps/red-ui/src/app/modules/dossier/screens/dossiers-listing/config.service.ts @@ -156,7 +156,6 @@ export class ConfigService { checker: dossierTemplateChecker, }); - console.log(this._quickFilters(entities)); filterGroups.push({ slug: 'quickFilters', filters: this._quickFilters(entities), diff --git a/apps/red-ui/src/app/modules/shared/components/expandable-file-actions/expandable-file-actions.component.html b/apps/red-ui/src/app/modules/shared/components/expandable-file-actions/expandable-file-actions.component.html index dc41698da..e99a143e4 100644 --- a/apps/red-ui/src/app/modules/shared/components/expandable-file-actions/expandable-file-actions.component.html +++ b/apps/red-ui/src/app/modules/shared/components/expandable-file-actions/expandable-file-actions.component.html @@ -11,6 +11,7 @@ [tooltip]="btn.tooltip | translate" [type]="btn.buttonType || buttonType" [iqserHelpMode]="helpModeKey" + [isVirtualScrollElement]="isVirtualScrolElement" > @@ -21,6 +22,7 @@ [tooltipPosition]="tooltipPosition" [type]="buttonType" [iqserHelpMode]="helpModeKey" + [isVirtualScrollElement]="isVirtualScrolElement" > @@ -34,6 +36,7 @@ [matTooltip]="btn.tooltip | translate" [ngClass]="btn.class" [iqserHelpMode]="helpModeKey" + [isVirtualScrollElement]="isVirtualScrolElement" color="primary" > diff --git a/apps/red-ui/src/app/modules/shared/components/expandable-file-actions/expandable-file-actions.component.ts b/apps/red-ui/src/app/modules/shared/components/expandable-file-actions/expandable-file-actions.component.ts index e9de1e723..d9ac332d6 100644 --- a/apps/red-ui/src/app/modules/shared/components/expandable-file-actions/expandable-file-actions.component.ts +++ b/apps/red-ui/src/app/modules/shared/components/expandable-file-actions/expandable-file-actions.component.ts @@ -63,4 +63,8 @@ export class ExpandableFileActionsComponent implements OnChanges { await firstValueFrom(this._fileDownloadService.downloadFiles(filesIds, dossierId)); this._toaster.info(_('download-status.queued')); } + + get isVirtualScrolElement(): boolean { + return this.helpModeKey === 'document_features'; + } } diff --git a/libs/common-ui b/libs/common-ui index 77d0a4bb1..a3a090162 160000 --- a/libs/common-ui +++ b/libs/common-ui @@ -1 +1 @@ -Subproject commit 77d0a4bb1b575d4ebb0dea2b55cfb538794ad66b +Subproject commit a3a090162cf50221004026886d437b1626c49e2f