diff --git a/apps/red-ui/src/app/modules/dossier/dialogs/add-dossier-dialog/add-dossier-dialog.component.html b/apps/red-ui/src/app/modules/dossier/dialogs/add-dossier-dialog/add-dossier-dialog.component.html index 1b3b7c66a..47e3f849e 100644 --- a/apps/red-ui/src/app/modules/dossier/dialogs/add-dossier-dialog/add-dossier-dialog.component.html +++ b/apps/red-ui/src/app/modules/dossier/dialogs/add-dossier-dialog/add-dossier-dialog.component.html @@ -70,7 +70,7 @@

{{ 'download-includes' | translate }}

-
+
diff --git a/apps/red-ui/src/app/modules/dossier/dialogs/manual-redaction-dialog/manual-annotation-dialog.component.ts b/apps/red-ui/src/app/modules/dossier/dialogs/manual-redaction-dialog/manual-annotation-dialog.component.ts index 593e776ab..cd7c01318 100644 --- a/apps/red-ui/src/app/modules/dossier/dialogs/manual-redaction-dialog/manual-annotation-dialog.component.ts +++ b/apps/red-ui/src/app/modules/dossier/dialogs/manual-redaction-dialog/manual-annotation-dialog.component.ts @@ -113,11 +113,15 @@ export class ManualAnnotationDialogComponent extends BaseDialogComponent impleme dictionary: this.isDictionaryRequest ? [this.isFalsePositiveRequest ? 'false_positive' : null, Validators.required] : ['manual', Validators.required], - comment: this.isDocumentAdmin ? [null] : [null, Validators.required], + comment: this.commentIsMandatory ? [null, Validators.required] : [null], classification: ['non-readable content'], }); } + get commentIsMandatory() { + return !this.isDocumentAdmin && !this.isDictionaryRequest; + } + private _enhanceManualRedaction(addRedactionRequest: IAddRedactionRequest) { const legalOption: LegalBasisOption = this.form.get('reason').value; addRedactionRequest.type = this.form.get('dictionary').value; diff --git a/apps/red-ui/src/app/modules/dossier/dialogs/remove-annotations-dialog/remove-annotations-dialog.component.html b/apps/red-ui/src/app/modules/dossier/dialogs/remove-annotations-dialog/remove-annotations-dialog.component.html index 287629e70..2b53655ae 100644 --- a/apps/red-ui/src/app/modules/dossier/dialogs/remove-annotations-dialog/remove-annotations-dialog.component.html +++ b/apps/red-ui/src/app/modules/dossier/dialogs/remove-annotations-dialog/remove-annotations-dialog.component.html @@ -39,7 +39,7 @@ -
+
diff --git a/apps/red-ui/src/app/modules/dossier/dialogs/remove-annotations-dialog/remove-annotations-dialog.component.ts b/apps/red-ui/src/app/modules/dossier/dialogs/remove-annotations-dialog/remove-annotations-dialog.component.ts index 16591d344..644798066 100644 --- a/apps/red-ui/src/app/modules/dossier/dialogs/remove-annotations-dialog/remove-annotations-dialog.component.ts +++ b/apps/red-ui/src/app/modules/dossier/dialogs/remove-annotations-dialog/remove-annotations-dialog.component.ts @@ -29,7 +29,7 @@ export class RemoveAnnotationsDialogComponent extends BaseDialogComponent { ) { super(_injector, _dialogRef); this.form = this._formBuilder.group({ - comment: this.permissionsService.isApprover(this.data.dossier) ? [null] : [null, Validators.required], + comment: this.commentIsMandatory ? [null, Validators.required] : [null], }); this.initialFormValue = this.form.getRawValue(); } @@ -38,6 +38,14 @@ export class RemoveAnnotationsDialogComponent extends BaseDialogComponent { this._dialogRef.close({ comment: this.form.getRawValue().comment }); } + get disabled(): boolean { + return !this.valid; + } + + get commentIsMandatory() { + return !this.permissionsService.isApprover(this.data.dossier) && !this.data.removeFromDictionary; + } + printable(annotation: AnnotationWrapper) { if (annotation.isImage) { return this._translateService.instant('remove-annotations-dialog.image-type', { diff --git a/apps/red-ui/src/app/modules/dossier/screens/dossier-overview/components/table-item/file-workload/file-workload.component.html b/apps/red-ui/src/app/modules/dossier/screens/dossier-overview/components/table-item/file-workload/file-workload.component.html index 9ae92f1b8..d53cd243f 100644 --- a/apps/red-ui/src/app/modules/dossier/screens/dossier-overview/components/table-item/file-workload/file-workload.component.html +++ b/apps/red-ui/src/app/modules/dossier/screens/dossier-overview/components/table-item/file-workload/file-workload.component.html @@ -1,7 +1,7 @@
f.id === key); if (foundFilter) { diff --git a/apps/red-ui/src/app/utils/functions.ts b/apps/red-ui/src/app/utils/functions.ts index 1a8b3d270..582fde488 100644 --- a/apps/red-ui/src/app/utils/functions.ts +++ b/apps/red-ui/src/app/utils/functions.ts @@ -31,7 +31,7 @@ export function hexToRgb(hex) { export function getFirstRelevantTextPart(text, direction: 'FORWARD' | 'BACKWARD') { let spaceCount = 0; let accumulator = ''; - const breakChars = ['/', ':', ' ']; + const breakChars = [':', ' ']; const handle = i => { const char = text[i];