From 306bd872b8cd475427fdee4ee238de3ab8572274 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adina=20=C8=9Aeudan?= <adina@devplant.ro>
Date: Tue, 12 Apr 2022 20:04:44 +0300
Subject: [PATCH] RED-3800: Can't delete system managed entities, fixed hints
 update error

---
 .../entities-listing-screen.component.html            |  4 +++-
 .../add-edit-entity/add-edit-entity.component.ts      | 11 ++++++++---
 apps/red-ui/src/app/services/permissions.service.ts   |  6 +++++-
 .../src/lib/dictionaries/dictionary.model.ts          |  2 ++
 libs/red-domain/src/lib/dictionaries/dictionary.ts    |  2 ++
 5 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/apps/red-ui/src/app/modules/admin/screens/entities-listing/entities-listing-screen.component.html b/apps/red-ui/src/app/modules/admin/screens/entities-listing/entities-listing-screen.component.html
index f4370e0d0..6685b2597 100644
--- a/apps/red-ui/src/app/modules/admin/screens/entities-listing/entities-listing-screen.component.html
+++ b/apps/red-ui/src/app/modules/admin/screens/entities-listing/entities-listing-screen.component.html
@@ -91,16 +91,18 @@
                     {{ templateStats.dictionarySummary(dict.type)?.entriesCount || 0 }}
                 </div>
 
-                <div *ngIf="permissionsService.canEditEntities()" class="action-buttons">
+                <div class="action-buttons">
                     <iqser-circle-button
                         (action)="openDeleteEntitiesDialog($event, [dict])"
                         [tooltip]="'entities-listing.action.delete' | translate"
+                        *ngIf="permissionsService.canDeleteEntity(dict)"
                         [type]="circleButtonTypes.dark"
                         icon="iqser:trash"
                     ></iqser-circle-button>
 
                     <iqser-circle-button
                         [routerLink]="dict.routerLink"
+                        *ngIf="permissionsService.canEditEntities()"
                         [tooltip]="'entities-listing.action.edit' | translate"
                         [type]="circleButtonTypes.dark"
                         icon="iqser:edit"
diff --git a/apps/red-ui/src/app/modules/admin/shared/components/add-edit-entity/add-edit-entity.component.ts b/apps/red-ui/src/app/modules/admin/shared/components/add-edit-entity/add-edit-entity.component.ts
index eb9bd66df..25edfe741 100644
--- a/apps/red-ui/src/app/modules/admin/shared/components/add-edit-entity/add-edit-entity.component.ts
+++ b/apps/red-ui/src/app/modules/admin/shared/components/add-edit-entity/add-edit-entity.component.ts
@@ -105,18 +105,23 @@ export class AddEditEntityComponent implements OnInit, OnChanges {
     }
 
     private _formToObject(): IDictionary {
+        // Fields that aren't set for hints, need additional check
+        const caseInsensitive = this.form.get('caseSensitive') ? !this.form.get('caseSensitive').value : null;
+        const addToDictionaryAction = !!this.form.get('addToDictionaryAction')?.value;
+        const hasDictionary = !!this.form.get('addToDictionaryAction')?.value;
+
         return {
             type: this.form.get('type').value,
             label: this.form.get('label').value,
-            caseInsensitive: !this.form.get('caseSensitive').value,
             description: this.form.get('description').value,
             hexColor: this.form.get('hexColor').value,
             recommendationHexColor: this.form.get('recommendationHexColor').value,
             hint: this.form.get('hint').value,
             rank: this.form.get('rank').value,
-            addToDictionaryAction: !!this.form.get('addToDictionaryAction').value,
             dossierTemplateId: this.dossierTemplateId,
-            hasDictionary: !!this.form.get('hasDictionary').value,
+            caseInsensitive,
+            addToDictionaryAction,
+            hasDictionary,
         };
     }
 }
diff --git a/apps/red-ui/src/app/services/permissions.service.ts b/apps/red-ui/src/app/services/permissions.service.ts
index ab6aebaab..e7c10cce8 100644
--- a/apps/red-ui/src/app/services/permissions.service.ts
+++ b/apps/red-ui/src/app/services/permissions.service.ts
@@ -1,6 +1,6 @@
 import { Injectable } from '@angular/core';
 import { UserService } from './user.service';
-import { Dossier, File, IComment, IDossier } from '@red/domain';
+import { Dictionary, Dossier, File, IComment, IDossier } from '@red/domain';
 import { FilesMapService } from '@services/entity-services/files-map.service';
 import { FeaturesService } from '@services/features.service';
 import { DOSSIERS_ARCHIVE } from '@utils/constants';
@@ -17,6 +17,10 @@ export class PermissionsService {
         return user.isAdmin;
     }
 
+    canDeleteEntity(entity: Dictionary, user = this._userService.currentUser): boolean {
+        return this.canEditEntities(user) && !entity.systemManaged;
+    }
+
     canPerformDossierStatesActions(user = this._userService.currentUser): boolean {
         return user.isAdmin;
     }
diff --git a/libs/red-domain/src/lib/dictionaries/dictionary.model.ts b/libs/red-domain/src/lib/dictionaries/dictionary.model.ts
index 24c06b959..e428db993 100644
--- a/libs/red-domain/src/lib/dictionaries/dictionary.model.ts
+++ b/libs/red-domain/src/lib/dictionaries/dictionary.model.ts
@@ -16,6 +16,7 @@ export class Dictionary extends Entity<IDictionary> implements IDictionary {
     readonly type: string;
     readonly typeId?: string;
     readonly hasDictionary?: boolean;
+    readonly systemManaged?: boolean;
 
     entries: List;
     falsePositiveEntries: List;
@@ -39,6 +40,7 @@ export class Dictionary extends Entity<IDictionary> implements IDictionary {
         this.type = entity.type;
         this.typeId = entity.typeId;
         this.hasDictionary = entity.hasDictionary;
+        this.systemManaged = entity.systemManaged;
     }
 
     get id(): string {
diff --git a/libs/red-domain/src/lib/dictionaries/dictionary.ts b/libs/red-domain/src/lib/dictionaries/dictionary.ts
index 5f0e6b205..899216bb2 100644
--- a/libs/red-domain/src/lib/dictionaries/dictionary.ts
+++ b/libs/red-domain/src/lib/dictionaries/dictionary.ts
@@ -55,4 +55,6 @@ export interface IDictionary {
     readonly recommendationHexColor?: string;
 
     readonly hasDictionary?: boolean;
+
+    readonly systemManaged?: boolean;
 }