From 42fe183170d8f558c1580bbd74968fa1404761c0 Mon Sep 17 00:00:00 2001 From: Valentin Mihai Date: Thu, 11 Apr 2024 19:12:45 +0300 Subject: [PATCH] =?UTF-8?q?RED-8638=20-=20removed=20=E2=80=9CRedaction/Hin?= =?UTF-8?q?t=20added=E2=80=9D=20tooltip=20text?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- apps/red-ui/src/app/models/file/annotation.wrapper.ts | 2 -- .../annotation-details/annotation-details.component.ts | 3 +-- .../translations/annotation-changes-translations.ts | 1 - apps/red-ui/src/assets/i18n/redact/de.json | 10 +++++++++- apps/red-ui/src/assets/i18n/redact/en.json | 1 - apps/red-ui/src/assets/i18n/scm/de.json | 10 +++++++++- apps/red-ui/src/assets/i18n/scm/en.json | 1 - libs/red-domain/src/lib/redaction-log/types.ts | 1 - 8 files changed, 19 insertions(+), 10 deletions(-) diff --git a/apps/red-ui/src/app/models/file/annotation.wrapper.ts b/apps/red-ui/src/app/models/file/annotation.wrapper.ts index 836651065..e1985d7bd 100644 --- a/apps/red-ui/src/app/models/file/annotation.wrapper.ts +++ b/apps/red-ui/src/app/models/file/annotation.wrapper.ts @@ -63,7 +63,6 @@ export class AnnotationWrapper implements IListable { hasBeenForcedHint: boolean; hasBeenForcedRedaction: boolean; hasBeenRemovedByManualOverride: boolean; - hasBeenAdded: boolean; isRemoved = false; isRemovedLocally = false; hiddenInWorkload = false; @@ -270,7 +269,6 @@ export class AnnotationWrapper implements IListable { annotationWrapper.hasBeenRemovedByManualOverride = !!logEntry.manualChanges?.find( c => c.manualRedactionType === ManualRedactionTypes.REMOVE, ); - annotationWrapper.hasBeenAdded = !!logEntry.manualChanges?.find(c => c.manualRedactionType === ManualRedactionTypes.ADD); const content = this.#createContent(annotationWrapper, logEntry, isDocumine); annotationWrapper.shortContent = this.#getShortContent(annotationWrapper, legalBasisList) || content; diff --git a/apps/red-ui/src/app/modules/file-preview/components/annotation-details/annotation-details.component.ts b/apps/red-ui/src/app/modules/file-preview/components/annotation-details/annotation-details.component.ts index 0f30fa6ea..6f9818d0d 100644 --- a/apps/red-ui/src/app/modules/file-preview/components/annotation-details/annotation-details.component.ts +++ b/apps/red-ui/src/app/modules/file-preview/components/annotation-details/annotation-details.component.ts @@ -14,7 +14,7 @@ interface Engine { readonly translateParams?: Record; } -export const Engines = { +const Engines = { DICTIONARY: 'DICTIONARY', NER: 'NER', RULE: 'RULE', @@ -29,7 +29,6 @@ function isBasedOn(annotation: AnnotationWrapper, engineName: EngineName) { } const changesProperties: KeysOf[] = [ - 'hasBeenAdded', 'hasBeenResized', 'hasBeenRecategorized', 'hasLegalBasisChanged', diff --git a/apps/red-ui/src/app/translations/annotation-changes-translations.ts b/apps/red-ui/src/app/translations/annotation-changes-translations.ts index 59c0fee42..cdc0a534f 100644 --- a/apps/red-ui/src/app/translations/annotation-changes-translations.ts +++ b/apps/red-ui/src/app/translations/annotation-changes-translations.ts @@ -3,7 +3,6 @@ import { AnnotationWrapper } from '@models/file/annotation.wrapper'; import { KeysOf } from '@iqser/common-ui/lib/utils'; export const annotationChangesTranslations: { [key in KeysOf]?: string } = { - hasBeenAdded: _('annotation-changes.added'), hasBeenResized: _('annotation-changes.resized'), hasBeenRecategorized: _('annotation-changes.recategorized'), hasLegalBasisChanged: _('annotation-changes.legal-basis'), diff --git a/apps/red-ui/src/assets/i18n/redact/de.json b/apps/red-ui/src/assets/i18n/redact/de.json index 08229e93f..49e6d35a0 100644 --- a/apps/red-ui/src/assets/i18n/redact/de.json +++ b/apps/red-ui/src/assets/i18n/redact/de.json @@ -340,7 +340,6 @@ "undo": "Rückgängig" }, "annotation-changes": { - "added": "", "forced-hint": "Hint forced", "forced-redaction": "Redaction forced", "header": "Manuelle Änderungen:", @@ -1262,6 +1261,15 @@ "heading": "Edit entity" } }, + "entity": { + "info": { + "actions": { + "revert": "Revert", + "save": "Save changes" + }, + "heading": "Edit entity" + } + }, "error": { "deleted-entity": { "dossier": { diff --git a/apps/red-ui/src/assets/i18n/redact/en.json b/apps/red-ui/src/assets/i18n/redact/en.json index 26b5abaf0..705737a51 100644 --- a/apps/red-ui/src/assets/i18n/redact/en.json +++ b/apps/red-ui/src/assets/i18n/redact/en.json @@ -340,7 +340,6 @@ "undo": "Undo" }, "annotation-changes": { - "added": "Redaction/Hint added", "forced-hint": "Hint forced", "forced-redaction": "Redaction forced", "header": "Manual changes:", diff --git a/apps/red-ui/src/assets/i18n/scm/de.json b/apps/red-ui/src/assets/i18n/scm/de.json index a5fa1964d..8629398d4 100644 --- a/apps/red-ui/src/assets/i18n/scm/de.json +++ b/apps/red-ui/src/assets/i18n/scm/de.json @@ -340,7 +340,6 @@ "undo": "Rückgängig" }, "annotation-changes": { - "added": "", "forced-hint": "Hint forced", "forced-redaction": "Annotation forced", "header": "Manuelle Änderungen:", @@ -1262,6 +1261,15 @@ "heading": "Edit entity" } }, + "entity": { + "info": { + "actions": { + "revert": "Revert", + "save": "Save changes" + }, + "heading": "Edit entity" + } + }, "error": { "deleted-entity": { "dossier": { diff --git a/apps/red-ui/src/assets/i18n/scm/en.json b/apps/red-ui/src/assets/i18n/scm/en.json index 61e679829..1374e8173 100644 --- a/apps/red-ui/src/assets/i18n/scm/en.json +++ b/apps/red-ui/src/assets/i18n/scm/en.json @@ -340,7 +340,6 @@ "undo": "Undo" }, "annotation-changes": { - "added": "Redaction/Hint added", "forced-hint": "Hint forced", "forced-redaction": "Annotation forced", "header": "Manual changes:", diff --git a/libs/red-domain/src/lib/redaction-log/types.ts b/libs/red-domain/src/lib/redaction-log/types.ts index e1cf69f1a..c35068387 100644 --- a/libs/red-domain/src/lib/redaction-log/types.ts +++ b/libs/red-domain/src/lib/redaction-log/types.ts @@ -11,7 +11,6 @@ export const LogEntryEngines = { export type LogEntryEngine = ValuesOf; export const ManualRedactionTypes = { - ADD: 'ADD', ADD_LOCALLY: 'ADD_LOCALLY', ADD_TO_DICTIONARY: 'ADD_TO_DICTIONARY', REMOVE: 'REMOVE',