From 4bd636887cb08c49feafd2362dd5c06ae200ad4c Mon Sep 17 00:00:00 2001
From: Valentin Mihai <valentin@devplant.ro>
Date: Thu, 9 Mar 2023 14:57:29 +0200
Subject: [PATCH] RED-6174 - added default values for environment variables in
 case they are not available

---
 .../src/app/services/notifications.service.ts       | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/apps/red-ui/src/app/services/notifications.service.ts b/apps/red-ui/src/app/services/notifications.service.ts
index 42cb282be..399cc5734 100644
--- a/apps/red-ui/src/app/services/notifications.service.ts
+++ b/apps/red-ui/src/app/services/notifications.service.ts
@@ -13,6 +13,10 @@ import dayjs from 'dayjs';
 
 const INCLUDE_SEEN = false;
 
+const AVAILABLE_NOTIFICATIONS_DAYS = 30;
+const AVAILABLE_OLD_NOTIFICATIONS_MINUTES = 60;
+const NOTIFICATIONS_THRESHOLD = 1000;
+
 @Injectable({
     providedIn: 'root',
 })
@@ -81,14 +85,17 @@ export class NotificationsService extends EntitiesService<INotification, Notific
             }
 
             const creationDate = dayjs(n.creationDate);
-            if (todayDate.diff(creationDate, 'day') <= this.#config.AVAILABLE_NOTIFICATIONS_DAYS) {
+            if (todayDate.diff(creationDate, 'day') <= (this.#config.AVAILABLE_NOTIFICATIONS_DAYS ?? AVAILABLE_NOTIFICATIONS_DAYS)) {
                 return true;
             }
 
-            return todayDate.diff(readDate, 'minute') <= this.#config.AVAILABLE_OLD_NOTIFICATIONS_MINUTES;
+            return (
+                todayDate.diff(readDate, 'minute') <=
+                (this.#config.AVAILABLE_OLD_NOTIFICATIONS_MINUTES ?? AVAILABLE_OLD_NOTIFICATIONS_MINUTES)
+            );
         });
 
-        return notifications.slice(0, this.#config.NOTIFICATIONS_THRESHOLD);
+        return notifications.slice(0, this.#config.NOTIFICATIONS_THRESHOLD ?? NOTIFICATIONS_THRESHOLD);
     }
 
     #loadNotificationsIfChanged(): Observable<Notification[]> {