From 60664a56f2bdb00065a376c0802c8bf81e5c319d Mon Sep 17 00:00:00 2001
From: Nicoleta Panaghiu <nicoleta.panaghiu.ext@knecon.com>
Date: Tue, 19 Dec 2023 11:32:39 +0200
Subject: [PATCH] RED-7762: fixed comment and empty field placeholders.

---
 .../edit-redaction-dialog.component.html               | 10 +++-------
 .../edit-redaction-dialog.component.ts                 |  8 ++++++--
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/apps/red-ui/src/app/modules/file-preview/dialogs/edit-redaction-dialog/edit-redaction-dialog.component.html b/apps/red-ui/src/app/modules/file-preview/dialogs/edit-redaction-dialog/edit-redaction-dialog.component.html
index 3649764a1..8292549f3 100644
--- a/apps/red-ui/src/app/modules/file-preview/dialogs/edit-redaction-dialog/edit-redaction-dialog.component.html
+++ b/apps/red-ui/src/app/modules/file-preview/dialogs/edit-redaction-dialog/edit-redaction-dialog.component.html
@@ -47,7 +47,7 @@
                     <mat-form-field>
                         <mat-select
                             [placeholder]="
-                                isBulkEdit || !hideReasonPlaceholder ? ('edit-redaction.dialog.content.unchanged' | translate) : ''
+                                isBulkEdit && !hideReasonPlaceholder ? ('edit-redaction.dialog.content.unchanged' | translate) : ''
                             "
                             class="full-width"
                             formControlName="reason"
@@ -67,7 +67,7 @@
                 <div class="iqser-input-group w-450">
                     <label [translate]="'edit-redaction.dialog.content.legal-basis'"></label>
                     <input
-                        [placeholder]="isBulkEdit || !hideReasonPlaceholder ? ('edit-redaction.dialog.content.unchanged' | translate) : ''"
+                        [placeholder]="isBulkEdit && !hideReasonPlaceholder ? ('edit-redaction.dialog.content.unchanged' | translate) : ''"
                         [value]="form.controls.reason.value?.legalBasis"
                         disabled
                         type="text"
@@ -100,11 +100,7 @@
             <div class="iqser-input-group w-450">
                 <label [translate]="'edit-redaction.dialog.content.comment'"></label>
                 <textarea
-                    [placeholder]="
-                        !isBulkEdit
-                            ? ('edit-redaction.dialog.content.comment-placeholder' | translate)
-                            : ('edit-redaction.dialog.content.unchanged' | translate)
-                    "
+                    [placeholder]="'edit-redaction.dialog.content.comment-placeholder' | translate"
                     formControlName="comment"
                     iqserHasScrollbar
                     name="comment"
diff --git a/apps/red-ui/src/app/modules/file-preview/dialogs/edit-redaction-dialog/edit-redaction-dialog.component.ts b/apps/red-ui/src/app/modules/file-preview/dialogs/edit-redaction-dialog/edit-redaction-dialog.component.ts
index 0fba8ed51..a51e2d1c9 100644
--- a/apps/red-ui/src/app/modules/file-preview/dialogs/edit-redaction-dialog/edit-redaction-dialog.component.ts
+++ b/apps/red-ui/src/app/modules/file-preview/dialogs/edit-redaction-dialog/edit-redaction-dialog.component.ts
@@ -83,11 +83,11 @@ export class EditRedactionDialogComponent
     }
 
     get hideReasonPlaceholder() {
-        return this.hasTypeChanged && this.isRedactBasedType;
+        return (this.hasTypeChanged && this.isRedactBasedType) || this.#isFieldEmpty('legalBasis');
     }
 
     get hideParagraphPlaceholder() {
-        return this.form.controls.section.value !== this.initialFormValue['section'];
+        return this.form.controls.section.value !== this.initialFormValue['section'] || this.#isFieldEmpty('section');
     }
 
     get hiddenReason() {
@@ -184,4 +184,8 @@ export class EditRedactionDialogComponent
             value: new FormControl<string>(this.allRectangles ? this.data.annotations[0].value : null),
         });
     }
+
+    #isFieldEmpty(field: string) {
+        return this.data.annotations.every(annotation => !annotation[field].length);
+    }
 }