From 31dbe37eee36fc2174e531f0a2e8d3fae86bf5ae Mon Sep 17 00:00:00 2001
From: Valentin Mihai <valentin@devplant.ro>
Date: Fri, 25 Mar 2022 11:19:04 +0200
Subject: [PATCH 1/2] Added multiple ids needed for tests

---
 .../src/app/modules/dossier-overview/config.service.ts   | 1 +
 .../add-dossier-dialog/add-dossier-dialog.component.html | 2 +-
 .../edit-dossier-dialog.component.html                   | 3 ++-
 .../edit-dossier-team/edit-dossier-team.component.html   | 9 +++++----
 .../edit-dossier-general-info.component.html             | 1 +
 .../initials-avatar/initials-avatar.component.html       | 2 +-
 6 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/apps/red-ui/src/app/modules/dossier-overview/config.service.ts b/apps/red-ui/src/app/modules/dossier-overview/config.service.ts
index d1e3beb30..1e1f189f4 100644
--- a/apps/red-ui/src/app/modules/dossier-overview/config.service.ts
+++ b/apps/red-ui/src/app/modules/dossier-overview/config.service.ts
@@ -106,6 +106,7 @@ export class ConfigService {
     actionConfig(dossierId: string, disabled$: Observable<boolean>): List<ActionConfig> {
         return [
             {
+                id: 'editDossier',
                 label: this._translateService.instant('dossier-overview.header-actions.edit'),
                 action: $event => this._openEditDossierDialog($event, dossierId),
                 icon: 'iqser:edit',
diff --git a/apps/red-ui/src/app/modules/dossier/dialogs/add-dossier-dialog/add-dossier-dialog.component.html b/apps/red-ui/src/app/modules/dossier/dialogs/add-dossier-dialog/add-dossier-dialog.component.html
index 58111e530..75ef2d64b 100644
--- a/apps/red-ui/src/app/modules/dossier/dialogs/add-dossier-dialog/add-dossier-dialog.component.html
+++ b/apps/red-ui/src/app/modules/dossier/dialogs/add-dossier-dialog/add-dossier-dialog.component.html
@@ -104,7 +104,7 @@
                 [label]="'add-dossier-dialog.actions.save-and-add-members' | translate"
                 [type]="iconButtonTypes.dark"
                 icon="red:assign"
-                id="createDossierEditTeamButton"
+                [id]="'createDossierEditTeamButton'"
             ></iqser-icon-button>
         </div>
     </form>
diff --git a/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/edit-dossier-dialog.component.html b/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/edit-dossier-dialog.component.html
index 8e477fcbf..b785bfdcc 100644
--- a/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/edit-dossier-dialog.component.html
+++ b/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/edit-dossier-dialog.component.html
@@ -1,5 +1,5 @@
 <section *ngIf="dossier$ | async as dossier" class="dialog">
-    <div class="dialog-header heading-l">
+    <div class="dialog-header heading-l" id="editDossierHeader">
         {{ 'edit-dossier-dialog.header' | translate: { dossierName: dossier.dossierName } }}
     </div>
 
@@ -61,6 +61,7 @@
                     [disabled]="disabled || !valid || !changed"
                     [label]="'edit-dossier-dialog.actions.save-and-close' | translate"
                     [type]="iconButtonTypes.dark"
+                    id="saveAndClose"
                 >
                 </iqser-icon-button>
 
diff --git a/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/edit-dossier-team/edit-dossier-team.component.html b/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/edit-dossier-team/edit-dossier-team.component.html
index a098fb74b..64f0494bf 100644
--- a/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/edit-dossier-team/edit-dossier-team.component.html
+++ b/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/edit-dossier-team/edit-dossier-team.component.html
@@ -3,7 +3,7 @@
         <mat-form-field floatLabel="always">
             <mat-label>{{ 'assign-dossier-owner.dialog.single-user' | translate }}</mat-label>
             <mat-select formControlName="owner" id="editDossierOwnerSelect">
-                <mat-option *ngFor="let userId of ownersSelectOptions" [value]="userId">
+                <mat-option *ngFor="let userId of ownersSelectOptions; let index = index" [value]="userId" [id]="'mat-option-' + index">
                     {{ userId | name }}
                 </mat-option>
             </mat-select>
@@ -11,7 +11,7 @@
     </div>
 
     <ng-container *ngIf="selectedApproversList.length">
-        <div class="all-caps-label mt-16" translate="assign-dossier-owner.dialog.approvers"></div>
+        <div class="all-caps-label mt-16" translate="assign-dossier-owner.dialog.approvers" id="approversLabel"></div>
         <redaction-team-members
             (remove)="toggleSelected($event)"
             [canAdd]="false"
@@ -25,7 +25,7 @@
     </ng-container>
 
     <ng-container *ngIf="(selectedReviewers$ | async)?.length">
-        <div class="all-caps-label mt-16" translate="assign-dossier-owner.dialog.reviewers"></div>
+        <div class="all-caps-label mt-16" translate="assign-dossier-owner.dialog.reviewers" id="reviewersLabel"></div>
         <redaction-team-members
             (remove)="toggleSelected($event)"
             [canAdd]="false"
@@ -54,8 +54,9 @@
         <div class="members-list">
             <div
                 (click)="!isOwner(userId) && toggleSelected(userId)"
-                *ngFor="let userId of membersSelectOptions"
+                *ngFor="let userId of membersSelectOptions; let index = index"
                 [class.selected]="isMemberSelected(userId)"
+                [id]="'member-' + index"
             >
                 <redaction-initials-avatar [user]="userId" [withName]="true" size="large"></redaction-initials-avatar>
                 <div class="actions">
diff --git a/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/general-info/edit-dossier-general-info.component.html b/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/general-info/edit-dossier-general-info.component.html
index f79cdc91e..f2305bd2a 100644
--- a/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/general-info/edit-dossier-general-info.component.html
+++ b/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/general-info/edit-dossier-general-info.component.html
@@ -82,6 +82,7 @@
             [label]="'dossier-listing.delete.action' | translate"
             [type]="iconButtonTypes.dark"
             icon="iqser:trash"
+            id="deleteDossier"
         ></iqser-icon-button>
 
         <iqser-icon-button
diff --git a/apps/red-ui/src/app/modules/shared/components/initials-avatar/initials-avatar.component.html b/apps/red-ui/src/app/modules/shared/components/initials-avatar/initials-avatar.component.html
index 027c9a0dd..798d49248 100644
--- a/apps/red-ui/src/app/modules/shared/components/initials-avatar/initials-avatar.component.html
+++ b/apps/red-ui/src/app/modules/shared/components/initials-avatar/initials-avatar.component.html
@@ -6,7 +6,7 @@
     >
         {{ _user | name: { showInitials: true } }}
     </div>
-    <div *ngIf="withName" [class.disabled]="disabled" class="clamp-1 username">
+    <div *ngIf="withName" [class.disabled]="disabled" class="clamp-1 username" id="avatarUsername">
         {{ userName }}
     </div>
 </div>

From d9daa41b07ad13fb38a691b54c34a8da60c65df3 Mon Sep 17 00:00:00 2001
From: Valentin Mihai <valentin@devplant.ro>
Date: Sun, 27 Mar 2022 13:06:43 +0300
Subject: [PATCH 2/2] added more ids for tests

---
 .../edit-dossier-dialog/edit-dossier-dialog.component.html  | 4 ++--
 .../edit-dossier-team/edit-dossier-team.component.html      | 6 +++++-
 libs/common-ui                                              | 2 +-
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/edit-dossier-dialog.component.html b/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/edit-dossier-dialog.component.html
index b785bfdcc..84b40d777 100644
--- a/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/edit-dossier-dialog.component.html
+++ b/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/edit-dossier-dialog.component.html
@@ -61,11 +61,11 @@
                     [disabled]="disabled || !valid || !changed"
                     [label]="'edit-dossier-dialog.actions.save-and-close' | translate"
                     [type]="iconButtonTypes.dark"
-                    id="saveAndClose"
+                    [id]="'saveAndClose'"
                 >
                 </iqser-icon-button>
 
-                <div (click)="revert()" class="all-caps-label cancel" translate="edit-dossier-dialog.actions.revert"></div>
+                <div (click)="revert()" id="revert" class="all-caps-label cancel" translate="edit-dossier-dialog.actions.revert"></div>
             </div>
         </div>
     </div>
diff --git a/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/edit-dossier-team/edit-dossier-team.component.html b/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/edit-dossier-team/edit-dossier-team.component.html
index 64f0494bf..f5e2ab2ff 100644
--- a/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/edit-dossier-team/edit-dossier-team.component.html
+++ b/apps/red-ui/src/app/modules/dossier/dialogs/edit-dossier-dialog/edit-dossier-team/edit-dossier-team.component.html
@@ -61,7 +61,11 @@
                 <redaction-initials-avatar [user]="userId" [withName]="true" size="large"></redaction-initials-avatar>
                 <div class="actions">
                     <div (click)="toggleApprover(userId, $event)" *ngIf="!isOwner(userId)" class="make-approver">
-                        <iqser-round-checkbox [active]="isApprover(userId)" class="mr-8"></iqser-round-checkbox>
+                        <iqser-round-checkbox
+                            [active]="isApprover(userId)"
+                            class="mr-8"
+                            [id]="'round-checkbox-' + index"
+                        ></iqser-round-checkbox>
                         <span translate="assign-dossier-owner.dialog.make-approver"></span>
                     </div>
                     <mat-icon *ngIf="!isOwner(userId)" svgIcon="iqser:check"></mat-icon>
diff --git a/libs/common-ui b/libs/common-ui
index 9f2cdbe49..f3c088af0 160000
--- a/libs/common-ui
+++ b/libs/common-ui
@@ -1 +1 @@
-Subproject commit 9f2cdbe490c6a4bebbc7593895fe8999d79c634f
+Subproject commit f3c088af0368ae55195541e3793c44836bb0f481