From 9333bfc5934c0b0120eca9b0db68fd858d288726 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adina=20=C8=9Aeudan?= <adina@devplant.ro>
Date: Tue, 6 Jul 2021 14:55:17 +0300
Subject: [PATCH] Button type enum

---
 .../scroll-button/scroll-button.component.html | 10 +++++++---
 .../scroll-button/scroll-button.component.ts   | 18 +++++++++++++-----
 2 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/apps/red-ui/src/app/modules/dossier/components/scroll-button/scroll-button.component.html b/apps/red-ui/src/app/modules/dossier/components/scroll-button/scroll-button.component.html
index f065b3cba..0ca366bbc 100644
--- a/apps/red-ui/src/app/modules/dossier/components/scroll-button/scroll-button.component.html
+++ b/apps/red-ui/src/app/modules/dossier/components/scroll-button/scroll-button.component.html
@@ -1,10 +1,14 @@
-<button (click)="scroll('top')" [hidden]="!showScroll('top')" class="scroll-button top pointer">
+<button
+    (click)="scroll(ButtonType.TOP)"
+    [hidden]="!showScroll(ButtonType.TOP)"
+    class="scroll-button top pointer"
+>
     <mat-icon svgIcon="red:arrow-down-o"></mat-icon>
 </button>
 
 <button
-    (click)="scroll('bottom')"
-    [hidden]="!showScroll('bottom')"
+    (click)="scroll(ButtonType.BOTTOM)"
+    [hidden]="!showScroll(ButtonType.BOTTOM)"
     class="scroll-button bottom pointer"
 >
     <mat-icon svgIcon="red:arrow-down-o"></mat-icon>
diff --git a/apps/red-ui/src/app/modules/dossier/components/scroll-button/scroll-button.component.ts b/apps/red-ui/src/app/modules/dossier/components/scroll-button/scroll-button.component.ts
index 23d3d4d1b..a5ddb6665 100644
--- a/apps/red-ui/src/app/modules/dossier/components/scroll-button/scroll-button.component.ts
+++ b/apps/red-ui/src/app/modules/dossier/components/scroll-button/scroll-button.component.ts
@@ -1,25 +1,33 @@
 import { Component, HostListener, Input } from '@angular/core';
 import { CdkVirtualScrollViewport } from '@angular/cdk/scrolling';
 
+enum ButtonType {
+    TOP = 'top',
+    BOTTOM = 'bottom'
+}
+
 @Component({
     selector: 'redaction-scroll-button',
     templateUrl: './scroll-button.component.html',
     styleUrls: ['./scroll-button.component.scss']
 })
 export class ScrollButtonComponent {
+    ButtonType = ButtonType;
+
     @Input()
     scrollViewport: CdkVirtualScrollViewport;
     @Input()
     itemSize: number;
 
-    scroll(type: 'top' | 'bottom'): void {
+    scroll(type: ButtonType): void {
         const viewportSize =
-            (this.scrollViewport?.getViewportSize() - this.itemSize) * (type === 'top' ? -1 : 1);
+            (this.scrollViewport?.getViewportSize() - this.itemSize) *
+            (type === ButtonType.TOP ? -1 : 1);
         const scrollOffset = this.scrollViewport?.measureScrollOffset('top');
         this.scrollViewport?.scrollToOffset(scrollOffset + viewportSize, 'smooth');
     }
 
-    showScroll(type: 'top' | 'bottom'): boolean {
+    showScroll(type: ButtonType): boolean {
         const reachedEnd = this.scrollViewport?.measureScrollOffset(type) === 0;
         const scrollSize = this.scrollViewport?.getDataLength() * this.itemSize;
         const scrollIsNeeded = this.scrollViewport?.getViewportSize() < scrollSize;
@@ -30,9 +38,9 @@ export class ScrollButtonComponent {
     @HostListener('document:keyup', ['$event'])
     spaceAndPageDownScroll(event: KeyboardEvent): void {
         if (['Space', 'PageDown'].includes(event.code)) {
-            this.scroll('bottom');
+            this.scroll(ButtonType.BOTTOM);
         } else if (['PageUp'].includes(event.code)) {
-            this.scroll('top');
+            this.scroll(ButtonType.TOP);
         }
     }
 }