Marmelator/red-ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1.4k Wiki Activity

RED-10396 - undefined checks

Browse Source
This commit is contained in:
Valentin Mihai 2024-11-20 11:55:07 +02:00
parent bd66f39474
commit 9e71ae3fa8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apps/red-ui/src/app/modules/file-preview/services/file-data.service.ts
View File

@ -270,7 +270,7 @@ export class FileDataService extends EntitiesService<AnnotationWrapper, Annotati
const viewTime = timestampOf(viewedPage.viewedTime) - DELTA_VIEW_TIME; const viewTime = timestampOf(viewedPage.viewedTime) - DELTA_VIEW_TIME;
let changeOccurredAfterPageIsViewed = lastChange && timestampOf(lastChange.dateTime) > viewTime; let changeOccurredAfterPageIsViewed = lastChange && timestampOf(lastChange.dateTime) > viewTime;
if (changeOccurredAfterPageIsViewed) { if (changeOccurredAfterPageIsViewed !== undefined) {
this.#markPageAsUnseenIfNeeded(viewedPage, lastChange.dateTime); this.#markPageAsUnseenIfNeeded(viewedPage, lastChange.dateTime);
return lastChange?.type; return lastChange?.type;
} }
@ -281,7 +281,7 @@ export class FileDataService extends EntitiesService<AnnotationWrapper, Annotati
const processedTime = lastManualChange?.processedDate; const processedTime = lastManualChange?.processedDate;
changeOccurredAfterPageIsViewed = processedTime && timestampOf(processedTime) > viewTime; changeOccurredAfterPageIsViewed = processedTime && timestampOf(processedTime) > viewTime;
if (changeOccurredAfterPageIsViewed) { if (changeOccurredAfterPageIsViewed !== undefined) {
this.#markPageAsUnseenIfNeeded(viewedPage, processedTime); this.#markPageAsUnseenIfNeeded(viewedPage, processedTime);
return ChangeTypes.CHANGED; return ChangeTypes.CHANGED;
} }