From 9ed4a683488c227b3938f2e1bf0a06d4de67db5f Mon Sep 17 00:00:00 2001
From: Valentin Mihai <valentin@devplant.ro>
Date: Sat, 12 Feb 2022 00:22:17 +0200
Subject: [PATCH] WIP on refactoring help mode logic

---
 .../app/components/base-screen/base-screen.component.html | 8 ++------
 .../dossier-details/dossier-details.component.html        | 7 +------
 .../annotation-actions/annotation-actions.component.html  | 5 -----
 .../components/file-workload/file-workload.component.html | 3 +--
 .../user-management/user-management.component.html        | 1 -
 .../components/view-switch/view-switch.component.html     | 3 ---
 .../components/file-actions/file-actions.component.html   | 2 +-
 .../buttons/user-button/user-button.component.html        | 2 +-
 .../simple-doughnut-chart.component.html                  | 2 +-
 .../components/team-members/team-members.component.html   | 1 -
 libs/common-ui                                            | 2 +-
 11 files changed, 8 insertions(+), 28 deletions(-)

diff --git a/apps/red-ui/src/app/components/base-screen/base-screen.component.html b/apps/red-ui/src/app/components/base-screen/base-screen.component.html
index 969a9a4ca..49901094f 100644
--- a/apps/red-ui/src/app/components/base-screen/base-screen.component.html
+++ b/apps/red-ui/src/app/components/base-screen/base-screen.component.html
@@ -4,7 +4,7 @@
     <div *ngIf="!currentUser.isUser" class="menu-placeholder"></div>
 
     <div *ngIf="currentUser.isUser" class="menu flex-2 visible-lg breadcrumbs-container">
-        <redaction-breadcrumbs iqserHelpMode="navigate-in-breadcrumbs"></redaction-breadcrumbs>
+        <redaction-breadcrumbs></redaction-breadcrumbs>
     </div>
 
     <div class="logo">
@@ -25,11 +25,7 @@
 
             <redaction-notifications iqserHelpMode="open-notifications"></redaction-notifications>
         </div>
-        <redaction-user-button
-            [matMenuTriggerFor]="userMenu"
-            [userId]="currentUser.id"
-            iqserHelpMode="open-usermenu"
-        ></redaction-user-button>
+        <redaction-user-button [matMenuTriggerFor]="userMenu" [userId]="currentUser.id"></redaction-user-button>
 
         <mat-menu #userMenu="matMenu" xPosition="before">
             <ng-container *ngFor="let item of userMenuItems; trackBy: trackByName">
diff --git a/apps/red-ui/src/app/modules/dossier/screens/dossier-overview/components/dossier-details/dossier-details.component.html b/apps/red-ui/src/app/modules/dossier/screens/dossier-overview/components/dossier-details/dossier-details.component.html
index 71ffaaf40..56cea7f15 100644
--- a/apps/red-ui/src/app/modules/dossier/screens/dossier-overview/components/dossier-details/dossier-details.component.html
+++ b/apps/red-ui/src/app/modules/dossier/screens/dossier-overview/components/dossier-details/dossier-details.component.html
@@ -23,7 +23,6 @@
                     [tooltip]="'dossier-details.edit-owner' | translate"
                     class="ml-14"
                     icon="iqser:edit"
-                    iqserHelpMode="edit-dossier-owner"
                     tooltipPosition="below"
                 ></iqser-circle-button>
             </ng-container>
@@ -46,11 +45,7 @@
             ></redaction-simple-doughnut-chart>
         </div>
 
-        <div
-            *ngIf="stats.hasFiles && needsWorkFilters$ | async as filters"
-            class="mt-24 legend pb-32"
-            iqserHelpMode="filter-for-editing-notes"
-        >
+        <div *ngIf="stats.hasFiles && needsWorkFilters$ | async as filters" class="mt-24 legend pb-32">
             <div
                 (click)="filterService.toggleFilter('needsWorkFilters', filter.id)"
                 *ngFor="let filter of filters"
diff --git a/apps/red-ui/src/app/modules/dossier/screens/file-preview-screen/components/annotation-actions/annotation-actions.component.html b/apps/red-ui/src/app/modules/dossier/screens/file-preview-screen/components/annotation-actions/annotation-actions.component.html
index 27bdb3ffd..2c59f89e2 100644
--- a/apps/red-ui/src/app/modules/dossier/screens/file-preview-screen/components/annotation-actions/annotation-actions.component.html
+++ b/apps/red-ui/src/app/modules/dossier/screens/file-preview-screen/components/annotation-actions/annotation-actions.component.html
@@ -42,7 +42,6 @@
             [tooltip]="'annotation-actions.edit-reason.label' | translate"
             [type]="buttonType"
             icon="iqser:edit"
-            iqserHelpMode="redaction-edit-reason"
         ></iqser-circle-button>
 
         <iqser-circle-button
@@ -52,7 +51,6 @@
             [tooltip]="'annotation-actions.accept-recommendation.label' | translate"
             [type]="buttonType"
             icon="iqser:check"
-            iqserHelpMode="recommendation-accept-or-reject"
         ></iqser-circle-button>
 
         <iqser-circle-button
@@ -143,7 +141,6 @@
             [tooltip]="'annotation-actions.remove-annotation.remove-from-dict' | translate"
             [type]="buttonType"
             icon="red:remove-from-dict"
-            iqserHelpMode="redaction-remove-from-dictionary"
         ></iqser-circle-button>
 
         <iqser-circle-button
@@ -153,7 +150,6 @@
             [tooltip]="'annotation-actions.remove-annotation.false-positive' | translate"
             [type]="buttonType"
             icon="red:thumb-down"
-            iqserHelpMode="redaction-false-positive"
         ></iqser-circle-button>
 
         <iqser-circle-button
@@ -163,7 +159,6 @@
             [tooltip]="'annotation-actions.remove-annotation.only-here' | translate"
             [type]="buttonType"
             icon="iqser:trash"
-            iqserHelpMode="redaction-remove-only-here"
         ></iqser-circle-button>
     </ng-container>
 </div>
diff --git a/apps/red-ui/src/app/modules/dossier/screens/file-preview-screen/components/file-workload/file-workload.component.html b/apps/red-ui/src/app/modules/dossier/screens/file-preview-screen/components/file-workload/file-workload.component.html
index 176f71a18..68d115abd 100644
--- a/apps/red-ui/src/app/modules/dossier/screens/file-preview-screen/components/file-workload/file-workload.component.html
+++ b/apps/red-ui/src/app/modules/dossier/screens/file-preview-screen/components/file-workload/file-workload.component.html
@@ -16,7 +16,6 @@
                 (click)="multiSelectService.activate()"
                 *ngIf="(multiSelectService.enabled$ | async) && (multiSelectInactive$ | async)"
                 class="all-caps-label primary pointer"
-                iqserHelpMode="bulk-select-annotations"
                 translate="file-preview.tabs.annotations.select"
             ></div>
 
@@ -24,7 +23,7 @@
                 [actionsTemplate]="annotationFilterActionTemplate"
                 [primaryFiltersSlug]="'primaryFilters'"
                 [secondaryFiltersSlug]="'secondaryFilters'"
-                iqserHelpMode="workload-filter"
+                xw
             ></iqser-popup-filter>
         </div>
     </div>
diff --git a/apps/red-ui/src/app/modules/dossier/screens/file-preview-screen/components/user-management/user-management.component.html b/apps/red-ui/src/app/modules/dossier/screens/file-preview-screen/components/user-management/user-management.component.html
index 53669e553..7466ecbd9 100644
--- a/apps/red-ui/src/app/modules/dossier/screens/file-preview-screen/components/user-management/user-management.component.html
+++ b/apps/red-ui/src/app/modules/dossier/screens/file-preview-screen/components/user-management/user-management.component.html
@@ -34,7 +34,6 @@
             *ngIf="(canAssignOrUnassign$ | async) && !!file.assignee"
             [tooltip]="assignTooltip$ | async"
             icon="iqser:edit"
-            iqserHelpMode="assign-reviewer"
             tooltipPosition="below"
         ></iqser-circle-button>
 
diff --git a/apps/red-ui/src/app/modules/dossier/screens/file-preview-screen/components/view-switch/view-switch.component.html b/apps/red-ui/src/app/modules/dossier/screens/file-preview-screen/components/view-switch/view-switch.component.html
index c3836a11a..8d230bc9f 100644
--- a/apps/red-ui/src/app/modules/dossier/screens/file-preview-screen/components/view-switch/view-switch.component.html
+++ b/apps/red-ui/src/app/modules/dossier/screens/file-preview-screen/components/view-switch/view-switch.component.html
@@ -4,7 +4,6 @@
         [class.active]="viewModeService.isStandard"
         [matTooltip]="'file-preview.standard-tooltip' | translate"
         class="red-tab"
-        iqserHelpMode="standard-view"
     >
         {{ 'file-preview.standard' | translate }}
     </button>
@@ -15,7 +14,6 @@
         [disabled]="(canSwitchToDeltaView$ | async) === false"
         [matTooltip]="'file-preview.delta-tooltip' | translate"
         class="red-tab"
-        iqserHelpMode="delta-view"
     >
         {{ 'file-preview.delta' | translate }}
     </button>
@@ -26,7 +24,6 @@
         [disabled]="(canSwitchToRedactedView$ | async) === false"
         [matTooltip]="'file-preview.redacted-tooltip' | translate"
         class="red-tab"
-        iqserHelpMode="preview-view"
     >
         {{ 'file-preview.redacted' | translate }}
     </button>
diff --git a/apps/red-ui/src/app/modules/dossier/shared/components/file-actions/file-actions.component.html b/apps/red-ui/src/app/modules/dossier/shared/components/file-actions/file-actions.component.html
index a65863042..15dca9eca 100644
--- a/apps/red-ui/src/app/modules/dossier/shared/components/file-actions/file-actions.component.html
+++ b/apps/red-ui/src/app/modules/dossier/shared/components/file-actions/file-actions.component.html
@@ -16,7 +16,7 @@
 </ng-container>
 
 <ng-template #actions (longPress)="forceReanalysisAction($event)" redactionLongPress>
-    <div class="file-actions" iqserHelpMode="document-features">
+    <div class="file-actions">
         <redaction-expandable-file-actions
             [actions]="buttons"
             [buttonType]="buttonType"
diff --git a/apps/red-ui/src/app/modules/shared/components/buttons/user-button/user-button.component.html b/apps/red-ui/src/app/modules/shared/components/buttons/user-button/user-button.component.html
index f06bc81c8..961e85f48 100644
--- a/apps/red-ui/src/app/modules/shared/components/buttons/user-button/user-button.component.html
+++ b/apps/red-ui/src/app/modules/shared/components/buttons/user-button/user-button.component.html
@@ -1,4 +1,4 @@
-<button [class.overlay]="showDot" mat-button>
+<button [class.overlay]="showDot" mat-button iqserHelpMode="open-usermenu">
     <redaction-initials-avatar [user]="userService.currentUser$ | async" [withName]="true"></redaction-initials-avatar>
     <mat-icon svgIcon="iqser:arrow-down"></mat-icon>
 </button>
diff --git a/apps/red-ui/src/app/modules/shared/components/simple-doughnut-chart/simple-doughnut-chart.component.html b/apps/red-ui/src/app/modules/shared/components/simple-doughnut-chart/simple-doughnut-chart.component.html
index 8c5a1381e..fb0477d48 100644
--- a/apps/red-ui/src/app/modules/shared/components/simple-doughnut-chart/simple-doughnut-chart.component.html
+++ b/apps/red-ui/src/app/modules/shared/components/simple-doughnut-chart/simple-doughnut-chart.component.html
@@ -23,7 +23,7 @@
     </div>
 
     <div class="breakdown-container">
-        <div iqserHelpMode="filter-for-status">
+        <div>
             <div
                 (click)="val.key && selectValue(val.key)"
                 *ngFor="let val of config"
diff --git a/apps/red-ui/src/app/modules/shared/components/team-members/team-members.component.html b/apps/red-ui/src/app/modules/shared/components/team-members/team-members.component.html
index 8750487ff..634c061e4 100644
--- a/apps/red-ui/src/app/modules/shared/components/team-members/team-members.component.html
+++ b/apps/red-ui/src/app/modules/shared/components/team-members/team-members.component.html
@@ -26,7 +26,6 @@
         [type]="circleButtonTypes.primary"
         class="member"
         icon="iqser:plus"
-        iqserHelpMode="edit-dossier-member"
     ></iqser-circle-button>
 </div>
 
diff --git a/libs/common-ui b/libs/common-ui
index 0bab45847..24fbe8de3 160000
--- a/libs/common-ui
+++ b/libs/common-ui
@@ -1 +1 @@
-Subproject commit 0bab4584767b868f9d72a4de7ae23d0dd19daad3
+Subproject commit 24fbe8de35943e3cf8308093721ee4fd1044c00d