From 9fe6e7bcbd7d1b573d1f9f2578fae15731c955d7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adina=20=C8=9Aeudan?= <adina@devplant.ro>
Date: Fri, 2 Jul 2021 12:12:34 +0300
Subject: [PATCH] RED-1751: Disable autocomplete on comments & page exclusion

---
 .../dossier/components/comments/comments.component.html        | 1 +
 .../components/page-exclusion/page-exclusion.component.html    | 1 +
 .../buttons/circle-button/circle-button.component.html         | 2 +-
 .../buttons/circle-button/circle-button.component.ts           | 3 ++-
 .../input-with-action/input-with-action.component.html         | 3 ++-
 .../input-with-action/input-with-action.component.ts           | 1 +
 6 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/apps/red-ui/src/app/modules/dossier/components/comments/comments.component.html b/apps/red-ui/src/app/modules/dossier/components/comments/comments.component.html
index f5d650c2e..753fc3ebd 100644
--- a/apps/red-ui/src/app/modules/dossier/components/comments/comments.component.html
+++ b/apps/red-ui/src/app/modules/dossier/components/comments/comments.component.html
@@ -23,6 +23,7 @@
     *ngIf="permissionsService.canAddComment()"
     [form]="commentForm"
     [placeholder]="translateService.instant('comments.add-comment')"
+    autocomplete="off"
     icon="red:collapse"
     type="action"
     width="full"
diff --git a/apps/red-ui/src/app/modules/dossier/components/page-exclusion/page-exclusion.component.html b/apps/red-ui/src/app/modules/dossier/components/page-exclusion/page-exclusion.component.html
index 7ff791ae4..75d78db77 100644
--- a/apps/red-ui/src/app/modules/dossier/components/page-exclusion/page-exclusion.component.html
+++ b/apps/red-ui/src/app/modules/dossier/components/page-exclusion/page-exclusion.component.html
@@ -2,6 +2,7 @@
     <redaction-input-with-action
         (action)="excludePagesRange()"
         [form]="excludePagesForm"
+        autocomplete="off"
         hint="file-preview.tabs.exclude-pages.hint"
         icon="red:check"
         placeholder="file-preview.tabs.exclude-pages.input-placeholder"
diff --git a/apps/red-ui/src/app/modules/shared/components/buttons/circle-button/circle-button.component.html b/apps/red-ui/src/app/modules/shared/components/buttons/circle-button/circle-button.component.html
index 4b4921708..95bf94fb5 100644
--- a/apps/red-ui/src/app/modules/shared/components/buttons/circle-button/circle-button.component.html
+++ b/apps/red-ui/src/app/modules/shared/components/buttons/circle-button/circle-button.component.html
@@ -10,8 +10,8 @@
         [class.primary]="type === 'primary'"
         [class.warn]="type === 'warn'"
         [disabled]="disabled"
+        [type]="isSubmit ? 'submit' : 'button'"
         mat-icon-button
-        type="submit"
     >
         <mat-icon [svgIcon]="icon"></mat-icon>
     </button>
diff --git a/apps/red-ui/src/app/modules/shared/components/buttons/circle-button/circle-button.component.ts b/apps/red-ui/src/app/modules/shared/components/buttons/circle-button/circle-button.component.ts
index c3a6a61d6..bea9613ce 100644
--- a/apps/red-ui/src/app/modules/shared/components/buttons/circle-button/circle-button.component.ts
+++ b/apps/red-ui/src/app/modules/shared/components/buttons/circle-button/circle-button.component.ts
@@ -25,9 +25,10 @@ export class CircleButtonComponent implements OnInit {
     @Input() disabled = false;
     @Input() type: 'default' | 'primary' | 'warn' | 'dark-bg' = 'default';
     @Input() removeTooltip = false;
-    @Output() action = new EventEmitter<any>();
     @Input() size = 34;
     @Input() iconSize = 14;
+    @Input() isSubmit = false;
+    @Output() action = new EventEmitter<any>();
 
     @ViewChild(MatTooltip) matTooltip: MatTooltip;
 
diff --git a/apps/red-ui/src/app/modules/shared/components/input-with-action/input-with-action.component.html b/apps/red-ui/src/app/modules/shared/components/input-with-action/input-with-action.component.html
index 179797f41..e3af231a4 100644
--- a/apps/red-ui/src/app/modules/shared/components/input-with-action/input-with-action.component.html
+++ b/apps/red-ui/src/app/modules/shared/components/input-with-action/input-with-action.component.html
@@ -1,4 +1,4 @@
-<form [formGroup]="form">
+<form [autocomplete]="autocomplete" [formGroup]="form">
     <div [style.max-width]="computedWidth" [style.width]="computedWidth" class="red-input-group">
         <input
             [formControlName]="formControlName"
@@ -32,6 +32,7 @@
             *ngIf="type === 'action'"
             [disabled]="!hasContent"
             [icon]="icon"
+            [isSubmit]="true"
             [size]="25"
         >
         </redaction-circle-button>
diff --git a/apps/red-ui/src/app/modules/shared/components/input-with-action/input-with-action.component.ts b/apps/red-ui/src/app/modules/shared/components/input-with-action/input-with-action.component.ts
index 74381a21d..10e87ca2b 100644
--- a/apps/red-ui/src/app/modules/shared/components/input-with-action/input-with-action.component.ts
+++ b/apps/red-ui/src/app/modules/shared/components/input-with-action/input-with-action.component.ts
@@ -13,6 +13,7 @@ export class InputWithActionComponent {
     @Input() width: number | 'full' = 250;
     @Input() type: 'search' | 'action';
     @Input() icon: string;
+    @Input() autocomplete: 'on' | 'off' = 'on';
     @Output() action = new EventEmitter<any>();
 
     get formControlName(): 'query' | 'value' {