From 291a610d16e3feb73b48cb6fc2827333268cee05 Mon Sep 17 00:00:00 2001
From: George <george.balanesc.ext@knecon.com>
Date: Tue, 18 Jul 2023 18:45:30 +0300
Subject: [PATCH] DM-338, change status descriptions, fix last assignee being
 always empty on done step.

---
 .../user-management/user-management.component.html     |  1 -
 .../file-preview/file-preview-screen.component.html    |  7 ++-----
 .../file-preview/file-preview-screen.component.ts      | 10 ++++++++++
 apps/red-ui/src/assets/i18n/scm/en.json                |  4 ++--
 4 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/apps/red-ui/src/app/modules/file-preview/components/user-management/user-management.component.html b/apps/red-ui/src/app/modules/file-preview/components/user-management/user-management.component.html
index 47c452ef9..fbdfadff9 100644
--- a/apps/red-ui/src/app/modules/file-preview/components/user-management/user-management.component.html
+++ b/apps/red-ui/src/app/modules/file-preview/components/user-management/user-management.component.html
@@ -3,7 +3,6 @@
 <ng-container *ngIf="state.file() as file">
     <div class="all-caps-label mr-16 ml-8 label">
         {{ translations[file.workflowStatus] | translate }}
-        <span *ngIf="file.isUnderReview || file.isUnderApproval">{{ 'by' | translate }}:</span>
     </div>
 
     <iqser-initials-avatar
diff --git a/apps/red-ui/src/app/modules/file-preview/file-preview-screen.component.html b/apps/red-ui/src/app/modules/file-preview/file-preview-screen.component.html
index 4fae10d57..62353eda8 100644
--- a/apps/red-ui/src/app/modules/file-preview/file-preview-screen.component.html
+++ b/apps/red-ui/src/app/modules/file-preview/file-preview-screen.component.html
@@ -14,13 +14,10 @@
                 <div class="vertical-line"></div>
 
                 <div class="all-caps-label mr-16 ml-8 label">
-                    {{ 'file-preview.last-assignee' | translate : { status: file.workflowStatus } }}
+                    {{ 'file-preview.last-assignee' | translate }}
                 </div>
 
-                <iqser-initials-avatar
-                    [user]="file.isApproved ? file.lastApprover : file.lastReviewer"
-                    [withName]="true"
-                ></iqser-initials-avatar>
+                <iqser-initials-avatar [user]="lastAssignee()" [withName]="true"></iqser-initials-avatar>
             </ng-container>
 
             <div class="vertical-line"></div>
diff --git a/apps/red-ui/src/app/modules/file-preview/file-preview-screen.component.ts b/apps/red-ui/src/app/modules/file-preview/file-preview-screen.component.ts
index f7450a28c..64844499f 100644
--- a/apps/red-ui/src/app/modules/file-preview/file-preview-screen.component.ts
+++ b/apps/red-ui/src/app/modules/file-preview/file-preview-screen.component.ts
@@ -2,6 +2,7 @@ import {
     AfterViewInit,
     ChangeDetectorRef,
     Component,
+    computed,
     effect,
     ElementRef,
     HostListener,
@@ -21,6 +22,7 @@ import {
     HelpModeService,
     IConfirmationDialogData,
     IqserDialog,
+    IqserPermissionsService,
     LoadingService,
     Toaster,
 } from '@iqser/common-ui';
@@ -92,6 +94,7 @@ export class FilePreviewScreenComponent
     fullScreen = false;
     readonly fileId = this.state.fileId;
     readonly dossierId = this.state.dossierId;
+    readonly lastAssignee = computed(() => this.getLastAssignee());
     width: number;
 
     constructor(
@@ -101,6 +104,7 @@ export class FilePreviewScreenComponent
         readonly userPreferenceService: UserPreferenceService,
         readonly pdfProxyService: PdfProxyService,
         readonly configService: ConfigService,
+        private readonly _iqserPermissionsService: IqserPermissionsService,
         private readonly _listingService: AnnotationsListingService,
         private readonly _router: Router,
         private readonly _ngZone: NgZone,
@@ -195,6 +199,12 @@ export class FilePreviewScreenComponent
         );
     }
 
+    getLastAssignee() {
+        const { isApproved, lastReviewer, lastApprover } = this.state.file();
+        const isRss = this._iqserPermissionsService.has(this.roles.getRss);
+        return isApproved ? (isRss ? lastReviewer : lastApprover) : lastReviewer;
+    }
+
     deleteEarmarksOnViewChange$() {
         const isChangingFromEarmarksViewMode$ = this._viewModeService.viewMode$.pipe(
             pairwise(),
diff --git a/apps/red-ui/src/assets/i18n/scm/en.json b/apps/red-ui/src/assets/i18n/scm/en.json
index 0cd361f84..0df0808b5 100644
--- a/apps/red-ui/src/assets/i18n/scm/en.json
+++ b/apps/red-ui/src/assets/i18n/scm/en.json
@@ -841,7 +841,7 @@
     }
   },
   "dossier-overview": {
-    "approve": "Done",
+    "approve": "Move to Done",
     "approve-disabled": "File can only be approved once it has been analysed with the latest dictionaries and all suggestions have been processed.",
     "assign-approver": "Assign Approver",
     "assign-me": "Assign To Me",
@@ -1359,7 +1359,7 @@
       "convert": "Convert earmarks",
       "remove": "Remove earmarks"
     },
-    "last-assignee": "{status, select, APPROVED{Approved} UNDER_APPROVAL{Reviewed} other{Last reviewed}} by:",
+    "last-assignee": "Last Assignee",
     "no-data": {
       "title": "There have been no changes to this page."
     },