Pull request #247: Minor fixes

Merge in RED/ui from minor-fixes to master

* commit '1c953c5b2f98bca6a92217c2e13f1e2bed3aee97':
  tslint warnings
  minor fixes

apps/red-ui/src/app/modules/admin/screens/default-colors/default-colors-screen.component.ts

@@ -9,7 +9,7 @@ import { FilterService } from '@shared/services/filter.service';
 import { SearchService } from '@shared/services/search.service';
 import { ScreenStateService } from '@shared/services/screen-state.service';
 import { BaseListingComponent } from '@shared/base/base-listing.component';
-import { SortingOrders, SortingService } from '../../../../services/sorting.service';
+import { SortingService } from '../../../../services/sorting.service';
 
 @Component({
     templateUrl: './default-colors-screen.component.html',

apps/red-ui/src/app/modules/dossier/components/file-actions/file-actions.component.html

@@ -1,9 +1,6 @@
 <div *ngIf="screen === 'dossier-overview'" [class.active]="actionMenuOpen" class="action-buttons">
     <ng-container *ngTemplateOutlet="actions"></ng-container>
-    <redaction-status-bar
-        *ngIf="fileStatus.isWorkable"
-        [config]="statusBarConfig"
-    ></redaction-status-bar>
+    <redaction-status-bar *ngIf="fileStatus?.isWorkable" [config]="statusBarConfig"></redaction-status-bar>
 </div>
 
 <ng-container *ngIf="screen === 'file-preview'">
@@ -11,7 +8,7 @@
 </ng-container>
 
 <ng-template #actions>
-    <div class="file-actions">
+    <div class="file-actions" *ngIf="fileStatus">
         <!-- delete-->
         <redaction-circle-button
             (action)="openDeleteFileDialog($event)"
@@ -94,11 +91,7 @@
             *ngIf="permissionsService.isReadyForApproval(fileStatus)"
             [disabled]="!permissionsService.canApprove(fileStatus)"
             [tooltipPosition]="tooltipPosition"
-            [tooltip]="
-                permissionsService.canApprove(fileStatus)
-                    ? 'dossier-overview.approve'
-                    : 'dossier-overview.approve-disabled'
-            "
+            [tooltip]="permissionsService.canApprove(fileStatus) ? 'dossier-overview.approve' : 'dossier-overview.approve-disabled'"
             [type]="buttonType"
             icon="red:approved"
         ></redaction-circle-button>

apps/red-ui/src/app/modules/dossier/components/file-workload/file-workload.component.html

@@ -133,7 +133,11 @@
                         <redaction-empty-state [horizontalPadding]="24" [verticalPadding]="40" icon="red:document" screen="file-preview">
                             <ng-container *ngIf="fileData?.fileStatus?.excludedPages?.includes(activeViewerPage)">
                                 {{ 'file-preview.tabs.annotations.page-is' | translate }}
-                                <a (click)="actionPerformed.emit('view-exclude-pages')" translate="file-preview.excluded-from-redaction">
+                                <a
+                                    (click)="actionPerformed.emit('view-exclude-pages')"
+                                    class="with-underline"
+                                    translate="file-preview.excluded-from-redaction"
+                                >
                                 </a
                                 >.
                             </ng-container>

apps/red-ui/src/app/modules/dossier/components/page-exclusion/page-exclusion.component.ts

@@ -5,7 +5,6 @@ import { PageRange, ReanalysisControllerService } from '@redaction/red-ui-http';
 import { FileDataModel } from '../../../../models/file/file-data.model';
 import { Toaster } from '../../../../services/toaster.service';
 import { LoadingService } from '../../../../services/loading.service';
-import { TranslateService } from '@ngx-translate/core';
 
 @Component({
     selector: 'redaction-page-exclusion',

apps/red-ui/src/app/services/router-history.service.ts

@@ -9,13 +9,11 @@ export class RouterHistoryService {
     private _lastDossiersScreen = '/main/dossiers';
 
     constructor(private readonly _router: Router) {
-        this._router.events
-            .pipe(filter(event => event instanceof NavigationEnd))
-            .subscribe((event: NavigationEnd) => {
-                if (event.url.startsWith('/main/dossiers')) {
-                    this._lastDossiersScreen = event.url;
-                }
-            });
+        this._router.events.pipe(filter(event => event instanceof NavigationEnd)).subscribe((event: NavigationEnd) => {
+            if (event.url.startsWith('/main/dossiers')) {
+                this._lastDossiersScreen = event.url;
+            }
+        });
     }
 
     navigateToLastDossiersScreen() {

apps/red-ui/src/assets/styles/red-text-styles.scss

@@ -9,6 +9,12 @@ a {
         color: lighten($primary, 10%);
     }
 
+    &.with-underline {
+        &:hover {
+            text-decoration: underline;
+        }
+    }
+
     cursor: pointer;
 }