From b03607dd1f2bf1884c56ac93e44a3c4023e9b884 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adina=20=C8=9Aeudan?= <adina@devplant.ro>
Date: Mon, 2 Nov 2020 04:41:03 +0200
Subject: [PATCH] Filter fixes

---
 apps/red-ui/src/app/common/filter/filter.component.html | 2 +-
 apps/red-ui/src/app/common/filter/filter.component.ts   | 9 ++++-----
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/apps/red-ui/src/app/common/filter/filter.component.html b/apps/red-ui/src/app/common/filter/filter.component.html
index 8c91c5b1f..3573e1023 100644
--- a/apps/red-ui/src/app/common/filter/filter.component.html
+++ b/apps/red-ui/src/app/common/filter/filter.component.html
@@ -29,7 +29,7 @@
         </div>
         <div *ngFor="let filter of filters">
             <div class="mat-menu-item flex" (click)="toggleFilterExpanded($event, filter)">
-                <div class="arrow-wrapper" *ngIf="filter.filters">
+                <div class="arrow-wrapper" *ngIf="filter.filters && filter.filters.length">
                     <mat-icon *ngIf="filter.expanded" svgIcon="red:arrow-down" color="accent">
                     </mat-icon>
                     <mat-icon *ngIf="!filter.expanded" color="accent" svgIcon="red:arrow-right">
diff --git a/apps/red-ui/src/app/common/filter/filter.component.ts b/apps/red-ui/src/app/common/filter/filter.component.ts
index 66db2bb09..ab5f6a049 100644
--- a/apps/red-ui/src/app/common/filter/filter.component.ts
+++ b/apps/red-ui/src/app/common/filter/filter.component.ts
@@ -7,7 +7,6 @@ import {
     SimpleChanges,
     TemplateRef
 } from '@angular/core';
-import { ManualRedactions } from '@redaction/red-ui-http';
 import { AppStateService } from '../../state/app-state.service';
 import { FilterModel } from './model/filter.model';
 import { handleCheckedValue } from './utils/filter-utils';
@@ -42,11 +41,11 @@ export class FilterComponent implements OnChanges {
     }
 
     activateAllFilters() {
-        this._setAlLFilters(true);
+        this._setAllFilters(true);
     }
 
     deactivateAllFilters() {
-        this._setAlLFilters(false);
+        this._setAllFilters(false);
     }
 
     get hasActiveFilters(): boolean {
@@ -67,10 +66,10 @@ export class FilterComponent implements OnChanges {
         filter.expanded = !filter.expanded;
     }
 
-    private _setAlLFilters(value: boolean) {
+    private _setAllFilters(value: boolean) {
         this.filters?.forEach((f) => {
             f.checked = value;
-            f.indeterminate = value;
+            f.indeterminate = false;
             f.filters.forEach((ff) => {
                 ff.checked = value;
             });