Marmelator/red-ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1.4k Wiki Activity

RED-4590: Sort method mutates the underlying array as well as return it. Separate blocks to emphasize.

Browse Source
This commit is contained in:
George 2023-02-06 14:47:25 +02:00
parent d0660bcb1f
commit c88da50045
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
apps/red-ui/src/app/modules/dossier-overview/config.service.ts
View File

@ -285,12 +285,12 @@ export class ConfigService {
label: this._translateService.instant(workflowFileStatusTranslations[status]),
}),
);
statusFilters.sort((a, b) => StatusSorter[a.id] - StatusSorter[b.id]);
filterGroups.push({
slug: 'statusFilters',
label: this._translateService.instant('filters.documents-status'),
icon: 'red:status',
filters: statusFilters.sort((a, b) => StatusSorter[a.id] - StatusSorter[b.id]),
filters: statusFilters,
checker: keyChecker('workflowStatus'),
});
}
@ -336,13 +336,13 @@ export class ConfigService {
},
}),
);
needsWorkFilters.sort(RedactionFilterSorter.byKey);
filterGroups.push({
slug: 'needsWorkFilters',
label: this._translateService.instant('filters.needs-work'),
icon: 'red:needs-work',
filterTemplate: needsWorkFilterTemplate,
filters: needsWorkFilters.sort(RedactionFilterSorter.byKey),
filters: needsWorkFilters,
checker: (file: File, filter: INestedFilter) => annotationFilterChecker(file, filter, this._userService.currentUser.id),
matchAll: true,
});

8
apps/red-ui/src/app/modules/dossiers-listing/config.service.ts
View File

@ -144,12 +144,12 @@ export class ConfigService {
label: this._translateService.instant(workflowFileStatusTranslations[status]),
}),
);
statusFilters.sort((a, b) => StatusSorter[a.id] - StatusSorter[b.id]);
filterGroups.push({
slug: 'statusFilters',
label: this._translateService.instant('filters.documents-status'),
icon: 'red:status',
filters: statusFilters.sort((a, b) => StatusSorter[a.id] - StatusSorter[b.id]),
filters: statusFilters,
checker: (dossier: Dossier, filter: INestedFilter) => this._dossierStatusChecker(dossier, filter),
});
@ -180,13 +180,13 @@ export class ConfigService {
},
}),
);
needsWorkFilters.sort((a, b) => RedactionFilterSorter[a.id] - RedactionFilterSorter[b.id]);
filterGroups.push({
slug: 'needsWorkFilters',
label: this._translateService.instant('filters.needs-work'),
icon: 'red:needs-work',
filterTemplate: needsWorkFilterTemplate,
filters: needsWorkFilters.sort((a, b) => RedactionFilterSorter[a.id] - RedactionFilterSorter[b.id]),
filters: needsWorkFilters,
checker: (dossier: Dossier, filter: INestedFilter) => this._annotationFilterChecker(dossier, filter),
matchAll: true,
});