From 3804acf3c1131af43ebc8cf5d0180841c9d31a97 Mon Sep 17 00:00:00 2001 From: Viktor Seifert Date: Thu, 23 Feb 2023 16:49:21 +0100 Subject: [PATCH] RED-6204: Removed redundant variable assignment (sonar issue) & simplified code --- .../classification/utils/RulingTextDirAdjustUtil.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/redaction-service-v1/redaction-service-server-v1/src/main/java/com/iqser/red/service/redaction/v1/server/classification/utils/RulingTextDirAdjustUtil.java b/redaction-service-v1/redaction-service-server-v1/src/main/java/com/iqser/red/service/redaction/v1/server/classification/utils/RulingTextDirAdjustUtil.java index e7a6600e..2a3e2a5b 100644 --- a/redaction-service-v1/redaction-service-server-v1/src/main/java/com/iqser/red/service/redaction/v1/server/classification/utils/RulingTextDirAdjustUtil.java +++ b/redaction-service-v1/redaction-service-server-v1/src/main/java/com/iqser/red/service/redaction/v1/server/classification/utils/RulingTextDirAdjustUtil.java @@ -25,16 +25,13 @@ public final class RulingTextDirAdjustUtil { private Point2D convertPoint(float x, float y, float dir, float pageWidth, float pageHeight) { var xAdj = getXRot(x, y, dir, pageWidth, pageHeight); - var yAdj = 0f; - if (dir == 0 || dir == 180) { - yAdj = pageHeight - getYLowerLeftRot(x, y, dir, pageWidth, pageHeight); - } else { - yAdj = pageWidth - getYLowerLeftRot(x, y, dir, pageWidth, pageHeight); - } + var yLowerLeftRot = getYLowerLeftRot(x, y, dir, pageWidth, pageHeight); + var yAdj = (dir == 0 || dir == 180) ? pageHeight - yLowerLeftRot : pageWidth - yLowerLeftRot; return new Point2D.Float(xAdj, yAdj); } + @SuppressWarnings("SuspiciousNameCombination") private float getXRot(float x, float y, float dir, float pageWidth, float pageHeight) { if (dir == 0) {