From 98f8d31fd6ced208703261009f87d70fee1f5910 Mon Sep 17 00:00:00 2001 From: corinaolariu Date: Fri, 28 Jun 2024 14:49:00 +0300 Subject: [PATCH] RED-9466 - Adding annotation removes all AI based recommendations until forced re-analysis - fix sonar issues --- .../v1/server/RedactionAcceptanceTest.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/redaction-service-v1/redaction-service-server-v1/src/test/java/com/iqser/red/service/redaction/v1/server/RedactionAcceptanceTest.java b/redaction-service-v1/redaction-service-server-v1/src/test/java/com/iqser/red/service/redaction/v1/server/RedactionAcceptanceTest.java index 314b9c26..7c37f628 100644 --- a/redaction-service-v1/redaction-service-server-v1/src/test/java/com/iqser/red/service/redaction/v1/server/RedactionAcceptanceTest.java +++ b/redaction-service-v1/redaction-service-server-v1/src/test/java/com/iqser/red/service/redaction/v1/server/RedactionAcceptanceTest.java @@ -178,10 +178,10 @@ public class RedactionAcceptanceTest extends AbstractRedactionIntegrationTest { var publishedInformationEntry1 = findEntityByTypeAndValue(entityLog, "published_information", "Oxford University Press").findFirst() .orElseThrow(); - assertThat(publishedInformationEntry1.getSection().startsWith("Paragraph:")); + assertThat(publishedInformationEntry1.getSection()).startsWith("Paragraph:"); var asyaLyon1 = findEntityByTypeAndValueAndSectionNumber(entityLog, "CBI_author", "Asya Lyon", publishedInformationEntry1.getContainingNodeId()).findFirst() .orElseThrow(); - assertThat(asyaLyon1.getSection().startsWith("Paragraph:")); + assertThat(asyaLyon1.getSection()).startsWith("Paragraph:"); assertEquals(EntryState.SKIPPED, asyaLyon1.getState()); var idRemoval = buildIdRemoval(publishedInformationEntry1.getId()); @@ -232,10 +232,10 @@ public class RedactionAcceptanceTest extends AbstractRedactionIntegrationTest { var publishedInformationEntry1 = findEntityByTypeAndValue(entityLog, "published_information", "Oxford University Press").findFirst() .orElseThrow(); - assertThat(publishedInformationEntry1.getSection().startsWith("Paragraph:")); + assertThat(publishedInformationEntry1.getSection()).startsWith("Paragraph:"); var asyaLyon1 = findEntityByTypeAndValueAndSectionNumber(entityLog, "CBI_author", "Asya Lyon", publishedInformationEntry1.getContainingNodeId()).findFirst() .orElseThrow(); - assertThat(publishedInformationEntry1.getSection().startsWith("Paragraph:")); + assertThat(publishedInformationEntry1.getSection()).startsWith("Paragraph:"); assertEquals(EntryState.SKIPPED, asyaLyon1.getState()); var idRemoval = buildIdRemoval(publishedInformationEntry1.getId()); @@ -387,7 +387,7 @@ public class RedactionAcceptanceTest extends AbstractRedactionIntegrationTest { @Test @SneakyThrows - public void testNerEntitiesAfterReanalysis() { + void testNerEntitiesAfterReanalysis() { String EFSA_SANITISATION_RULES = loadFromClassPath("drools/efsa_sanitisation.drl"); when(rulesClient.getRules(TEST_DOSSIER_TEMPLATE_ID, RuleFileType.ENTITY)).thenReturn(JSONPrimitive.of(EFSA_SANITISATION_RULES)); @@ -413,7 +413,7 @@ public class RedactionAcceptanceTest extends AbstractRedactionIntegrationTest { String nerValue = "Osip S."; var nerEntity = findEntityByTypeAndValue(entityLog, DICTIONARY_AUTHOR, nerValue).findFirst() .orElseThrow(); - assertThat(nerEntity.getEngines().contains(Engine.NER)); + assertThat(nerEntity.getEngines()).contains(Engine.NER); String dictionaryAddValue = "cooperation"; ManualRedactionEntry manualRedactionEntry = ManualRedactionEntry.builder() @@ -444,11 +444,11 @@ public class RedactionAcceptanceTest extends AbstractRedactionIntegrationTest { .filter(entityLogEntry -> entityLogEntry.getValue().equals(dictionaryAddValue)) .findFirst() .get(); - assertEquals(entityLogEntryAdded.getState(), EntryState.APPLIED); + assertEquals(EntryState.APPLIED, entityLogEntryAdded.getState()); nerEntity = findEntityByTypeAndValue(entityLog, DICTIONARY_AUTHOR, nerValue).findFirst() .orElseThrow(); - assertThat(nerEntity.getEngines().contains(Engine.NER)); + assertThat(nerEntity.getEngines()).contains(Engine.NER); dossierDictionary.get(DICTIONARY_AUTHOR).remove(dictionaryAddValue); }