From c7643da4788b7c9fb97428c409ff6e3eb2e19919 Mon Sep 17 00:00:00 2001
From: Thomas Beyer <thomas.beyer@iqser.com>
Date: Tue, 28 Mar 2023 11:23:52 +0200
Subject: [PATCH] RED-6411 - optimize method

---
 .../v1/server/redaction/utils/EntitySearchUtils.java     | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/redaction-service-v1/redaction-service-server-v1/src/main/java/com/iqser/red/service/redaction/v1/server/redaction/utils/EntitySearchUtils.java b/redaction-service-v1/redaction-service-server-v1/src/main/java/com/iqser/red/service/redaction/v1/server/redaction/utils/EntitySearchUtils.java
index 097bc43c..efbfcdc0 100644
--- a/redaction-service-v1/redaction-service-server-v1/src/main/java/com/iqser/red/service/redaction/v1/server/redaction/utils/EntitySearchUtils.java
+++ b/redaction-service-v1/redaction-service-server-v1/src/main/java/com/iqser/red/service/redaction/v1/server/redaction/utils/EntitySearchUtils.java
@@ -289,11 +289,14 @@ public final class EntitySearchUtils {
         }
     }
 
-    private boolean isOneARecommendationAndTheOtherEntity (Entity found, Entity existing) {
+    private boolean isOneARecommendationAndTheOtherEntity(Entity entityOne, Entity entityTwo) {
 
-        return existing.getEntityType().equals(EntityType.RECOMMENDATION) && found.getEntityType().equals(EntityType.ENTITY) || existing.getEntityType()
-                .equals(EntityType.ENTITY) && found.getEntityType().equals(EntityType.RECOMMENDATION);
+        var entityTypeOne = entityOne.getEntityType();
+        var entityTypeTwo = entityTwo.getEntityType();
+        return entityTypeTwo.equals(EntityType.RECOMMENDATION) && entityTypeOne.equals(EntityType.ENTITY)
+                || entityTypeTwo.equals(EntityType.ENTITY) && entityTypeOne.equals(EntityType.RECOMMENDATION);
     }
+
     public void addEntitiesIgnoreRank(Set<Entity> entities, Set<Entity> found) {
         // HashSet keeps old value but we want the new.
         entities.removeAll(found);